Skip to contentSkip to conversation

board: phytec: imx8mm: Add PHYTEC phyCORE-i.MX8MM support

PATCH New Teresa Remmet 2 participants 3 messages Aug 20, 2020 – Aug 21, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board: phytec: imx8mm: Add PHYTEC phyCORE-i.MX8MM support

Add support PHYTEC phyCORE-i.MX8MM SOM.

Supported features:
- 2GB LPDDR4 RAM
- 1x 1Gbit Ethernet
- eMMC
- external SD
- debug UART3
- watchdog
- i2c eeprom

---
 arch/arm/dts/Makefile                        |    1 +
 arch/arm/dts/phycore-imx8mm-u-boot.dtsi      |  100 ++
 arch/arm/dts/phycore-imx8mm.dts              |  259 ++++
 arch/arm/mach-imx/imx8m/Kconfig              |    6 +
 board/phytec/phycore_imx8mm/Kconfig          |   12 +
 board/phytec/phycore_imx8mm/MAINTAINERS      |    9 +
 board/phytec/phycore_imx8mm/Makefile         |   11 +
 board/phytec/phycore_imx8mm/lpddr4_timing.c  | 1846 ++++++++++++++++++++++++++
 board/phytec/phycore_imx8mm/phycore-imx8mm.c |   53 +
 board/phytec/phycore_imx8mm/spl.c            |  128 ++
 configs/phycore-imx8mm_defconfig             |  103 ++
 include/configs/phycore_imx8mm.h             |  131 ++
 12 files changed, 2659 insertions(+)
 create mode 100644 arch/arm/dts/phycore-imx8mm-u-boot.dtsi
 create mode 100644 arch/arm/dts/phycore-imx8mm.dts
 create mode 100644 board/phytec/phycore_imx8mm/Kconfig
 create mode 100644 board/phytec/phycore_imx8mm/MAINTAINERS
 create mode 100644 board/phytec/phycore_imx8mm/Makefile
 create mode 100644 board/phytec/phycore_imx8mm/lpddr4_timing.c
 create mode 100644 board/phytec/phycore_imx8mm/phycore-imx8mm.c
 create mode 100644 board/phytec/phycore_imx8mm/spl.c
 create mode 100644 configs/phycore-imx8mm_defconfig
 create mode 100644 include/configs/phycore_imx8mm.h
arch/arm/dts/Makefile +1 -0
index 7e29b9096b93..d72037ae4d7d 100644
@@ -762,6 +762,7 @@ dtb-$(CONFIG_ARCH_IMX8) += \
 dtb-$(CONFIG_ARCH_IMX8M) += \
 	imx8mm-evk.dtb \
 	imx8mm-verdin.dtb \
+	phycore-imx8mm.dtb \
 	imx8mn-ddr4-evk.dtb \
 	imx8mq-evk.dtb \
 	imx8mm-beacon-kit.dtb \
arch/arm/dts/phycore-imx8mm-u-boot.dtsi new file +100 -0

100 lines not on this page · raw message

arch/arm/dts/phycore-imx8mm.dts new file +259 -0

259 lines not on this page · raw message

arch/arm/mach-imx/imx8m/Kconfig +6 -0
index 7771fc88afeb..8615dc3bec99 100644
@@ -72,6 +72,11 @@ config TARGET_IMX8MM_BEACON
 	select SUPPORT_SPL
 	select IMX8M_LPDDR4
 
+config TARGET_PHYCORE_IMX8MM
+	bool "PHYTEC PHYCORE i.MX8MM"
+	select IMX8MM
+        select SUPPORT_SPL
+	select IMX8M_LPDDR4
 endchoice
 
 source "board/freescale/imx8mq_evk/Kconfig"
@@ -82,5 +87,6 @@ source "board/google/imx8mq_phanbell/Kconfig"
 source "board/technexion/pico-imx8mq/Kconfig"
 source "board/toradex/verdin-imx8mm/Kconfig"
 source "board/beacon/imx8mm/Kconfig"
+source "board/phytec/phycore_imx8mm/Kconfig"
 
 endif
board/phytec/phycore_imx8mm/Kconfig new file +12 -0
new file mode 100644
index 000000000000..92f5524bdb07
@@ -0,0 +1,12 @@
+if TARGET_PHYCORE_IMX8MM
+
+config SYS_BOARD
+	default "phycore_imx8mm"
+
+config SYS_VENDOR
+	default "phytec"
+
+config SYS_CONFIG_NAME
+	default "phycore_imx8mm"
+
+endif
board/phytec/phycore_imx8mm/MAINTAINERS new file +9 -0
new file mode 100644
index 000000000000..9edec7b7d283
@@ -0,0 +1,9 @@
+phyCORE-i.MX8M Mini
+M:      Teresa Remmet <[email protected]>
+W:      https://www.phytec.eu/product-eu/system-on-modules/phycore-imx-8m-mini-nano/
+S:      Maintained
+F:      arch/arm/dts/phycore-imx8mm.dts
+F:      arch/arm/dts/phycore-imx8mm-u-boot.dtsi
+F:      board/phytec/phycore_imx8mm/
+F:      configs/phycore-imx8mm_defconfig
+F:      include/configs/phycore_imx8mm.h
board/phytec/phycore_imx8mm/Makefile new file +11 -0
new file mode 100644
index 000000000000..27f6c027b6cd
@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+#
+# Copyright (C) 2019-2020 PHYTEC Messtechnik GmbH
+# Author: Teresa Remmet <[email protected]>
+
+obj-y += phycore-imx8mm.o
+
+ifdef CONFIG_SPL_BUILD
+obj-y += spl.o
+obj-$(CONFIG_IMX8M_LPDDR4) += lpddr4_timing.o
+endif
board/phytec/phycore_imx8mm/lpddr4_timing.c new file +1846 -0

1,846 lines not on this page · raw message

board/phytec/phycore_imx8mm/phycore-imx8mm.c new file +53 -0

53 lines not on this page · raw message

board/phytec/phycore_imx8mm/spl.c new file +128 -0

128 lines not on this page · raw message

configs/phycore-imx8mm_defconfig new file +103 -0

103 lines not on this page · raw message

include/configs/phycore_imx8mm.h new file +131 -0

131 lines not on this page · raw message

Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 board: phytec: imx8mm: Add PHYTEC phyCORE-i.MX8MM support

Quoted 10 lines · Teresa Remmet

Add support PHYTEC phyCORE-i.MX8MM SOM.

Supported features:
- 2GB LPDDR4 RAM
- 1x 1Gbit Ethernet
- eMMC
- external SD
- debug UART3
- watchdog
- i2c eeprom

[snip]

include/configs/phycore_imx8mm.h line 39

Quoted 5 lines
include/configs/phycore_imx8mm.h new file +5 -0
+#define CONFIG_EXTRA_ENV_SETTINGS \
+	"image=Image\0" \
+	"console=ttymxc2,115200\0" \
+	"fdt_addr=0x44000000\0" \
+	"fdt_high=0xffffffffffffffff\0" \

Disabling fdt relocation is a bad idea. If U-Boot is moving it to outside of kernel visible memory you want to use bootm_size to limit the window to what will be visible to the kernel.

[snip]

include/configs/phycore_imx8mm.h line 87

Quoted 3 lines
include/configs/phycore_imx8mm.h new file +3 -0
+/* Link Definitions */
+#define CONFIG_LOADADDR			0x40480000
+#define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR

This ends up with a fairly small gap between the kernel and the device tree and is a good way to end up with the kernel corrupting the device tree.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm64/booting.rst
is a good reference but I think in short I think you might want to move fdt_addr up to 0x48000000. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200820/60fe393d/attachment.sig>
#2 lore raw

PATCH 1/1 board: phytec: imx8mm: Add PHYTEC phyCORE-i.MX8MM support

Hello Tom,

Am Donnerstag, den 20.08.2020, 09:22 -0400 schrieb Tom Rini:

Quoted 14 lines · Teresa Remmet
Quoted 11 lines

Add support PHYTEC phyCORE-i.MX8MM SOM.

Supported features:
- 2GB LPDDR4 RAM
- 1x 1Gbit Ethernet
- eMMC
- external SD
- debug UART3
- watchdog
- i2c eeprom

[snip]

Quoted 9 lines

include/configs/phycore_imx8mm.h line 39

Quoted 5 lines
include/configs/phycore_imx8mm.h new file +5 -0
+#define CONFIG_EXTRA_ENV_SETTINGS \
+	"image=Image\0" \
+	"console=ttymxc2,115200\0" \
+	"fdt_addr=0x44000000\0" \
+	"fdt_high=0xffffffffffffffff\0" \

Disabling fdt relocation is a bad idea. If U-Boot is moving it to outside of kernel visible memory you want to use bootm_size to limit the window to what will be visible to the kernel.

I will remove it.

Quoted 12 lines

[snip]

include/configs/phycore_imx8mm.h line 87

Quoted 3 lines
include/configs/phycore_imx8mm.h new file +3 -0
+/* Link Definitions */
+#define CONFIG_LOADADDR			0x40480000
+#define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR

This ends up with a fairly small gap between the kernel and the device
tree and is a good way to end up with the kernel corrupting the device
tree.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm64/booting.rst

Quoted 3 lines

is a good reference but I think in short I think you might want to move
fdt_addr up to 0x48000000. Thanks!

I will change this also in v2.

Thanks for explanation and review.

Teresa

Quoted 1 line