Skip to contentSkip to conversation

leds: s3c24xx: Remove unused machine header include

PATCH Applied Krzysztof Kozlowski 2 participants 5 messages Aug 3, 2020 – Aug 20, 2020

Subsystems (2)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 leds: s3c24xx: Remove unused machine header include

The driver includes machine header for GPIO registers but actually does not use them.

---
 drivers/leds/leds-s3c24xx.c | 2 --
 1 file changed, 2 deletions(-)
drivers/leds/leds-s3c24xx.c +0 -2
index 9b5e67664ba3..3c0c7aa63b8c 100644
@@ -16,8 +16,6 @@
 #include <linux/module.h>
 #include <linux/platform_data/leds-s3c24xx.h>
 
-#include <mach/regs-gpio.h>
-
 /* our context */
 
 struct s3c24xx_gpio_led {
Signature · 1 line
2.17.1
Applied
#1 lore raw
Quoted 4 lines · Krzysztof Kozlowski

The driver includes machine header for GPIO registers but actually does not use them.

Thanks, applied.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author maintainer
#2 lore raw
Quoted 7 lines · Pavel Machek
Quoted 4 lines · Krzysztof Kozlowski

The driver includes machine header for GPIO registers but actually does not use them.

Thanks, applied.

Hi Pavel,

I am confused because I had impression this will go into v5.9-rc1 but it's not there. My further S3C cleanup depends on it [1] and now applying of the patches stuck in the middle.

I could take the patch through samsung-soc along with the rest of the series or pull from stable tag (but tag with only that patch...).

Best regards,
Krzysztof

author maintainer
#3 lore raw
Quoted 9 lines · Krzysztof Kozlowski
Quoted 7 lines · Pavel Machek
Quoted 4 lines · Krzysztof Kozlowski

The driver includes machine header for GPIO registers but actually does not use them.

Thanks, applied.

Quoted 8 lines

Hi Pavel,

I am confused because I had impression this will go into v5.9-rc1 but it's not there. My further S3C cleanup depends on it [1] and now applying of the patches stuck in the middle.

I could take the patch through samsung-soc along with the rest of the series or pull from stable tag (but tag with only that patch...).

... and the missing link:
[1] https://marc.info/?l=dri-devel&m=159793916332137&w=2

Best regards,
Krzysztof

#4 lore raw
In reply to Krzysztof Kozlowski
Quoted 7 lines · Krzysztof Kozlowski
Quoted 6 lines · Pavel Machek
Quoted 4 lines · Krzysztof Kozlowski

The driver includes machine header for GPIO registers but actually does not use them.

Quoted 7 lines
Quoted 1 line

Thanks, applied.

Hi Pavel,

I am confused because I had impression this will go into v5.9-rc1 but it's not there. My further S3C cleanup depends on it [1] and now applying of the patches stuck in the middle.

It was too late for -rc1 at that moment. It is on my for-next branch now.

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html