Skip to contentSkip to conversation

mm/highmem: Clean up endif comments

PATCH Applied [email protected] 2 participants 2 messages Aug 19, 2020 – Aug 20, 2020

Subsystems (2)
Memory management MM core
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 mm/highmem: Clean up endif comments

From: Ira Weiny <[email protected]>

The #endif at the end of the file matches up with the '#if defined(HASHED_PAGE_VIRTUAL)' on line 374. Not the CONFIG_HIGHMEM #if earlier.

Fix comments on both of the #endif's to indicate the correct end of blocks for each.

Signed-off-by Ira Weiny <[email protected]>
---
 mm/highmem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
mm/highmem.c +2 -2
index 64d8dea47dd1..1352a27951e3 100644
@@ -369,7 +369,7 @@ void kunmap_high(struct page *page)
 }
 
 EXPORT_SYMBOL(kunmap_high);
-#endif
+#endif	/* CONFIG_HIGHMEM */
 
 #if defined(HASHED_PAGE_VIRTUAL)
 

@@ -481,4 +481,4 @@ void __init page_address_init(void)
 	}
 }
 
-#endif	/* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
+#endif	/* defined(HASHED_PAGE_VIRTUAL) */
Signature · 1 line
2.25.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · On Wed, Aug 19, 2020 at 11:46:35AM -0700, [email protected] wrote:

From: Ira Weiny <[email protected]>

The #endif at the end of the file matches up with the '#if defined(HASHED_PAGE_VIRTUAL)' on line 374. Not the CONFIG_HIGHMEM #if earlier.

Fix comments on both of the #endif's to indicate the correct end of blocks for each.

Signed-off-by Ira Weiny <[email protected]>
Reviewed-by Mike Rapoport <[email protected]>
Quoted 27 lines
---
 mm/highmem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
mm/highmem.c +2 -2
index 64d8dea47dd1..1352a27951e3 100644
@@ -369,7 +369,7 @@ void kunmap_high(struct page *page)
 }
 
 EXPORT_SYMBOL(kunmap_high);
-#endif
+#endif	/* CONFIG_HIGHMEM */
 
 #if defined(HASHED_PAGE_VIRTUAL)
 

@@ -481,4 +481,4 @@ void __init page_address_init(void)
 	}
 }
 
-#endif	/* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
+#endif	/* defined(HASHED_PAGE_VIRTUAL) */
Signature · 1 line
2.25.1
Signature · 2 lines
Sincerely yours,
Mike.