Skip to contentSkip to conversation

PCI: Remove unnecessary headers include

PATCH Applied Gustavo Pimentel 2 participants 5 messages Aug 13, 2020 – Aug 20, 2020 PCI

lore
Share & tools
lore
#0 lore raw

cover PCI: Remove unnecessary headers include

Coverity Scan has detected 3 headers include that don't provide any symbol required by the current code implemented on drivers/pci/pci.c, therefore this patchset aims to remove those entries.

Gustavo Pimentel (3):
PCI: Remove unnecessary header include (linux/of_pci.h)
PCI: Remove unnecessary header include (linux/pci-ats.h)
PCI: Remove unnecessary header include (asm/setup.h)

 drivers/pci/pci.c | 3 ---
 1 file changed, 3 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/3 PCI: Remove unnecessary header include (linux/of_pci.h)

Remove unnecessary header include (linux/of_pci.h) since it doesn't provide any needed symbols.

Detected by CoverityScan CID 16442 ("Unnecessary header file (HFA)")

---
 drivers/pci/pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/pci/pci.c +0 -1
index c9338f9..e88a169 100644
@@ -15,7 +15,6 @@
 #include <linux/init.h>
 #include <linux/msi.h>
 #include <linux/of.h>
-#include <linux/of_pci.h>
 #include <linux/pci.h>
 #include <linux/pm.h>
 #include <linux/slab.h>
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/3 PCI: Remove unnecessary header include (linux/pci-ats.h)

In reply to Gustavo Pimentel

Remove unnecessary header include (linux/pci-ats.h) since it doesn't provide any needed symbols.

Detected by CoverityScan CID 16443 ("Unnecessary header file (HFA)")

---
 drivers/pci/pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/pci/pci.c +0 -1
index e88a169..af68e79 100644
@@ -29,7 +29,6 @@
 #include <linux/pm_runtime.h>
 #include <linux/pci_hotplug.h>
 #include <linux/vmalloc.h>
-#include <linux/pci-ats.h>
 #include <asm/setup.h>
 #include <asm/dma.h>
 #include <linux/aer.h>
Signature · 1 line
2.7.4
#3 lore raw

PATCH 3/3 PCI: Remove unnecessary header include (asm/setup.h)

In reply to Gustavo Pimentel

Remove unnecessary header include (asm/setup.h) since it doesn't provide any needed symbols.

Detected by CoverityScan CID 16444 ("Unnecessary header file (HFA)")

---
 drivers/pci/pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/pci/pci.c +0 -1
index af68e79..39d808a 100644
@@ -29,7 +29,6 @@
 #include <linux/pm_runtime.h>
 #include <linux/pci_hotplug.h>
 #include <linux/vmalloc.h>
-#include <asm/setup.h>
 #include <asm/dma.h>
 #include <linux/aer.h>
 #include "pci.h"
Signature · 1 line
2.7.4
#4 lore raw
In reply to Gustavo Pimentel
Quoted 9 lines · Gustavo Pimentel

Coverity Scan has detected 3 headers include that don't provide any symbol required by the current code implemented on drivers/pci/pci.c, therefore this patchset aims to remove those entries.

Gustavo Pimentel (3):
PCI: Remove unnecessary header include (linux/of_pci.h)
PCI: Remove unnecessary header include (linux/pci-ats.h)
PCI: Remove unnecessary header include (asm/setup.h)

Applied to pci/misc for v5.10, thanks, Gustavo!

Quoted 7 lines
 drivers/pci/pci.c | 3 ---
 1 file changed, 3 deletions(-)
Signature · 1 line
2.7.4