Skip to contentSkip to conversation

prism54: Use fallthrough pseudo-keyword

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Aug 21, 2020 – Aug 27, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 prism54: Use fallthrough pseudo-keyword

Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

---
 drivers/net/wireless/intersil/prism54/isl_38xx.c   | 2 +-
 drivers/net/wireless/intersil/prism54/isl_ioctl.c  | 2 +-
 drivers/net/wireless/intersil/prism54/islpci_dev.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/intersil/prism54/isl_38xx.c +1 -1
index a1f956707887..ae964de347f7 100644
@@ -223,7 +223,7 @@ isl38xx_in_queue(isl38xx_control_block *cb, int queue)
 		/* send queues */
 	case ISL38XX_CB_TX_MGMTQ:
 		BUG_ON(delta > ISL38XX_CB_MGMT_QSIZE);
-		/* fall through */
+		fallthrough;
 
 	case ISL38XX_CB_TX_DATA_LQ:
 	case ISL38XX_CB_TX_DATA_HQ:
drivers/net/wireless/intersil/prism54/isl_ioctl.c +1 -1
index 3ccf2a4b548c..9192c5a3923e 100644
@@ -1691,7 +1691,7 @@ static int prism54_get_encodeext(struct net_device *ndev,
 	case DOT11_AUTH_BOTH:
 	case DOT11_AUTH_SK:
 		wrqu->encoding.flags |= IW_ENCODE_RESTRICTED;
-		/* fall through */
+		fallthrough;
 	case DOT11_AUTH_OS:
 	default:
 		wrqu->encoding.flags |= IW_ENCODE_OPEN;
drivers/net/wireless/intersil/prism54/islpci_dev.c +1 -1
index efd64e555bb5..8eb6d5e4bd57 100644
@@ -918,7 +918,7 @@ islpci_set_state(islpci_private *priv, islpci_state_t new_state)
 	switch (new_state) {
 	case PRV_STATE_OFF:
 		priv->state_off++;
-		/* fall through */
+		fallthrough;
 	default:
 		priv->state = new_state;
 		break;
Signature · 1 line
2.27.0
#1 lore raw
Quoted 6 lines · Gustavo A. R. Silva

Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Patch applied to wireless-drivers-next.git, thanks.

f7bba4d94d53 prism54: Use fallthrough pseudo-keyword

Signature · 3 lines
https://patchwork.kernel.org/patch/11728213/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches