atmel: Use fallthrough pseudo-keyword

PATCH In review Gustavo A. R. Silva 2 participants 3 messages Aug 21, 2020 – Aug 27, 2020

Subsystems (4)

Networking Network drivers Networking drivers (wireless) Arm/Microchip (AT91) SoC support

lore

Share & tools

lore

Gustavo A. R. Silva

author

2020-08-21 06:48 UTC #0 lore raw

PATCH 1/1 atmel: Use fallthrough pseudo-keyword

Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/net/wireless/atmel/at76c50x-usb.c | 2 +-
 drivers/net/wireless/atmel/atmel.c        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/net/wireless/atmel/at76c50x-usb.c +1 -1

index a63b5c2f1e17..b760c6682c4f 100644
@@ -432,7 +432,7 @@ static int at76_usbdfu_download(struct usb_device *udev, u8 *buf, u32 size,
 
 		case STATE_DFU_DOWNLOAD_IDLE:
 			at76_dbg(DBG_DFU, "DOWNLOAD...");
-			/* fall through */
+			fallthrough;
 		case STATE_DFU_IDLE:
 			at76_dbg(DBG_DFU, "DFU IDLE");

drivers/net/wireless/atmel/atmel.c +1 -1

index d5875836068c..6c97a1af5e8e 100644
@@ -1227,7 +1227,7 @@ static irqreturn_t service_interrupt(int irq, void *dev_id)
 
 		case ISR_RxFRAMELOST:
 			priv->wstats.discard.misc++;
-			/* fall through */
+			fallthrough;
 		case ISR_RxCOMPLETE:
 			rx_done_irq(priv);
 			break;

Signature · 1 line

2.27.0

Kalle Valo

2020-08-27 13:10 UTC #1 lore raw

Quoted 6 lines · Gustavo A. R. Silva

Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1].
[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by Gustavo A. R. Silva <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

9ccac12996ec atmel: Use fallthrough pseudo-keyword

Signature · 3 lines

https://patchwork.kernel.org/patch/11728241/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Gustavo A. R. Silva

author

2020-08-27 19:32 UTC #2 lore raw

Quoted 11 lines · Kalle Valo

Quoted 6 lines · Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1].
[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by Gustavo A. R. Silva <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.

Thanks, Kalle.

--
Gustavo