Skip to contentSkip to conversation

powerpc/perf/hv-24x7: Move cpumask file to top folder of hv-24x7 driver

PATCH Applied Kajol Jain 2 participants 2 messages Aug 21, 2020 – Aug 27, 2020 PowerPC

lore
Share & tools
lore

Kajol Jain

author
#0 lore raw

PATCH 1/1 powerpc/perf/hv-24x7: Move cpumask file to top folder of hv-24x7 driver

Commit 792f73f747b8 ("powerpc/hv-24x7: Add sysfs files inside hv-24x7 device to show cpumask") added cpumask file as part of hv-24x7 driver inside the interface folder. Cpumask file suppose to be in the top folder of the pmu driver inorder to make hotplug works.

This patch fix that issue and create new group 'cpumask_attr_group' to add cpumask file and make sure it added on top folder.

command:# cat /sys/devices/hv_24x7/cpumask
0

Fixes 792f73f747b8 ("powerpc/hv-24x7: Add sysfs files inside hv-24x7

device to show cpumask")

---
 .../testing/sysfs-bus-event_source-devices-hv_24x7    |  2 +-
 arch/powerpc/perf/hv-24x7.c                           | 11 ++++++++++-
 2 files changed, 11 insertions(+), 2 deletions(-)
Documentation/ABI/testing/sysfs-bus-event_source-devices-hv_24x7 +1 -1
index f7e32f218f73..e82fc37be802 100644
@@ -43,7 +43,7 @@ Description:	read only
 		This sysfs interface exposes the number of cores per chip
 		present in the system.
 
-What:		/sys/devices/hv_24x7/interface/cpumask
+What:		/sys/devices/hv_24x7/cpumask
 Date:		July 2020
 Contact:	Linux on PowerPC Developer List <[email protected]>
 Description:	read only
arch/powerpc/perf/hv-24x7.c +10 -1
index cdb7bfbd157e..6e7e820508df 100644
@@ -1128,6 +1128,15 @@ static struct bin_attribute *if_bin_attrs[] = {
 	NULL,
 };
 
+static struct attribute *cpumask_attrs[] = {
+	&dev_attr_cpumask.attr,
+	NULL,
+};
+
+static struct attribute_group cpumask_attr_group = {
+	.attrs = cpumask_attrs,
+};
+
 static struct attribute *if_attrs[] = {
 	&dev_attr_catalog_len.attr,
 	&dev_attr_catalog_version.attr,
@@ -1135,7 +1144,6 @@ static struct attribute *if_attrs[] = {
 	&dev_attr_sockets.attr,
 	&dev_attr_chipspersocket.attr,
 	&dev_attr_coresperchip.attr,
-	&dev_attr_cpumask.attr,
 	NULL,
 };
 
@@ -1151,6 +1159,7 @@ static const struct attribute_group *attr_groups[] = {
 	&event_desc_group,
 	&event_long_desc_group,
 	&if_group,
+	&cpumask_attr_group,
 	NULL,
 };
 
Signature · 1 line
2.18.2
#1 lore raw
Quoted 9 lines · Kajol Jain

Commit 792f73f747b8 ("powerpc/hv-24x7: Add sysfs files inside hv-24x7 device to show cpumask") added cpumask file as part of hv-24x7 driver inside the interface folder. Cpumask file suppose to be in the top folder of the pmu driver inorder to make hotplug works.

This patch fix that issue and create new group 'cpumask_attr_group' to add cpumask file and make sure it added on top folder.

[...]

Applied to powerpc/fixes.

[1/1] powerpc/perf/hv-24x7: Move cpumask file to top folder of hv-24x7 driver

      https://git.kernel.org/powerpc/c/64ef8f2c4791940d7f3945507b6a45c20d959260

cheers