net: dsa: b53: check for timeout
PATCH 1/1 net: dsa: b53: check for timeout
From: Tom Rix <[email protected]>
clang static analysis reports this problem
b53_common.c:1583:13: warning: The left expression of the compound
assignment is an uninitialized value. The computed value will also be garbage
ent.port &= ~BIT(port);
~~~~~~~~ ^ent is set by a successful call to b53_arl_read(). Unsuccessful calls are caught by an switch statement handling specific returns. b32_arl_read() calls b53_arl_op_wait() which fails with the unhandled -ETIMEDOUT.
So add -ETIMEDOUT to the switch statement. Because b53_arl_op_wait() already prints out a message, do not add another one.
--- drivers/net/dsa/b53/b53_common.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/dsa/b53/b53_common.c +2 -0
@@ -1554,6 +1554,8 @@ static int b53_arl_op(struct b53_device *dev, int op, int port,return ret;switch (ret) { +case -ETIMEDOUT : +return ret;case -ENOSPC :dev_dbg (dev->dev,"{%pM,%.4d} no space left in ARL\n" , addr, vid);
Signature · 1 line
2.18.1
Quoted 15 lines · On 8/21/2020 6:56 AM, [email protected] wrote:
From: Tom Rix <[email protected]>
clang static analysis reports this problem
b53_common.c:1583:13: warning: The left expression of the compound
assignment is an uninitialized value. The computed value will also be garbageent.port &= ~BIT(port); ~~~~~~~~ ^ent is set by a successful call to
b53_arl_read(). Unsuccessful calls are caught by an switch statement handling specific returns.b32_arl_read()callsb53_arl_op_wait()which fails with the unhandled-ETIMEDOUT.
Quoted 5 lines
So add
-ETIMEDOUTto the switch statement. Becauseb53_arl_op_wait()already prints out a message, do not add another one.Fixes 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations")
For future submissions: no need for a newline between your tags here, the Fixes tag is just a regular tag in the commit message.
Quoted 2 lines
Signed-off-by Tom Rix <[email protected]>
Signature · 1 line
Florian
David Miller
maintainerFrom: [email protected]
Date: Fri, 21 Aug 2020 06:56:00 -0700
Quoted 15 lines
From: Tom Rix <[email protected]>
clang static analysis reports this problem
b53_common.c:1583:13: warning: The left expression of the compound
assignment is an uninitialized value. The computed value will also be garbageent.port &= ~BIT(port); ~~~~~~~~ ^ent is set by a successful call to
b53_arl_read(). Unsuccessful calls are caught by an switch statement handling specific returns.b32_arl_read()callsb53_arl_op_wait()which fails with the unhandled-ETIMEDOUT.
Quoted 7 lines
So add
-ETIMEDOUTto the switch statement. Becauseb53_arl_op_wait()already prints out a message, do not add another one.Fixes 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations")Signed-off-by Tom Rix <[email protected]>
Applied and queued up for -stable, thanks.