coccinelle: api: add kobj_to_dev.cocci script
PATCH 1/1 coccinelle: api: add kobj_to_dev.cocci script
Use kobj_to_dev() instead of container_of().
---
Examples of such patches:893c3d82b425 watchdog: Use kobj_to_dev() API23fd63a44460 hwmon: (nct6683) Replace container_of() with kobj_to_dev() 224941c9424f power: supply: use kobj_to_deva9b9b2af40c7 backlight: lm3533_bl: Use kobj_to_dev() instead 0acb47a3a093 qlcnic: Use kobj_to_dev() instead97cd738c44c8 gpiolib: sysfs: use kobj_to_devd06f9e6c8960 hwmon: (nct7802) Replace container_of() API 036855a4c3b3 hwmon : (nct6775) Use kobj_to_dev() APIbaf1d9c18293 driver/base/soc: Use kobj_to_dev() APIae243ef0afbc rtc: sysfs: use kobj_to_dev6b060d8a09e9 i2c: use kobj_to_dev() API9e7bd945b9a9 scsi: core: use kobj_to_dev0d730b57b95f s390/cio: use kobj_to_dev() API0616ca73fd35 usb: use kobj_to_dev() API8c9b839c0b80 alpha: use kobj_to_dev()016c0bbae1d1 netxen: Use kobj_to_dev()6908b45eafc4 GenWQE: use kobj_to_dev()85f4f39c80e9 pch_phub: use kobj_to_dev()47679cde604d misc: c2port: use kobj_to_dev()85016ff33f35 misc: cxl: use kobj_to_dev()092462c2b522 misc: eeprom: use kobj_to_dev()a9c9d9aca4e7 zorro: Use kobj_to_dev()a253f1eee6c4 rapidio: use kobj_to_dev()e3837b00b6bb drm/radeon: use kobj_to_dev()cc29ec874b37 drm/amdgpu: use kobj_to_dev()d122cbf1a310 drm/sysfs: use kobj_to_dev()657fb5fbadb3 drm/i915: use kobj_to_dev()554a60379aaa PCI: Use kobj_to_dev() instead of open-coding it 2cf83833fc9c HID: use kobj_to_dev()aeb7ed14fe5d bridge: use kobj_to_dev instead of to_dev 8e3829c61b48 staging:iio:adis16220: Use kobj_to_dev instead of open-coding it b0d1f807f340 driver-core: Use kobj_to_dev instead of re-implementing it
scripts/coccinelle/api/kobj_to_dev.cocci | 44 ++++++++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 scripts/coccinelle/api/kobj_to_dev.cocci
scripts/coccinelle/api/kobj_to_dev.cocci new file +44 -0
@@ -0,0 +1,44 @@ +// SPDX-License-Identifier: GPL-2.0-only +/// +/// Use kobj_to_dev() instead of container_of() +/// +// Confidence: High +// Copyright: (C) 2020 Denis Efremov ISPRAS +// Options: --no-includes --include-headers +// +// Keywords: kobj_to_dev, container_of +// + +virtual context +virtual report +virtual org +virtual patch + + +@r depends on !patch@ +expression ptr; +position p; +@@ + +* container_of(ptr, struct device, kobj)@p + + +@depends on patch@ +expression ptr; +@@ + +- container_of(ptr, struct device, kobj) ++ kobj_to_dev(ptr) + + +@script:python depends on report@ +p << r.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()") + +@script:python depends on org@ +p << r.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()")
Signature · 1 line
2.26.2
Julia Lawall
maintainerQuoted 1 line · Denis Efremov
Use
kobj_to_dev()instead ofcontainer_of().
Thanks for the patch and the example commits.
Could you add
symbol kobj;
to the first rule? That's enough to get rid of the question about whether kobj should be a metavariable in all cases.
thanks,
julia
Quoted 94 lines
Signed-off-by Denis Efremov <[email protected]>---
Examples of such patches:893c3d82b425watchdog: Usekobj_to_dev()API23fd63a44460hwmon: (nct6683) Replacecontainer_of()withkobj_to_dev()224941c9424fpower: supply: usekobj_to_deva9b9b2af40c7backlight:lm3533_bl: Usekobj_to_dev()instead0acb47a3a093qlcnic: Usekobj_to_dev()instead97cd738c44c8gpiolib: sysfs: usekobj_to_devd06f9e6c8960hwmon: (nct7802) Replacecontainer_of()API036855a4c3b3hwmon : (nct6775) Usekobj_to_dev()APIbaf1d9c18293driver/base/soc: Usekobj_to_dev()APIae243ef0afbcrtc: sysfs: usekobj_to_dev6b060d8a09e9i2c: usekobj_to_dev()API9e7bd945b9a9scsi: core: usekobj_to_dev0d730b57b95fs390/cio: usekobj_to_dev()API0616ca73fd35usb: usekobj_to_dev()API8c9b839c0b80alpha: usekobj_to_dev()016c0bbae1d1netxen: Usekobj_to_dev()6908b45eafc4GenWQE: usekobj_to_dev()85f4f39c80e9pch_phub: usekobj_to_dev()47679cde604dmisc: c2port: usekobj_to_dev()85016ff33f35misc: cxl: usekobj_to_dev()092462c2b522misc: eeprom: usekobj_to_dev()a9c9d9aca4e7zorro: Usekobj_to_dev()a253f1eee6c4rapidio: usekobj_to_dev()e3837b00b6bbdrm/radeon: usekobj_to_dev()cc29ec874b37drm/amdgpu: usekobj_to_dev()d122cbf1a310drm/sysfs: usekobj_to_dev()657fb5fbadb3drm/i915: usekobj_to_dev()554a60379aaaPCI: Usekobj_to_dev()instead of open-coding it2cf83833fc9cHID: usekobj_to_dev()aeb7ed14fe5dbridge: usekobj_to_devinstead ofto_dev8e3829c61b48staging:iio:adis16220: Usekobj_to_devinstead of open-coding itb0d1f807f340driver-core: Usekobj_to_devinstead of re-implementing itscripts/coccinelle/api/kobj_to_dev.cocci | 44 ++++++++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 scripts/coccinelle/api/kobj_to_dev.cocciscripts/coccinelle/api/kobj_to_dev.cocci new file +44
-1@@ -0,0 +1,44 @@ +// SPDX-License-Identifier: GPL-2.0-only +/// +/// Use kobj_to_dev() instead of container_of() +/// +// Confidence: High +// Copyright: (C) 2020 Denis Efremov ISPRAS +// Options: --no-includes --include-headers +// +// Keywords: kobj_to_dev, container_of +// + +virtual context +virtual report +virtual org +virtual patch + + +@r depends on !patch@ +expression ptr; +position p; +@@ + +* container_of(ptr, struct device, kobj)@p + + +@depends on patch@ +expression ptr; +@@ + +- container_of(ptr, struct device, kobj) ++ kobj_to_dev(ptr) + + +@script:python depends on report@ +p << r.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()") + +@script:python depends on org@ +p << r.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()") --2.26.2
Quoted 5 lines
_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci
_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci
PATCH v2 1/1 coccinelle: api: add kobj_to_dev.cocci script
In reply to Denis EfremovUse kobj_to_dev() instead of container_of().
---
Changes in v2:
- "symbol kobj;" added to the rule r
scripts/coccinelle/api/kobj_to_dev.cocci | 45 ++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 scripts/coccinelle/api/kobj_to_dev.cocci
scripts/coccinelle/api/kobj_to_dev.cocci new file +45 -0
@@ -0,0 +1,45 @@ +// SPDX-License-Identifier: GPL-2.0-only +/// +/// Use kobj_to_dev() instead of container_of() +/// +// Confidence: High +// Copyright: (C) 2020 Denis Efremov ISPRAS +// Options: --no-includes --include-headers +// +// Keywords: kobj_to_dev, container_of +// + +virtual context +virtual report +virtual org +virtual patch + + +@r depends on !patch@ +expression ptr; +symbol kobj; +position p; +@@ + +* container_of(ptr, struct device, kobj)@p + + +@depends on patch@ +expression ptr; +@@ + +- container_of(ptr, struct device, kobj) ++ kobj_to_dev(ptr) + + +@script:python depends on report@ +p << r.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()") + +@script:python depends on org@ +p << r.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()")
Signature · 1 line
2.26.2
Quoted 3 lines · Denis Efremov
Use
kobj_to_dev()instead ofcontainer_of().Signed-off-by Denis Efremov <[email protected]>
Applied, thanks.
julia
Quoted 67 lines
---
Changes in v2:
- "symbol kobj;" added to the rule rscripts/coccinelle/api/kobj_to_dev.cocci | 45 ++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 scripts/coccinelle/api/kobj_to_dev.cocciscripts/coccinelle/api/kobj_to_dev.cocci new file +45
-1@@ -0,0 +1,45 @@ +// SPDX-License-Identifier: GPL-2.0-only +/// +/// Use kobj_to_dev() instead of container_of() +/// +// Confidence: High +// Copyright: (C) 2020 Denis Efremov ISPRAS +// Options: --no-includes --include-headers +// +// Keywords: kobj_to_dev, container_of +// + +virtual context +virtual report +virtual org +virtual patch + + +@r depends on !patch@ +expression ptr; +symbol kobj; +position p; +@@ + +* container_of(ptr, struct device, kobj)@p + + +@depends on patch@ +expression ptr; +@@ + +- container_of(ptr, struct device, kobj) ++ kobj_to_dev(ptr) + + +@script:python depends on report@ +p << r.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()") + +@script:python depends on org@ +p << r.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()") --2.26.2
_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci