net: add a generic udp protocol
Subsystems (2)
PATCH 1/1 net: add a generic udp protocol
This commit adds a generic udp protocol framework in the network loop. So protocol based on udp may be implemented without modifying the network loop (for example custom wait magic packet).
--- include/net.h | 2 +- include/net/udp.h | 31 +++++++++++++++++++++++++++++++ net/Kconfig | 6 ++++++ net/Makefile | 1 + net/net.c | 15 ++++++++++++++- net/udp.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 101 insertions(+), 2 deletions(-) create mode 100644 include/net/udp.h create mode 100644 net/udp.c
include/net.h +1 -1
@@ -551,7 +551,7 @@ extern int net_restart_wrap; /* Tried all network devices */enum proto_t {BOOTP ,RARP ,ARP ,TFTPGET ,DHCP ,PING ,DNS ,NFS ,CDP ,NETCONS ,SNTP , -TFTPSRV ,TFTPPUT ,LINKLOCAL ,FASTBOOT ,WOL +TFTPSRV ,TFTPPUT ,LINKLOCAL ,FASTBOOT ,WOL ,UDP };extern char net_boot_file_name[1024 ];/* Boot File name */
include/net/udp.h new file +31 -0
@@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright (C) 2020 Philippe Reynes <[email protected]> +*/ + +#ifndef __UDP +#define __UDP + +/** +* struct udp_ops - function to handle udp packet +* +* This structure provides the function to handle udp packet in +* the network loop. +* +* @prereq: callback called to check the requirement +* @start: callback called to start the protocol/feature +* @data: pointer to store private data (used by prereq and start) +*/ +struct udp_ops { +int (*prereq)(void *data); +int (*start)(void *data); +void *data; +}; + +int udp_prereq (void ); + +int udp_start (void ); + +int udp_loop (struct udp_ops *h); + +#endif
net/Kconfig +6 -0
@@ -8,6 +8,12 @@ menuconfig NET if NET +config PROT_UDP + bool "Enable generic udp framework" + help + Enable a generic udp framework that allow to define custom + handler for udp protocol. + config BOOTP_SEND_HOSTNAME bool "Send hostname to DNS server" help
net/Makefile +1 -0
@@ -27,6 +27,7 @@ obj-$(CONFIG_CMD_SNTP) += sntp.o obj-$(CONFIG_CMD_TFTPBOOT) += tftp.o obj-$(CONFIG_UDP_FUNCTION_FASTBOOT) += fastboot.o obj-$(CONFIG_CMD_WOL) += wol.o +obj-$(CONFIG_PROT_UDP) += udp.o # Disable this warning as it is triggered by: # sprintf(buf, index ? "foo%d" : "foo", index)
net/net.c +14 -1
@@ -102,6 +102,7 @@#if defined(CONFIG_CMD_PCAP )#include <net/pcap.h> #endif +#include <net/udp.h> #if defined(CONFIG_LED_STATUS )#include <miiphy.h> #include <status_led.h>
@@ -540,6 +541,11 @@ restart:wol_start ();break ;#endif +#if defined(CONFIG_PROT_UDP ) +case UDP : +udp_start (); +break ; +#endif default :break ; }
@@ -1364,6 +1370,13 @@ static int net_check_prereq(enum proto_t protocol) } goto common;#endif +#if defined(CONFIG_PROT_UDP ) +case UDP : +if (udp_prereq ()) +return 1 ; + goto common; +#endif +#if defined(CONFIG_CMD_NFS )case NFS :#endif
@@ -1375,7 +1388,7 @@ static int net_check_prereq(enum proto_t protocol)return 1 ; }#if defined(CONFIG_CMD_PING ) || defined(CONFIG_CMD_SNTP ) || \ - defined(CONFIG_CMD_DNS ) + defined(CONFIG_CMD_DNS ) || defined(CONFIG_PROT_UDP ) common:#endif /* Fall through */
net/udp.c new file +48 -0
48 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH 1/1 net: add a generic udp protocol
Quoted 6 lines · Philippe Reynes
This commit adds a generic udp protocol framework in the network loop. So protocol based on udp may be implemented without modifying the network loop (for example custom wait magic packet).
Signed-off-by Philippe Reynes <[email protected]>
Quoted 10 lines
--- include/net.h | 2 +- include/net/udp.h | 31 +++++++++++++++++++++++++++++++ net/Kconfig | 6 ++++++ net/Makefile | 1 + net/net.c | 15 ++++++++++++++- net/udp.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 101 insertions(+), 2 deletions(-) create mode 100644 include/net/udp.h create mode 100644 net/udp.c
At minimum we need to enable this on sandbox. Would it be possible to test this somehow on sandbox (where we have networking) with netcat or something from the host?
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200821/2cdd7ece/attachment.sig>
PATCH 1/1 net: add a generic udp protocol
Hi Tom
Quoted 19 lines · Philippe Reynes
Quoted 14 lines
This commit adds a generic udp protocol framework in the network loop. So protocol based on udp may be implemented without modifying the network loop (for example custom wait magic packet).
Signed-off-by Philippe Reynes <[email protected]>---
include/net.h| 2 +-include/net/udp.h| 31 +++++++++++++++++++++++++++++++ net/Kconfig | 6 ++++++
net/Makefile | 1 +net/net.c| 15 ++++++++++++++-net/udp.c| 48 ++++++++++++++++++++++++++++++++++++++++++++++++Quoted 3 lines
6 files changed, 101 insertions(+), 2 deletions(-)create mode 100644
include/net/udp.h
create mode 100644net/udp.c
Quoted 3 lines
At minimum we need to enable this on sandbox. Would it be possible to test this somehow on sandbox (where we have networking) with netcat or something from the host?
I've sent a v2 with this feature enable on sandbox.
I have tested it on sandbox by adding a simple/silly command "wait for magic packet" (using debug code). I'm looking for a way to add a test in test/dm/eth.c or test/py/tests/test_net.py.
Quoted 2 lines
--
Tom
Philippe