Skip to contentSkip to conversation

ARM: dts: stm32: Fix DH PDK2 display PWM channel

PATCH In review Marek Vasut 2 participants 7 messages Aug 22, 2020 – Sep 23, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Fix DH PDK2 display PWM channel

The display PWM channel is number 3 (PWM2 CH4), make it so.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]

---
 arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi +1 -1
index 7c4bd615b311..075e2a95713f 100644
@@ -26,7 +26,7 @@ clk_ext_audio_codec: clock-codec {
 
 	display_bl: display-bl {
 		compatible = "pwm-backlight";
-		pwms = <&pwm2 0 500000 PWM_POLARITY_INVERTED>;
+		pwms = <&pwm2 3 500000 PWM_POLARITY_INVERTED>;
 		brightness-levels = <0 16 22 30 40 55 75 102 138 188 255>;
 		default-brightness-level = <8>;
 		enable-gpios = <&gpioi 0 GPIO_ACTIVE_HIGH>;
Signature · 7 lines
2.28.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

Hi Marek

Quoted 3 lines · Marek Vasut

The display PWM channel is number 3 (PWM2 CH4), make it so.

No fixes tag ?

regards
alex

Quoted 16 lines

Cc: Alexandre Torgue <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
To: [email protected]

---
  arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi +0 -0
index 7c4bd615b311..075e2a95713f 100644

arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi clk_ext_audio_codec: clock-codec { · line 32

Quoted 8 lines
arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi +1 -1
@@ -26,7 +26,7 @@ clk_ext_audio_codec: clock-codec {
 
  	display_bl: display-bl {
  		compatible = "pwm-backlight";
-		pwms = <&pwm2 0 500000 PWM_POLARITY_INVERTED>;
+		pwms = <&pwm2 3 500000 PWM_POLARITY_INVERTED>;
  		brightness-levels = <0 16 22 30 40 55 75 102 138 188 255>;
  		default-brightness-level = <8>;
  		enable-gpios = <&gpioi 0 GPIO_ACTIVE_HIGH>;

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

Quoted 6 lines · Marek Vasut
Quoted 3 lines

The display PWM channel is number 3 (PWM2 CH4), make it so.

No fixes tag ?

It should be

Fixes 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1

SoM and PDK2 board")

except backporting it across
604536dc5837 ("ARM: dts: stm32: Split SoC-independent parts of DHCOM SOM and PDK2")
would generate a conflict.

If you are fine with that Fixes above, then please add it.

Thanks!

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw
In reply to Marek Vasut

Hi Marek

Quoted 19 lines · Marek Vasut

The display PWM channel is number 3 (PWM2 CH4), make it so.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]

---
  arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi +0 -0
index 7c4bd615b311..075e2a95713f 100644

arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi clk_ext_audio_codec: clock-codec { · line 32

Quoted 8 lines
arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi +1 -1
@@ -26,7 +26,7 @@ clk_ext_audio_codec: clock-codec {
 
  	display_bl: display-bl {
  		compatible = "pwm-backlight";
-		pwms = <&pwm2 0 500000 PWM_POLARITY_INVERTED>;
+		pwms = <&pwm2 3 500000 PWM_POLARITY_INVERTED>;
  		brightness-levels = <0 16 22 30 40 55 75 102 138 188 255>;
  		default-brightness-level = <8>;
  		enable-gpios = <&gpioi 0 GPIO_ACTIVE_HIGH>;

Applied on stm32-next.

Thanks.
Alex

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw
Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

Quoted 23 lines · Marek Vasut
Quoted 22 lines

The display PWM channel is number 3 (PWM2 CH4), make it so.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
  arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi +0 -1
index 7c4bd615b311..075e2a95713f 100644
@@ -26,7 +26,7 @@ clk_ext_audio_codec: clock-codec {
         display_bl: display-bl {
           compatible = "pwm-backlight";
-        pwms = <&pwm2 0 500000 PWM_POLARITY_INVERTED>;
Quoted 8 lines

arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi clk_ext_audio_codec: clock-codec {

Quoted 5 lines
arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi +1 -0
+        pwms = <&pwm2 3 500000 PWM_POLARITY_INVERTED>;
           brightness-levels = <0 16 22 30 40 55 75 102 138 188 255>;
           default-brightness-level = <8>;
           enable-gpios = <&gpioi 0 GPIO_ACTIVE_HIGH>;
 

Applied on stm32-next.

Don't you want to pick the one with the Fixes: tag ? :)

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw
Quoted 37 lines · Marek Vasut
Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

Quoted 23 lines · Marek Vasut
Quoted 22 lines

The display PWM channel is number 3 (PWM2 CH4), make it so.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]

---
   arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi +0 -1
index 7c4bd615b311..075e2a95713f 100644
@@ -26,7 +26,7 @@ clk_ext_audio_codec: clock-codec {
         display_bl: display-bl {
           compatible = "pwm-backlight";
-        pwms = <&pwm2 0 500000 PWM_POLARITY_INVERTED>;
Quoted 8 lines

arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi clk_ext_audio_codec: clock-codec {

Quoted 5 lines
arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi +1 -0
+        pwms = <&pwm2 3 500000 PWM_POLARITY_INVERTED>;
           brightness-levels = <0 16 22 30 40 55 75 102 138 188 255>;
           default-brightness-level = <8>;
           enable-gpios = <&gpioi 0 GPIO_ACTIVE_HIGH>;
 

Applied on stm32-next.

Quoted 2 lines

Don't you want to pick the one with the Fixes: tag ? :)

Yes I did. I just responded on the bad one ;)

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#6 lore raw
Quoted 40 lines · Alexandre Torgue
Quoted 37 lines · Marek Vasut
Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

Quoted 31 lines · Marek Vasut
Quoted 19 lines

The display PWM channel is number 3 (PWM2 CH4), make it so.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
   arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi | 2 +-

   1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi +0 -0
index 7c4bd615b311..075e2a95713f 100644

arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi clk_ext_audio_codec: clock-codec { · line 32

Quoted 8 lines
arch/arm/boot/dts/stm32mp15xx-dhcom-pdk2.dtsi +1 -1
@@ -26,7 +26,7 @@ clk_ext_audio_codec: clock-codec {
          display_bl: display-bl {
            compatible = "pwm-backlight";
-        pwms = <&pwm2 0 500000 PWM_POLARITY_INVERTED>;
+        pwms = <&pwm2 3 500000 PWM_POLARITY_INVERTED>;
            brightness-levels = <0 16 22 30 40 55 75 102 138 188 255>;
            default-brightness-level = <8>;
            enable-gpios = <&gpioi 0 GPIO_ACTIVE_HIGH>;
 

Applied on stm32-next.

Quoted 4 lines
Quoted 2 lines

Don't you want to pick the one with the Fixes: tag ? :)

Yes I did. I just responded on the bad one ;)

Ah, right, OK :)

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel