Skip to contentSkip to conversation

ARM: dts: imx7d-zii-rmu2: fix rgmii phy-mode for ksz9031 phy

PATCH Applied Chris Healy 3 participants 3 messages Aug 23, 2020 – Aug 24, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: dts: imx7d-zii-rmu2: fix rgmii phy-mode for ksz9031 phy

From: Chris Healy <[email protected]>

Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") the networking is broken on the imx7d-zii-rmu2 board.

The end result is that network receive behaviour is marginal with lots of RX CRC errors experienced and NFS frequently failing.

Quoting the explanation from Andrew Lunn in commit 0672d22a19244 ("ARM: dts: imx: Fix the AR803X phy-mode"):

"The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue"

Fix it by switching to phy-mode = "rgmii-id".

Fixes bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
---
 arch/arm/boot/dts/imx7d-zii-rmu2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx7d-zii-rmu2.dts +1 -1
index e5e20b07f184..7cb6153fc650 100644
@@ -58,7 +58,7 @@ &fec1 {
 			  <&clks IMX7D_ENET1_TIME_ROOT_CLK>;
 	assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>;
 	assigned-clock-rates = <0>, <100000000>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-handle = <&fec1_phy>;
 	status = "okay";
 
Signature · 1 line
2.26.2
reviewer Reviewed-by on v2 1/1
#1 lore raw

Hi Chris,

Quoted 17 lines · Chris Healy

From: Chris Healy <[email protected]>

Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") the networking is broken on the imx7d-zii-rmu2 board.

The end result is that network receive behaviour is marginal with lots of RX CRC errors experienced and NFS frequently failing.

Quoting the explanation from Andrew Lunn in commit 0672d22a19244 ("ARM: dts: imx: Fix the AR803X phy-mode"):

"The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue"

Quoted 4 lines

Fix it by switching to phy-mode = "rgmii-id".

Fixes bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
Applied
#2 lore raw
In reply to Chris Healy
Quoted 16 lines · Chris Healy

From: Chris Healy <[email protected]>

Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") the networking is broken on the imx7d-zii-rmu2 board.

The end result is that network receive behaviour is marginal with lots of RX CRC errors experienced and NFS frequently failing.

Quoting the explanation from Andrew Lunn in commit 0672d22a19244 ("ARM: dts: imx: Fix the AR803X phy-mode"):

"The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue"

Quoted 4 lines

Fix it by switching to phy-mode = "rgmii-id".

Fixes bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")

Applied, thanks.