Skip to contentSkip to conversation

scripts/qemu-version.sh: Add missing space before ']'

PATCH Applied Thomas Huth 3 participants 3 messages Aug 23, 2020 – Aug 25, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts/qemu-version.sh: Add missing space before ']'

When configure has been run with --with-pkgversion=xyz, the shell complains about a missing ']' in this script.

Fixes 2c273f32d3 ("meson: generate qemu-version.h")
---
 scripts/qemu-version.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/qemu-version.sh +1 -1
index 4847385e42..03128c56a2 100755
@@ -6,7 +6,7 @@ dir="$1"
 pkgversion="$2"
 version="$3"
 
-if [ -z "$pkgversion"]; then
+if [ -z "$pkgversion" ]; then
     cd "$dir"
     if [ -e .git ]; then
         pkgversion=$(git describe --match 'v*' --dirty | echo "")
Signature · 1 line
2.18.2
Reviewed-by on v1 1/1
#1 lore raw

Hi

Quoted 6 lines · Thomas Huth

When configure has been run with --with-pkgversion=xyz, the shell complains about a missing ']' in this script.

Fixes 2c273f32d3 ("meson: generate qemu-version.h")

oops, my bad

Quoted 20 lines
---
 scripts/qemu-version.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/qemu-version.sh +1 -2
index 4847385e42..03128c56a2 100755
@@ -6,7 +6,7 @@ dir="$1"
 pkgversion="$2"
 version="$3"
 
-if [ -z "$pkgversion"]; then
+if [ -z "$pkgversion" ]; then
     cd "$dir"
     if [ -e .git ]; then
         pkgversion=$(git describe --match 'v*' --dirty | echo "")
--

2.18.2

#2 lore raw
In reply to Thomas Huth

Queued, thanks.

Paolo

Il dom 23 ago 2020, 12:26 Thomas Huth <[email protected]> ha scritto:

Quoted 26 lines

When configure has been run with --with-pkgversion=xyz, the shell complains about a missing ']' in this script.

Fixes 2c273f32d3 ("meson: generate qemu-version.h")
---
 scripts/qemu-version.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/qemu-version.sh +1 -2
index 4847385e42..03128c56a2 100755
@@ -6,7 +6,7 @@ dir="$1"
 pkgversion="$2"
 version="$3"
 
-if [ -z "$pkgversion"]; then
+if [ -z "$pkgversion" ]; then
     cd "$dir"
     if [ -e .git ]; then
         pkgversion=$(git describe --match 'v*' --dirty | echo "")
--

2.18.2