net: ocelot: Add of_node_put() before return statement
Subsystems (4)
PATCH 1/1 net: ocelot: Add of_node_put() before return statement
Every iteration of for_each_available_child_of_node() decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak.
Fix a potential memory leak in felix.c by inserting of_node_put() before the return statement.
Issue found with Coccinelle.
--- drivers/net/dsa/ocelot/felix.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/dsa/ocelot/felix.c +1 -0
@@ -400,6 +400,7 @@ static int felix_parse_ports_node(struct felix *felix,if (err <0 ) {dev_err (dev,"Unsupported PHY mode %s on port %d\n" ,phy_modes (phy_mode), port); +of_node_put (child);return err; }
Signature · 1 line
2.17.1
From: Sumera Priyadarsini <[email protected]>
Date: Sun, 23 Aug 2020 19:22:45 +0530
Quoted 6 lines
Every iteration of
for_each_available_child_of_node()decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak.
Quoted 6 lines
Fix a potential memory leak in
felix.cby insertingof_node_put()before the return statement.Issue found with Coccinelle.
Signed-off-by Sumera Priyadarsini <[email protected]>
Applied.