arm: dts: fix ast2500-evb inclusion for correct target
PATCH 1/1 arm: dts: fix ast2500-evb inclusion for correct target
Include ast2500-evb.dtb for CONFIG_TARGET_EVB_AST2500 instead of for all aspeed targets.
--- arch/arm/dts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/Makefile +1 -1
@@ -938,7 +938,7 @@ dtb-$(CONFIG_ARCH_BCM6858) += \ dtb-$(CONFIG_TARGET_BCMNS3) += ns3-board.dtb -dtb-$(CONFIG_ARCH_ASPEED) += ast2500-evb.dtb +dtb-$(CONFIG_TARGET_EVB_AST2500) += ast2500-evb.dtb dtb-$(CONFIG_ARCH_STI) += stih410-b2260.dtb
Signature · 1 line
2.25.2
PATCH 1/1 arm: dts: fix ast2500-evb inclusion for correct target
Adding Ryan and Chiawei to the list.
Quoted 22 lines · Thirupathaiah Annapureddy
Include ast2500-evb.dtb for
CONFIG_TARGET_EVB_AST2500instead of for all aspeed targets.Signed-off-by Thirupathaiah Annapureddy <[email protected]--- arch/arm/dts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/dts/Makefile +1
-1@@ -938,7 +938,7 @@ dtb-$(CONFIG_ARCH_BCM6858) += \ dtb-$(CONFIG_TARGET_BCMNS3) += ns3-board.dtb -dtb-$(CONFIG_ARCH_ASPEED) += ast2500-evb.dtb +dtb-$(CONFIG_TARGET_EVB_AST2500) += ast2500-evb.dtb dtb-$(CONFIG_ARCH_STI) += stih410-b2260.dtb
PATCH 1/1 arm: dts: fix ast2500-evb inclusion for correct target
Hi
Quoted 9 lines
-----Original Message-----
From: Thirupathaiah Annapureddy [mailto:thiruan at linux.microsoft.com]
Sent: Thursday, August 20, 2020 8:16 AM
To: u-boot at lists.denx.de
Cc: Maxim Sloyko <[email protected]>; Marek Vasut <[email protected]>; ChiaWei Wang <[email protected]>; Ryan Chen <[email protected]>
Subject: Re: [PATCH] arm: dts: fix ast2500-evb inclusion for correct target
Quoted 5 lines
Adding Ryan and Chiawei to the list.
Quoted 2 lines · Thirupathaiah Annapureddy
Include ast2500-evb.dtb for
CONFIG_TARGET_EVB_AST2500instead of for all aspeed targets.
There should not have to many Kconfig for ASPEED platform.
I prefer use following to build all all ASPEED platform. Like following.
dtb-$(CONFIG_ARCH_ASPEED) += \
ast2400-evb.dtb \
ast2500-evb.dtb \
ast2600a0-evb.dtb \
ast2600a0-ncsi.dtb \
ast2600a1-evb.dtb \
ast2600a1-ncsi.dtb \
ast2600-fpga.dtb \
ast2600-rainier.dtb \
ast2600-slt.dtb \
ast2600-tacoma.dtbQuoted 20 lines
Quoted 20 lines
Signed-off-by Thirupathaiah Annapureddy <[email protected]--- arch/arm/dts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/dts/Makefile index renamed from arch/arm/dts/Makefile +0
-0
7e29b9096b..d019f26983100644arch/arm/dts/Makefile +1
-1@@ -938,7 +938,7 @@ dtb-$(CONFIG_ARCH_BCM6858) += \ dtb-$(CONFIG_TARGET_BCMNS3) += ns3-board.dtb -dtb-$(CONFIG_ARCH_ASPEED) += ast2500-evb.dtb +dtb-$(CONFIG_TARGET_EVB_AST2500) += ast2500-evb.dtb dtb-$(CONFIG_ARCH_STI) += stih410-b2260.dtb
PATCH 1/1 arm: dts: fix ast2500-evb inclusion for correct target
Hi Ryan,
Thanks for reviewing the patch. Please see my comment(s):
Quoted 10 lines · Ryan Chen
Hi
Quoted 9 lines
-----Original Message-----
From: Thirupathaiah Annapureddy [mailto:thiruan at linux.microsoft.com]
Sent: Thursday, August 20, 2020 8:16 AM
To: u-boot at lists.denx.de
Cc: Maxim Sloyko <[email protected]>; Marek Vasut <[email protected]>; ChiaWei Wang <[email protected]>; Ryan Chen <[email protected]>
Subject: Re: [PATCH] arm: dts: fix ast2500-evb inclusion for correct target
Quoted 7 lines
Quoted 5 lines
Adding Ryan and Chiawei to the list.
Quoted 2 lines · Thirupathaiah Annapureddy
Include ast2500-evb.dtb for
CONFIG_TARGET_EVB_AST2500instead of for all aspeed targets.There should not have to many
Kconfigfor ASPEED platform.
When you build U-Boot, you have to provide a platform specific defconfig as the target. ex: evb-ast2500_defconfig.
defconfig specifies the platform specific device tree file.
ex: CONFIG_DEFAULT_DEVICE_TREE="ast2500-evb"
I do not see any reason to make other device trees (ex: ast2600a0-evb.dtb) when we are building for evb-ast2500.
Quoted 25 lines
I prefer use following to build all all ASPEED platform. Like following.
dtb-$(CONFIG_ARCH_ASPEED) += \ ast2400-evb.dtb \ ast2500-evb.dtb \ ast2600a0-evb.dtb \ ast2600a0-ncsi.dtb \ ast2600a1-evb.dtb \ ast2600a1-ncsi.dtb \ ast2600-fpga.dtb \ ast2600-rainier.dtb \ ast2600-slt.dtb \ ast2600-tacoma.dtbQuoted 12 lines
Quoted 12 lines
Signed-off-by Thirupathaiah Annapureddy <[email protected]--- arch/arm/dts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/dts/Makefile index renamed from arch/arm/dts/Makefile +0
-0
7e29b9096b..d019f26983100644arch/arm/dts/Makefile +0
-0@@ -938,7 +938,7 @@ dtb-$(CONFIG_ARCH_BCM6858) += \
Quoted 9 lines
Quoted 8 lines
arch/arm/dts/Makefile dtb-$(CONFIG_ARCH_BCM6858) += \ · line 944
Quoted 8 lines
arch/arm/dts/Makefile +1
-1dtb-$(CONFIG_TARGET_BCMNS3) += ns3-board.dtb -dtb-$(CONFIG_ARCH_ASPEED) += ast2500-evb.dtb +dtb-$(CONFIG_TARGET_EVB_AST2500) += ast2500-evb.dtb dtb-$(CONFIG_ARCH_STI) += stih410-b2260.dtb
Best Regards,
Thiru
PATCH 1/1 arm: dts: fix ast2500-evb inclusion for correct target
Quoted 21 lines · Thirupathaiah Annapureddy
Hi Ryan,
Thanks for reviewing the patch. Please see my comment(s):
Quoted 16 lines · Ryan Chen
Hi
Quoted 14 lines
-----Original Message-----
From: Thirupathaiah Annapureddy [mailto:thiruan at linux.microsoft.com]
Sent: Thursday, August 20, 2020 8:16 AM
To: u-boot at lists.denx.de
Cc: Maxim Sloyko <[email protected]>; Marek Vasut <[email protected]>; ChiaWei Wang <[email protected]>; Ryan Chen <[email protected]>
Subject: Re: [PATCH] arm: dts: fix ast2500-evb inclusion for correct targetAdding Ryan and Chiawei to the list.
Quoted 2 lines · Thirupathaiah Annapureddy
Include ast2500-evb.dtb for
CONFIG_TARGET_EVB_AST2500instead of for all aspeed targets.
Quoted 8 lines
Quoted 1 line
There should not have to many
Kconfigfor ASPEED platform.When you build U-Boot, you have to provide a platform specific defconfig as the target. ex: evb-ast2500_defconfig.
defconfig specifies the platform specific device tree file.
ex:CONFIG_DEFAULT_DEVICE_TREE="ast2500-evb"I do not see any reason to make other device trees (ex: ast2600a0-evb.dtb) when we are building for evb-ast2500.
It keeps the Makefile logic clearer and makes future moves towards more platforms in a single binary easier if we just build all of the dtb files.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200820/13214563/attachment.sig>
PATCH 1/1 arm: dts: fix ast2500-evb inclusion for correct target
Quoted 28 lines · Tom Rini
Quoted 27 lines · Thirupathaiah Annapureddy
Hi Ryan,
Thanks for reviewing the patch. Please see my comment(s):
Quoted 10 lines · Ryan Chen
Hi
Quoted 9 lines
-----Original Message-----
From: Thirupathaiah Annapureddy [mailto:thiruan at linux.microsoft.com]
Sent: Thursday, August 20, 2020 8:16 AM
To: u-boot at lists.denx.de
Cc: Maxim Sloyko <[email protected]>; Marek Vasut <[email protected]>; ChiaWei Wang <[email protected]>; Ryan Chen <[email protected]>
Subject: Re: [PATCH] arm: dts: fix ast2500-evb inclusion for correct targetQuoted 7 lines
Quoted 5 lines
Adding Ryan and Chiawei to the list.
Quoted 2 lines · Thirupathaiah Annapureddy
Include ast2500-evb.dtb for
CONFIG_TARGET_EVB_AST2500instead of for all aspeed targets.There should not have to many
Kconfigfor ASPEED platform.When you build U-Boot, you have to provide a platform specific defconfig as the target. ex: evb-ast2500_defconfig.
defconfig specifies the platform specific device tree file.
ex:CONFIG_DEFAULT_DEVICE_TREE="ast2500-evb"
Quoted 7 lines
Quoted 2 lines
I do not see any reason to make other device trees (ex: ast2600a0-evb.dtb) when we are building for evb-ast2500.
It keeps the
Makefilelogic clearer and makes future moves towards more platforms in a single binary easier if we just build all of the dtb files.
ast2400 is based on ARM926EJ-S processor (ARMv5-architecture). ast2500 is based on ARM1176JZS processor (ARMv6-architecture). ast2600 is based on Cortex A7 processor (ARMv7-A architecture).
Each of the above SOC is using a different ARM CPU(s) with different ARM architecture revision. Is it possible for single binary to support multiple platforms based on above SOCs?
PATCH 1/1 arm: dts: fix ast2500-evb inclusion for correct target
Quoted 38 lines · Thirupathaiah Annapureddy
Quoted 28 lines · Tom Rini
Quoted 27 lines · Thirupathaiah Annapureddy
Hi Ryan,
Thanks for reviewing the patch. Please see my comment(s):
Quoted 10 lines · Ryan Chen
Hi
Quoted 9 lines
-----Original Message-----
From: Thirupathaiah Annapureddy [mailto:thiruan at linux.microsoft.com]
Sent: Thursday, August 20, 2020 8:16 AM
To: u-boot at lists.denx.de
Cc: Maxim Sloyko <[email protected]>; Marek Vasut <[email protected]>; ChiaWei Wang <[email protected]>; Ryan Chen <[email protected]>
Subject: Re: [PATCH] arm: dts: fix ast2500-evb inclusion for correct targetQuoted 7 lines
Quoted 5 lines
Adding Ryan and Chiawei to the list.
Quoted 2 lines · Thirupathaiah Annapureddy
Include ast2500-evb.dtb for
CONFIG_TARGET_EVB_AST2500instead of for all aspeed targets.There should not have to many
Kconfigfor ASPEED platform.When you build U-Boot, you have to provide a platform specific defconfig as the target. ex: evb-ast2500_defconfig.
defconfig specifies the platform specific device tree file.
ex:CONFIG_DEFAULT_DEVICE_TREE="ast2500-evb"Quoted 7 lines
Quoted 2 lines
I do not see any reason to make other device trees (ex: ast2600a0-evb.dtb) when we are building for evb-ast2500.
It keeps the
Makefilelogic clearer and makes future moves towards more platforms in a single binary easier if we just build all of the dtb files.
Quoted 7 lines
ast2400 is based on ARM926EJ-S processor (ARMv5-architecture). ast2500 is based on ARM1176JZS processor (ARMv6-architecture). ast2600 is based on Cortex A7 processor (ARMv7-A architecture).
Each of the above SOC is using a different ARM CPU(s) with different ARM architecture revision. Is it possible for single binary to support multiple platforms based on above SOCs?
Thanks for the details. It depends on thee goals and needs. There's probably some hurdles to supporting v5/v6 and v7 in a single binary. But yes, if we aren't supporting all 3 of those families yet, we should include and build the families we can support. But that would still mean all ast2500 DTBs for example still.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200823/af8c69cf/attachment.sig>