Skip to contentSkip to conversation

scsi: qedf: Fix null ptr reference in qedf_stag_change_work

PATCH In review Ye Bin 2 participants 2 messages Aug 24, 2020

Subsystems (2)
SCSI QLogic QL41xxx FCoE driver
lore
Share & tools
lore

Ye Bin

author
#0 lore raw

PATCH 1/1 scsi: qedf: Fix null ptr reference in qedf_stag_change_work

Signed-off-by Ye Bin <[email protected]>
---
 drivers/scsi/qedf/qedf_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qedf/qedf_main.c +1 -1
index 39c4bdc89937..c855ff3ad232 100644
@@ -3874,7 +3874,7 @@ void qedf_stag_change_work(struct work_struct *work)
 	    container_of(work, struct qedf_ctx, stag_work.work);
 
 	if (!qedf) {
-		QEDF_ERR(&qedf->dbg_ctx, "qedf is NULL");
+		QEDF_ERR(NULL, "qedf is NULL");
 		return;
 	}
 	QEDF_ERR(&qedf->dbg_ctx, "Performing software context reset.\n");
Signature · 1 line
2.25.4
maintainer Acked-by on v1 1/1
#1 lore raw

Hi Bin,
Thanks for an patch.

Quoted 28 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Ye Bin
Sent: Monday, August 24, 2020 9:05 AM
To: [email protected]; [email protected]; [email protected]; [email protected]
Cc: Ye Bin <[email protected]>
Subject: [PATCH] scsi: qedf: Fix null ptr reference in qedf_stag_change_work

Signed-off-by Ye Bin <[email protected]>
---
 drivers/scsi/qedf/qedf_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qedf/qedf_main.c +1 -1
index 39c4bdc89937..c855ff3ad232 100644
@@ -3874,7 +3874,7 @@ void qedf_stag_change_work(struct work_struct
 *work)
 	    container_of(work, struct qedf_ctx, stag_work.work);
 
 	if (!qedf) {
-		QEDF_ERR(&qedf->dbg_ctx, "qedf is NULL");
+		QEDF_ERR(NULL, "qedf is NULL");
 		return;
 	}
Quoted 3 lines

QEDF_ERR(&qedf->dbg_ctx, "Performing software context reset.\n");
--
2.25.4

Acked-by Saurav Kashyap <[email protected]>