Skip to contentSkip to conversation

usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe

PATCH In review Ye Bin 2 participants 2 messages Aug 24, 2020

Subsystems (2)
lore
Share & tools
lore

Ye Bin

author
#0 lore raw

PATCH v2 1/1 usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe

udc_controller->irq is "unsigned int" always >= 0, but platform_get_irq may return little than zero. So "dc_controller->irq < 0" condition is never accessible.

---
 drivers/usb/gadget/udc/fsl_udc_core.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/usb/gadget/udc/fsl_udc_core.c +4 -3
index a6f7b2594c09..3e98740b8cfc 100644
@@ -2439,11 +2439,12 @@ static int fsl_udc_probe(struct platform_device *pdev)
 	/* DEN is bidirectional ep number, max_ep doubles the number */
 	udc_controller->max_ep = (dccparams & DCCPARAMS_DEN_MASK) * 2;
 
-	udc_controller->irq = platform_get_irq(pdev, 0);
-	if (udc_controller->irq <= 0) {
-		ret = udc_controller->irq ? : -ENODEV;
+	ret = platform_get_irq(pdev, 0);
+	if (ret <= 0) {
+		ret = ret ? : -ENODEV;
 		goto err_iounmap;
 	}
+	udc_controller->irq = ret;
 
 	ret = request_irq(udc_controller->irq, fsl_udc_irq, IRQF_SHARED,
 			driver_name, udc_controller);
Signature · 1 line
2.25.4
Acked-by on v2 1/1
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: Ye Bin <[email protected]>
Sent: Monday, August 24, 2020 3:43 AM
To: Leo Li <[email protected]>; [email protected]; linuxppc- [email protected]
Cc: Ye Bin <[email protected]>
Subject: [PATCH v2] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe

Quoted 5 lines

udc_controller->irq is "unsigned int" always >= 0, but platform_get_irq may return little than zero. So "dc_controller->irq < 0" condition is never accessible.

Quoted 29 lines
---
 drivers/usb/gadget/udc/fsl_udc_core.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/usb/gadget/udc/fsl_udc_core.c +4 -3
index a6f7b2594c09..3e98740b8cfc 100644
@@ -2439,11 +2439,12 @@ static int fsl_udc_probe(struct platform_device
 *pdev)
 	/* DEN is bidirectional ep number, max_ep doubles the number */
 	udc_controller->max_ep = (dccparams & DCCPARAMS_DEN_MASK)
 * 2;
 
-	udc_controller->irq = platform_get_irq(pdev, 0);
-	if (udc_controller->irq <= 0) {
-		ret = udc_controller->irq ? : -ENODEV;
+	ret = platform_get_irq(pdev, 0);
+	if (ret <= 0) {
+		ret = ret ? : -ENODEV;
 		goto err_iounmap;
 	}
+	udc_controller->irq = ret;
 
drivers/usb/gadget/udc/fsl_udc_core.c +0 -1
 	ret = request_irq(udc_controller->irq, fsl_udc_irq, IRQF_SHARED,
 			driver_name, udc_controller);
--

2.25.4