video: fbdev: replace spurious snprintf() with sprintf()
PATCH 1/1 video: fbdev: replace spurious snprintf() with sprintf()
par->vgapass is a u8, so if we are assuming that buf is at least PAGE_SIZE then the extra checking is pointless.
Signed-off-by Alex Dewar <[email protected]>
--- drivers/video/fbdev/sstfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/sstfb.c +1 -1
@@ -733,7 +733,7 @@ static ssize_t show_vgapass(struct device *device, struct device_attribute *attr {struct fb_info *info =dev_get_drvdata (device);struct sstfb_par *par = info->par; -return snprintf (buf,PAGE_SIZE ,"%d\n" , par->vgapass); +return sprintf (buf,"%d\n" , par->vgapass); }static struct device_attribute device_attrs[] = {
Signature · 1 line
2.28.0
Bartlomiej Zolnierkiewicz
AppliedQuoted 4 lines · Alex Dewar
par->vgapassis a u8, so if we are assuming that buf is at leastPAGE_SIZEthen the extra checking is pointless.Signed-off-by Alex Dewar <[email protected]>
Applied to drm-misc-next tree, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Quoted 18 lines
--- drivers/video/fbdev/sstfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/video/fbdev/sstfb.c +1
-1@@ -733,7 +733,7 @@ static ssize_t show_vgapass(struct device *device, struct device_attribute *attr {struct fb_info *info =dev_get_drvdata (device);struct sstfb_par *par = info->par; -return snprintf (buf,PAGE_SIZE ,"%d\n" , par->vgapass); +return sprintf (buf,"%d\n" , par->vgapass); }static struct device_attribute device_attrs[] = {