fs: omfs: use kmemdup() rather than kmalloc+memcpy
PATCH 1/1 fs: omfs: use kmemdup() rather than kmalloc+memcpy
Issue identified with Coccinelle.
Signed-off-by Alex Dewar <[email protected]>
--- fs/omfs/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
fs/omfs/inode.c +1 -2
@@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb) bh =sb_bread (sb, block++);if (!bh) goto nomem_free; - *ptr =kmalloc (sb->s_blocksize,GFP_KERNEL ); + *ptr =kmemdup (bh->b_data, sb->s_blocksize,GFP_KERNEL );if (!*ptr) {brelse (bh); goto nomem_free; } -memcpy (*ptr, bh->b_data, sb->s_blocksize);if (count < sb->s_blocksize)memset ((void *)*ptr + count,0xff , sb->s_blocksize - count);
Signature · 1 line
2.28.0
Quoted 1 line · Alex Dewar
Issue identified with Coccinelle.
Gentle ping?
Quoted 24 lines
Signed-off-by Alex Dewar <[email protected]>--- fs/omfs/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)fs/omfs/inode.c +1
-2@@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb) bh =sb_bread (sb, block++);if (!bh) goto nomem_free; - *ptr =kmalloc (sb->s_blocksize,GFP_KERNEL ); + *ptr =kmemdup (bh->b_data, sb->s_blocksize,GFP_KERNEL );if (!*ptr) {brelse (bh); goto nomem_free; } -memcpy (*ptr, bh->b_data, sb->s_blocksize);if (count < sb->s_blocksize)memset ((void *)*ptr + count,0xff , sb->s_blocksize - count);
Quoted 5 lines · Alex Dewar
Quoted 1 line · Alex Dewar
Issue identified with Coccinelle.
Gentle ping?
Quoted 2 lines
Signed-off-by Alex Dewar <[email protected]>
Acked-by Bob Copeland <[email protected]>
However, I don't have a git tree for OMFS so you'll need to send it through vfs tree or so.
Signature · 1 line
Bob Copeland %% https://bobcopeland.com/