irqchip/eznps: Fix build error for !ARC700 builds
PATCH 1/1 irqchip/eznps: Fix build error for !ARC700 builds
--- arch/arc/plat-eznps/include/plat/ctop.h | 1 - include/soc/nps/common.h | 6 ++++++ 2 files changed, 6 insertions(+), 1 deletion(-)
arch/arc/plat-eznps/include/plat/ctop.h +0 -1
@@ -33,7 +33,6 @@#define CTOP_AUX_DPC (CTOP_AUX_BASE + 0x02C)#define CTOP_AUX_LPC (CTOP_AUX_BASE + 0x030)#define CTOP_AUX_EFLAGS (CTOP_AUX_BASE + 0x080) -#define CTOP_AUX_IACK (CTOP_AUX_BASE + 0x088)#define CTOP_AUX_GPA1 (CTOP_AUX_BASE + 0x08C)#define CTOP_AUX_UDMC (CTOP_AUX_BASE + 0x300)
include/soc/nps/common.h +6 -0
@@ -45,6 +45,12 @@#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_INST 0x5B60#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_LIMM 0x00010422 +#ifndef AUX_IENABLE +#define AUX_IENABLE 0x40c +#endif + +#define CTOP_AUX_IACK (0xFFFFF800 + 0x088) +#ifndef __ASSEMBLY__/* In order to increase compilation test coverage */
Signature · 1 line
2.25.1
On 2020-08-24 16:01:49 [-0700], Vineet Gupta wrote:
A little of patch description wouldn't hurt. Especially since it is not a simple move but IENABLE comes out of nowhere.
Quoted 3 lines
That link gets lost if someone decides to recreate the pipermail archive and you have no hint what it was. Using
instead will instead give you the message-id in case lore dies or the lkml.kernel.org redirect service goes into retirement.
Quoted 25 lines
Signed-off-by Vineet Gupta <[email protected]>--- arch/arc/plat-eznps/include/plat/ctop.h | 1 - include/soc/nps/common.h | 6 ++++++ 2 files changed, 6 insertions(+), 1 deletion(-)arch/arc/plat-eznps/include/plat/ctop.h +0
-1@@ -33,7 +33,6 @@#define CTOP_AUX_DPC (CTOP_AUX_BASE + 0x02C)#define CTOP_AUX_LPC (CTOP_AUX_BASE + 0x030)#define CTOP_AUX_EFLAGS (CTOP_AUX_BASE + 0x080) -#define CTOP_AUX_IACK (CTOP_AUX_BASE + 0x088)#define CTOP_AUX_GPA1 (CTOP_AUX_BASE + 0x08C)#define CTOP_AUX_UDMC (CTOP_AUX_BASE + 0x300)include/soc/nps/common.h +0
-0@@ -45,6 +45,12 @@#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_INST 0x5B60#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_LIMM 0x00010422
include/soc/nps/common.h line 56
Quoted 10 lines
include/soc/nps/common.h +6
-0+#ifndef AUX_IENABLE +#define AUX_IENABLE 0x40c +#endif + +#define CTOP_AUX_IACK (0xFFFFF800 + 0x088) +#ifndef __ASSEMBLY__/* In order to increase compilation test coverage */
Sebastian
PATCH v2 1/1 irqchip/eznps: Fix build error for !ARC700 builds
eznps driver is supposed to be platform independent however it ends up including stuff from inside arch/arc headers leading to rand config build errors.
Fix this specific reported error as quick hacks as the correct fixes are too much work:
- copy AUX_IENABLE from arch/arc header
- move CTOP_AUX_IACK from platform header
--- arch/arc/plat-eznps/include/plat/ctop.h | 1 - include/soc/nps/common.h | 6 ++++++ 2 files changed, 6 insertions(+), 1 deletion(-)
arch/arc/plat-eznps/include/plat/ctop.h +0 -1
@@ -33,7 +33,6 @@#define CTOP_AUX_DPC (CTOP_AUX_BASE + 0x02C)#define CTOP_AUX_LPC (CTOP_AUX_BASE + 0x030)#define CTOP_AUX_EFLAGS (CTOP_AUX_BASE + 0x080) -#define CTOP_AUX_IACK (CTOP_AUX_BASE + 0x088)#define CTOP_AUX_GPA1 (CTOP_AUX_BASE + 0x08C)#define CTOP_AUX_UDMC (CTOP_AUX_BASE + 0x300)
include/soc/nps/common.h +6 -0
@@ -45,6 +45,12 @@#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_INST 0x5B60#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_LIMM 0x00010422 +#ifndef AUX_IENABLE +#define AUX_IENABLE 0x40c +#endif + +#define CTOP_AUX_IACK (0xFFFFF800 + 0x088) +#ifndef __ASSEMBLY__/* In order to increase compilation test coverage */
Signature · 1 line
2.25.1
Quoted 9 lines · Vineet Gupta
eznps driver is supposed to be platform independent however it ends up including stuff from inside
arch/archeaders leading to rand config build errors.Fix this specific reported error as quick hacks as the correct fixes are too much work:
- copyAUX_IENABLEfromarch/archeader
- moveCTOP_AUX_IACKfrom platform header
Quoted 4 lines
Reported-by kernel test robot <[email protected]>Reported-by Sebastian Andrzej Siewior <[email protected]>Signed-off-by Vineet Gupta <[email protected]>
Thank you.
in case it is not too late :)
Sebastian
_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc