drm/vkms: Use alpha value to blend values.
PATCH 1/1 drm/vkms: Use alpha value to blend values.
I wrote this patch for TODO list in vkms documentation.
Use alpha value to blend source value and destination value Instead of just overwrite with source value.
--- drivers/gpu/drm/vkms/vkms_composer.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
drivers/gpu/drm/vkms/vkms_composer.c +12 -2
@@ -77,6 +77,9 @@ static void blend(void *vaddr_dst, void *vaddr_src,for (i = y_src, i_dst = y_dst; i < y_limit; ++i) {for (j = x_src, j_dst = x_dst; j < x_limit; ++j) { +u8 *src, *dst; +u32 alpha, inv_alpha; + offset_dst = dest_composer->offset + (i_dst * dest_composer->pitch) + (j_dst++ * dest_composer->cpp);
@@ -84,8 +87,15 @@ static void blend(void *vaddr_dst, void *vaddr_src, + (i * src_composer->pitch) + (j * src_composer->cpp); -memcpy (vaddr_dst + offset_dst, - vaddr_src + offset_src,sizeof (u32)); + src = vaddr_src + offset_src; + dst = vaddr_dst + offset_dst; + alpha = src[3 ] +1 ; + inv_alpha =256 - src[3 ]; + dst[0 ] = (alpha * src[0 ] + inv_alpha * dst[0 ]) >>8 ; + dst[1 ] = (alpha * src[1 ] + inv_alpha * dst[1 ]) >>8 ; + dst[2 ] = (alpha * src[2 ] + inv_alpha * dst[2 ]) >>8 ; + dst[3 ] =0xff ; + } i_dst++; }
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Sidong,
Thanks a lot for your patch and effort to improve VKMS.
Quoted 30 lines · Sidong Yang
I wrote this patch for TODO list in vkms documentation.
Use alpha value to blend source value and destination value Instead of just overwrite with source value.
Cc Rodrigo Siqueira <[email protected]>Cc Haneen Mohammed <[email protected]>Signed-off-by Sidong Yang <[email protected]>--- drivers/gpu/drm/vkms/vkms_composer.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)drivers/gpu/drm/vkms/vkms_composer.c +3
-0@@ -77,6 +77,9 @@ static void blend(void *vaddr_dst, void *vaddr_src,for (i = y_src, i_dst = y_dst; i < y_limit; ++i) {for (j = x_src, j_dst = x_dst; j < x_limit; ++j) { +u8 *src, *dst; +u32 alpha, inv_alpha; + offset_dst = dest_composer->offset + (i_dst * dest_composer->pitch) + (j_dst++ * dest_composer->cpp);@@ -84,8 +87,15 @@ static void blend(void *vaddr_dst, void *vaddr_src, + (i * src_composer->pitch) + (j * src_composer->cpp);
drivers/gpu/drm/vkms/vkms_composer.c static void blend(void *vaddr_dst, void *vaddr_src, · line 96
Quoted 10 lines
drivers/gpu/drm/vkms/vkms_composer.c +7
-2-memcpy (vaddr_dst + offset_dst, - vaddr_src + offset_src,sizeof (u32)); + src = vaddr_src + offset_src; + dst = vaddr_dst + offset_dst; + alpha = src[3 ] +1 ; + inv_alpha =256 - src[3 ]; + dst[0 ] = (alpha * src[0 ] + inv_alpha * dst[0 ]) >>8 ; + dst[1 ] = (alpha * src[1 ] + inv_alpha * dst[1 ]) >>8 ; + dst[2 ] = (alpha * src[2 ] + inv_alpha * dst[2 ]) >>8 ;
Did you test your change with IGT? Maybe I missed something but looks like that you're applying the alpha value but the value that we get is already pre-multiplied.
Btw, It looks like that you and Melissa are working in the same feature, maybe you two could try to sync for avoiding overlapping.
Finally, do you have plans to send your fix for vkms_get_vblank_timestamp() function? That patch was really good and removes a lot of warning generated during the IGT test.
Best Regards
Quoted 8 lines
drivers/gpu/drm/vkms/vkms_composer.c +2
-0+ dst[3 ] =0xff ; + } i_dst++; }Signature · 1 line
2.17.1
Signature · 2 lines
Rodrigo Siqueira https://siqueira.tech
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 36 lines · Rodrigo Siqueira
Hi Sidong,
Thanks a lot for your patch and effort to improve VKMS.
Quoted 31 lines · Sidong Yang
I wrote this patch for TODO list in vkms documentation.
Use alpha value to blend source value and destination value Instead of just overwrite with source value.
Cc Rodrigo Siqueira <[email protected]>Cc Haneen Mohammed <[email protected]>Signed-off-by Sidong Yang <[email protected]>--- drivers/gpu/drm/vkms/vkms_composer.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)drivers/gpu/drm/vkms/vkms_composer.c +3
-0@@ -77,6 +77,9 @@ static void blend(void *vaddr_dst, void *vaddr_src,for (i = y_src, i_dst = y_dst; i < y_limit; ++i) {for (j = x_src, j_dst = x_dst; j < x_limit; ++j) { +u8 *src, *dst; +u32 alpha, inv_alpha; + offset_dst = dest_composer->offset + (i_dst * dest_composer->pitch) + (j_dst++ * dest_composer->cpp);@@ -84,8 +87,15 @@ static void blend(void *vaddr_dst, void *vaddr_src, + (i * src_composer->pitch) + (j * src_composer->cpp);
Quoted 10 lines
drivers/gpu/drm/vkms/vkms_composer.c static void blend(void *vaddr_dst, void *vaddr_src, · line 96
Quoted 9 lines
drivers/gpu/drm/vkms/vkms_composer.c +7
-2-memcpy (vaddr_dst + offset_dst, - vaddr_src + offset_src,sizeof (u32)); + src = vaddr_src + offset_src; + dst = vaddr_dst + offset_dst; + alpha = src[3 ] +1 ; + inv_alpha =256 - src[3 ]; + dst[0 ] = (alpha * src[0 ] + inv_alpha * dst[0 ]) >>8 ; + dst[1 ] = (alpha * src[1 ] + inv_alpha * dst[1 ]) >>8 ; + dst[2 ] = (alpha * src[2 ] + inv_alpha * dst[2 ]) >>8 ;
Hi, Rodrigo!
Quoted 6 lines
Did you test your change with IGT? Maybe I missed something but looks like that you're applying the alpha value but the value that we get is already pre-multiplied.
Btw, It looks like that you and Melissa are working in the same feature, maybe you two could try to sync for avoiding overlapping.
Thanks for review.
Yes, this patch should be dropped and I should watch Melissa's patch.
Quoted 4 lines
Finally, do you have plans to send your fix for
vkms_get_vblank_timestamp()function? That patch was really good and removes a lot of warning generated during the IGT test.
Okay, I'll work for improve vkms_get_vblank_timestamp(). Thank you so much.
Sincerely,
-Sidong
Quoted 15 lines
Best Regards
Quoted 8 lines
drivers/gpu/drm/vkms/vkms_composer.c +2
-0+ dst[3 ] =0xff ; + } i_dst++; }Signature · 1 line
2.17.1Signature · 2 lines
Rodrigo Siqueira https://siqueira.tech
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel