dt-bindings / arm64: Cleanup of i.MX 8 bindings
Subsystems (14)
v3 cover dt-bindings / arm64: Cleanup of i.MX 8 bindings
Hi,
This is a v3 of cleanup of i.XM 8 bindings and DTSes.
It is separate patchset from i.MX 8 pin configuration cleanup, which also touch the bindings [1]. No dependencies (although in my tree this comes first).
Merging
=======
There are no dependencies, so dt-bindings could go through Rob's tree, DTS through SoC. I think there is no point to push dt-bindings changes through subsystem maintainers (gpio, pwm, watchdog, mtd etc). Usually Rob has been picking them up.
Changes since v2:
=================
1. Add Rob's review,
2. Correct things pointed during review (see individual patches and their change logs).
[1] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoC
Best regards,
Krzysztof
Krzysztof Kozlowski (19):
dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles
dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property
dt-bindings: gpio: fsl-imx-gpio: Add parsing of hogs
dt-bindings: gpio: fsl-imx-gpio: Add power-domains
dt-bindings: perf: fsl-imx-ddr: Add i.MX 8M compatibles
dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles
dt-bindings: serial: fsl-imx-uart: Add i.MX 8M compatibles
dt-bindings: watchdog: fsl-imx-wdt: Add i.MX 8M compatibles
dt-bindings: mtd: gpmi-nand: Add i.MX 8M compatibles
dt-bindings: reset: fsl,imx7-src: Add i.MX 8M compatibles
dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible
dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching
dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles
dt-bindings: arm: fsl: Fix Toradex Colibri i.MX 8 binding
dt-bindings: arm: fsl: Add ZII Ultra boards binding
dt-bindings: interrupt-controller: fsl,irqsteer: Fix compatible
matching
dt-bindings: serial: fsl-lpuart: Fix compatible matching
arm64: dts: imx8mq-evk: Add hog suffix to wl-reg-on
arm64: dts: imx8mq-zii-ultra: Add hog suffixes to GPIO hogs
.../devicetree/bindings/arm/fsl.yaml | 14 ++++++ .../bindings/gpio/fsl-imx-gpio.yaml | 43 ++++++++++++++++--- .../interrupt-controller/fsl,irqsteer.yaml | 8 ++-- .../bindings/mmc/fsl-imx-esdhc.yaml | 37 ++++++++-------- .../devicetree/bindings/mtd/gpmi-nand.yaml | 18 +++++--- .../devicetree/bindings/nvmem/imx-ocotp.yaml | 38 +++++++++------- .../devicetree/bindings/perf/fsl-imx-ddr.yaml | 16 +++++-- .../devicetree/bindings/pwm/imx-pwm.yaml | 14 ++++-- .../bindings/reset/fsl,imx7-src.yaml | 19 +++++--- .../bindings/serial/fsl-imx-uart.yaml | 4 ++ .../bindings/serial/fsl-lpuart.yaml | 17 +++++--- .../bindings/thermal/imx8mm-thermal.yaml | 10 +++-- .../bindings/watchdog/fsl-imx-wdt.yaml | 11 ++++- arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 2 +- .../boot/dts/freescale/imx8mq-zii-ultra.dtsi | 8 ++-- 15 files changed, 182 insertions(+), 77 deletions(-)
Signature · 1 line
2.17.1
PATCH v3 1/19 dt-bindings: gpio: fsl-imx-gpio: Add i.MX 8 compatibles
DTSes with new i.MX 8 SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000:
compatible:0: 'fsl,imx8mm-gpio' is not one of ['fsl,imx1-gpio', 'fsl,imx21-gpio', 'fsl,imx31-gpio', 'fsl,imx35-gpio', 'fsl,imx7d-gpio'] From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000:
compatible: ['fsl,imx8mm-gpio', 'fsl,imx35-gpio'] is too long
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000:
compatible: Additional items are not allowed ('fsl,imx35-gpio' was unexpected)
--- .../bindings/gpio/fsl-imx-gpio.yaml | 21 +++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml +15 -6
@@ -11,12 +11,21 @@ maintainers: properties: compatible: - enum: - - fsl,imx1-gpio - - fsl,imx21-gpio - - fsl,imx31-gpio - - fsl,imx35-gpio - - fsl,imx7d-gpio + oneOf: + - enum: + - fsl,imx1-gpio + - fsl,imx21-gpio + - fsl,imx31-gpio + - fsl,imx35-gpio + - fsl,imx7d-gpio + - items: + - enum: + - fsl,imx8mm-gpio + - fsl,imx8mn-gpio + - fsl,imx8mp-gpio + - fsl,imx8mq-gpio + - fsl,imx8qxp-gpio + - const: fsl,imx35-gpio reg: maxItems: 1
Signature · 1 line
2.17.1
PATCH v3 2/19 dt-bindings: gpio: fsl-imx-gpio: Add gpio-ranges property
In reply to Krzysztof KozlowskiThe GPIO controller node can have gpio-ranges property. This fixes dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: gpio@30200000: 'gpio-ranges' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
---
Changes since v1:
1. Remove maxItems
--- Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml +2 -0
@@ -51,6 +51,8 @@ properties: gpio-controller: true + gpio-ranges: true + required: - compatible - reg
Signature · 1 line
2.17.1
PATCH v3 3/19 dt-bindings: gpio: fsl-imx-gpio: Add parsing of hogs
In reply to Krzysztof KozlowskiAllow parsing GPIO controller children nodes with GPIO hogs to fix warning:
arch/arm64/boot/dts/freescale/imx8mq-evk.dt.yaml: gpio@30240000: 'wl-reg-on' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
--- .../devicetree/bindings/gpio/fsl-imx-gpio.yaml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml +17 -0
@@ -53,6 +53,23 @@ properties: gpio-ranges: true +patternProperties: + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": + type: object + properties: + gpio-hog: true + gpios: true + input: true + output-high: true + output-low: true + line-name: true + + required: + - gpio-hog + - gpios + + additionalProperties: false + required: - compatible - reg
Signature · 1 line
2.17.1
PATCH v3 4/19 dt-bindings: gpio: fsl-imx-gpio: Add power-domains
In reply to Krzysztof KozlowskiParse also optional power-domains property to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: gpio@5d080000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
--- Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml +3 -0
@@ -53,6 +53,9 @@ properties: gpio-ranges: true + power-domains: + maxItems: 1 + patternProperties: "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": type: object
Signature · 1 line
2.17.1
PATCH v3 5/19 dt-bindings: perf: fsl-imx-ddr: Add i.MX 8M compatibles
In reply to Krzysztof KozlowskiDTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: ddr-pmu@3d800000:
compatible:0: 'fsl,imx8mm-ddr-pmu' is not one of ['fsl,imx8-ddr-pmu', 'fsl,imx8m-ddr-pmu', 'fsl,imx8mp-ddr-pmu'] From schema: Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: ddr-pmu@3d800000:
compatible: ['fsl,imx8mm-ddr-pmu', 'fsl,imx8m-ddr-pmu'] is too long
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: ddr-pmu@3d800000:
compatible: Additional items are not allowed ('fsl,imx8m-ddr-pmu' was unexpected)
---
Changes since v1:
1. Handle also fsl,imx8mp-ddr-pmu
--- .../devicetree/bindings/perf/fsl-imx-ddr.yaml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml +12 -4
@@ -11,10 +11,18 @@ maintainers: properties: compatible: - enum: - - fsl,imx8-ddr-pmu - - fsl,imx8m-ddr-pmu - - fsl,imx8mp-ddr-pmu + oneOf: + - enum: + - fsl,imx8-ddr-pmu + - fsl,imx8m-ddr-pmu + - fsl,imx8mp-ddr-pmu + - items: + - enum: + - fsl,imx8mm-ddr-pmu + - fsl,imx8mn-ddr-pmu + - fsl,imx8mq-ddr-pmu + - fsl,imx8mp-ddr-pmu + - const: fsl,imx8m-ddr-pmu reg: maxItems: 1
Signature · 1 line
2.17.1
PATCH v3 6/19 dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles
In reply to Krzysztof KozlowskiDTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm'] From schema: Documentation/devicetree/bindings/pwm/imx-pwm.yaml
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected)
--- Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/pwm/imx-pwm.yaml +11 -3
@@ -19,9 +19,17 @@ properties: - 3 compatible: - enum: - - fsl,imx1-pwm - - fsl,imx27-pwm + oneOf: + - enum: + - fsl,imx1-pwm + - fsl,imx27-pwm + - items: + - enum: + - fsl,imx8mm-pwm + - fsl,imx8mn-pwm + - fsl,imx8mp-pwm + - fsl,imx8mq-pwm + - const: fsl,imx27-pwm reg: maxItems: 1
Signature · 1 line
2.17.1
Thierry Reding
AppliedRe: [PATCH v3 06/19] dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles
Quoted 10 lines · Krzysztof Kozlowski
DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm'] From schema:Documentation/devicetree/bindings/pwm/imx-pwm.yaml
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected)Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
Applied, thanks.
Thierry
Re: [PATCH v3 06/19] dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles
Quoted 15 lines · Thierry Reding
Quoted 13 lines · Krzysztof Kozlowski
DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm'] From schema:Documentation/devicetree/bindings/pwm/imx-pwm.yaml
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected)
Quoted 7 lines
Quoted 5 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)Applied, thanks.
Thanks Thierry, but this was already picked up by Rob into DT tree.
Best regards,
Krzysztof
Re: [PATCH v3 06/19] dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles
Quoted 22 lines · Krzysztof Kozlowski
Quoted 21 lines · Thierry Reding
Quoted 18 lines · Krzysztof Kozlowski
DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm'] From schema:Documentation/devicetree/bindings/pwm/imx-pwm.yaml
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected)Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
Quoted 3 lines
Quoted 1 line
Applied, thanks.
Thanks Thierry, but this was already picked up by Rob into DT tree.
I hadn't seen any email and since Rob had given a reviewed-by I assumed this was supposed to be picked up into subsystem trees. I'll drop it again.
Thierry
PATCH v3 7/19 dt-bindings: serial: fsl-imx-uart: Add i.MX 8M compatibles
In reply to Krzysztof KozlowskiDTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm'] From schema: Documentation/devicetree/bindings/pwm/imx-pwm.yaml
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected)
---
Changes since v1:
1. Fix subject prefix
--- Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml | 4 ++++ 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml +4 -0
@@ -36,6 +36,10 @@ properties: - fsl,imx6sx-uart - fsl,imx6ul-uart - fsl,imx7d-uart + - fsl,imx8mm-uart + - fsl,imx8mn-uart + - fsl,imx8mp-uart + - fsl,imx8mq-uart - const: fsl,imx6q-uart reg:
Signature · 1 line
2.17.1
PATCH v3 8/19 dt-bindings: watchdog: fsl-imx-wdt: Add i.MX 8M compatibles
In reply to Krzysztof KozlowskiDTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dt.yaml: watchdog@30280000:
compatible:0: 'fsl,imx8mm-wdt' is not one of ['fsl,imx21-wdt'] From schema: Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dt.yaml: watchdog@30280000:
compatible: ['fsl,imx8mm-wdt', 'fsl,imx21-wdt'] is too long
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dt.yaml: watchdog@30280000:
compatible: Additional items are not allowed ('fsl,imx21-wdt' was unexpected)
--- .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml +9 -2
@@ -14,8 +14,15 @@ allOf: properties: compatible: - enum: - - fsl,imx21-wdt + oneOf: + - const: fsl,imx21-wdt + - items: + - enum: + - fsl,imx8mm-wdt + - fsl,imx8mn-wdt + - fsl,imx8mp-wdt + - fsl,imx8mq-wdt + - const: fsl,imx21-wdt reg: maxItems: 1
Signature · 1 line
2.17.1
Re: [PATCH v3 08/19] dt-bindings: watchdog: fsl-imx-wdt: Add i.MX 8M compatibles
Quoted 7 lines · Krzysztof Kozlowski
DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dt.yaml: watchdog@30280000:
compatible:0: 'fsl,imx8mm-wdt' is not one of ['fsl,imx21-wdt'] From schema:Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dt.yaml: watchdog@30280000:compatible: ['fsl,imx8mm-wdt', 'fsl,imx21-wdt'] is too long
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dt.yaml: watchdog@30280000:
compatible: Additional items are not allowed ('fsl,imx21-wdt' was unexpected)Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Rob Herring <[email protected]>
Quoted 27 lines
--- .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml +9
-2@@ -14,8 +14,15 @@ allOf: properties: compatible: - enum: - - fsl,imx21-wdt + oneOf: + - const: fsl,imx21-wdt + - items: + - enum: + - fsl,imx8mm-wdt + - fsl,imx8mn-wdt + - fsl,imx8mp-wdt + - fsl,imx8mq-wdt + - const: fsl,imx21-wdt reg: maxItems: 1
PATCH v3 9/19 dt-bindings: mtd: gpmi-nand: Add i.MX 8M compatibles
In reply to Krzysztof KozlowskiDTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: nand-controller@33002000:
compatible:0: 'fsl,imx8mm-gpmi-nand' is not one of ['fsl,imx23-gpmi-nand', 'fsl,imx28-gpmi-nand', 'fsl,imx6q-gpmi-nand', 'fsl,imx6sx-gpmi-nand', 'fsl,imx7d-gpmi-nand'] From schema: Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: nand-controller@33002000:
compatible: ['fsl,imx8mm-gpmi-nand', 'fsl,imx7d-gpmi-nand'] is too long
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: nand-controller@33002000:
compatible: Additional items are not allowed ('fsl,imx7d-gpmi-nand' was unexpected)
--- .../devicetree/bindings/mtd/gpmi-nand.yaml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +12 -6
@@ -20,12 +20,18 @@ description: | properties: compatible: - enum: - - fsl,imx23-gpmi-nand - - fsl,imx28-gpmi-nand - - fsl,imx6q-gpmi-nand - - fsl,imx6sx-gpmi-nand - - fsl,imx7d-gpmi-nand + oneOf: + - enum: + - fsl,imx23-gpmi-nand + - fsl,imx28-gpmi-nand + - fsl,imx6q-gpmi-nand + - fsl,imx6sx-gpmi-nand + - fsl,imx7d-gpmi-nand + - items: + - enum: + - fsl,imx8mm-gpmi-nand + - fsl,imx8mn-gpmi-nand + - const: fsl,imx7d-gpmi-nand reg: items:
Signature · 1 line
2.17.1
PATCH v3 10/19 dt-bindings: reset: fsl,imx7-src: Add i.MX 8M compatibles
In reply to Krzysztof KozlowskiDTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: reset-controller@30390000:
compatible:0: 'fsl,imx8mm-src' is not one of ['fsl,imx7d-src', 'fsl,imx8mq-src', 'fsl,imx8mp-src'] From schema: Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: reset-controller@30390000:
compatible:1: 'syscon' was expected
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: reset-controller@30390000:
compatible: ['fsl,imx8mm-src', 'fsl,imx8mq-src', 'syscon'] is too long
--- .../bindings/reset/fsl,imx7-src.yaml | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml +13 -6
@@ -22,12 +22,19 @@ description: | properties: compatible: - items: - - enum: - - fsl,imx7d-src - - fsl,imx8mq-src - - fsl,imx8mp-src - - const: syscon + oneOf: + - items: + - enum: + - fsl,imx7d-src + - fsl,imx8mq-src + - fsl,imx8mp-src + - const: syscon + - items: + - enum: + - fsl,imx8mm-src + - fsl,imx8mn-src + - const: fsl,imx8mq-src + - const: syscon reg: maxItems: 1
Signature · 1 line
2.17.1
PATCH v3 11/19 dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible
In reply to Krzysztof KozlowskiDTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
compatible:0: 'fsl,imx8mn-tmu' is not one of ['fsl,imx8mm-tmu', 'fsl,imx8mp-tmu'] From schema: Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
compatible: ['fsl,imx8mn-tmu', 'fsl,imx8mm-tmu'] is too long
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
compatible: Additional items are not allowed ('fsl,imx8mm-tmu' was unexpected)
--- .../devicetree/bindings/thermal/imx8mm-thermal.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml +7 -3
@@ -18,9 +18,13 @@ description: | properties: compatible: - enum: - - fsl,imx8mm-tmu - - fsl,imx8mp-tmu + oneOf: + - enum: + - fsl,imx8mm-tmu + - fsl,imx8mp-tmu + - items: + - const: fsl,imx8mn-tmu + - const: fsl,imx8mm-tmu reg: maxItems: 1
Signature · 1 line
2.17.1
PATCH v3 12/19 dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching
In reply to Krzysztof KozlowskiThe i.MX 8 DTSes use two compatibles so update the binding to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000:
compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too long From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000:
compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was unexpected)
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dt.yaml: mmc@30b40000:
compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too long
---
Changes since v2:
1. Remove moved compatibles.
Changes since v1:
1. Handle also fsl,imx8mm-usdhc and fsl,imx8qxp-usdhc
--- .../bindings/mmc/fsl-imx-esdhc.yaml | 37 ++++++++++--------- 1 file changed, 20 insertions(+), 17 deletions(-)
Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml +20 -17
@@ -21,23 +21,26 @@ description: | properties: compatible: - enum: - - fsl,imx25-esdhc - - fsl,imx35-esdhc - - fsl,imx51-esdhc - - fsl,imx53-esdhc - - fsl,imx6q-usdhc - - fsl,imx6sl-usdhc - - fsl,imx6sx-usdhc - - fsl,imx6ull-usdhc - - fsl,imx7d-usdhc - - fsl,imx7ulp-usdhc - - fsl,imx8mq-usdhc - - fsl,imx8mm-usdhc - - fsl,imx8mn-usdhc - - fsl,imx8mp-usdhc - - fsl,imx8qm-usdhc - - fsl,imx8qxp-usdhc + oneOf: + - enum: + - fsl,imx25-esdhc + - fsl,imx35-esdhc + - fsl,imx51-esdhc + - fsl,imx53-esdhc + - fsl,imx6q-usdhc + - fsl,imx6sl-usdhc + - fsl,imx6sx-usdhc + - fsl,imx6ull-usdhc + - fsl,imx7d-usdhc + - fsl,imx7ulp-usdhc + - items: + - enum: + - fsl,imx8mm-usdhc + - fsl,imx8mn-usdhc + - fsl,imx8mp-usdhc + - fsl,imx8mq-usdhc + - fsl,imx8qxp-usdhc + - const: fsl,imx7d-usdhc reg: maxItems: 1
Signature · 1 line
2.17.1
Re: [PATCH v3 12/19] dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching
Quoted 8 lines · Krzysztof Kozlowski
The i.MX 8 DTSes use two compatibles so update the binding to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000:
compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too long From schema:Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000:
compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was unexpected)
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dt.yaml: mmc@30b40000:
compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too longSigned-off-by Krzysztof Kozlowski <[email protected]>
Rob, Krzysztof - do you want me to pick this one?
Kind regards
Uffe
Quoted 63 lines
---
Changes since v2:
1. Remove moved compatibles.Changes since v1:
1. Handle also fsl,imx8mm-usdhc and fsl,imx8qxp-usdhc--- .../bindings/mmc/fsl-imx-esdhc.yaml | 37 ++++++++++--------- 1 file changed, 20 insertions(+), 17 deletions(-)Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml +20
-18@@ -21,23 +21,26 @@ description: | properties: compatible: - enum: - - fsl,imx25-esdhc - - fsl,imx35-esdhc - - fsl,imx51-esdhc - - fsl,imx53-esdhc - - fsl,imx6q-usdhc - - fsl,imx6sl-usdhc - - fsl,imx6sx-usdhc - - fsl,imx6ull-usdhc - - fsl,imx7d-usdhc - - fsl,imx7ulp-usdhc - - fsl,imx8mq-usdhc - - fsl,imx8mm-usdhc - - fsl,imx8mn-usdhc - - fsl,imx8mp-usdhc - - fsl,imx8qm-usdhc - - fsl,imx8qxp-usdhc + oneOf: + - enum: + - fsl,imx25-esdhc + - fsl,imx35-esdhc + - fsl,imx51-esdhc + - fsl,imx53-esdhc + - fsl,imx6q-usdhc + - fsl,imx6sl-usdhc + - fsl,imx6sx-usdhc + - fsl,imx6ull-usdhc + - fsl,imx7d-usdhc + - fsl,imx7ulp-usdhc + - items: + - enum: + - fsl,imx8mm-usdhc + - fsl,imx8mn-usdhc + - fsl,imx8mp-usdhc + - fsl,imx8mq-usdhc + - fsl,imx8qxp-usdhc + - const: fsl,imx7d-usdhc reg: maxItems: 1 --2.17.1
Re: [PATCH v3 12/19] dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching
Quoted 12 lines · Ulf Hansson
Quoted 11 lines · Krzysztof Kozlowski
The i.MX 8 DTSes use two compatibles so update the binding to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000:
compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too long From schema:Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000:
compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was unexpected)
Quoted 6 lines
Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dt.yaml: mmc@30b40000:
compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too longSigned-off-by Krzysztof Kozlowski <[email protected]>Rob, Krzysztof - do you want me to pick this one?
dt-bindings are independent so they can be applied individually.
I don't mind you taking it but still Rob's ack/review would be needed.
Other choice is that entire dt-bindings series go through Rob's tree.
Rob, what's your preference?
Best regards,
Krzysztof
Rob Herring
maintainerRe: [PATCH v3 12/19] dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching
In reply to Krzysztof KozlowskiQuoted 17 lines · Krzysztof Kozlowski
The i.MX 8 DTSes use two compatibles so update the binding to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000:
compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too long From schema:Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000:
compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was unexpected)
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dt.yaml: mmc@30b40000:
compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too longSigned-off-by Krzysztof Kozlowski <[email protected]>---
Quoted 9 lines
Changes since v2:
1. Remove moved compatibles.Changes since v1:
1. Handle also fsl,imx8mm-usdhc and fsl,imx8qxp-usdhc--- .../bindings/mmc/fsl-imx-esdhc.yaml | 37 ++++++++++--------- 1 file changed, 20 insertions(+), 17 deletions(-)
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: compatible: ['fsl,imx8qxp-usdhc'] is not valid under any of the given schemas (Possible causes of the failure):
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: compatible: ['fsl,imx8qxp-usdhc'] is too short
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: compatible:0: 'fsl,imx8qxp-usdhc' is not one of ['fsl,imx25-esdhc', 'fsl,imx35-esdhc', 'fsl,imx51-esdhc', 'fsl,imx53-esdhc', 'fsl,imx6q-usdhc', 'fsl,imx6sl-usdhc', 'fsl,imx6sx-usdhc', 'fsl,imx6ull-usdhc', 'fsl,imx7d-usdhc', 'fsl,imx7ulp-usdhc']
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
See https://patchwork.ozlabs.org/patch/1351360
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
Re: [PATCH v3 12/19] dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching
Quoted 30 lines · Rob Herring
Quoted 17 lines · Krzysztof Kozlowski
The i.MX 8 DTSes use two compatibles so update the binding to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000:
compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too long From schema:Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: mmc@30b40000:
compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was unexpected)
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dt.yaml: mmc@30b40000:
compatible: ['fsl,imx8mn-usdhc', 'fsl,imx7d-usdhc'] is too longSigned-off-by Krzysztof Kozlowski <[email protected]>---
Quoted 9 lines
Changes since v2:
1. Remove moved compatibles.Changes since v1:
1. Handle also fsl,imx8mm-usdhc and fsl,imx8qxp-usdhc--- .../bindings/mmc/fsl-imx-esdhc.yaml | 37 ++++++++++--------- 1 file changed, 20 insertions(+), 17 deletions(-)
Quoted 4 lines
My bot found errors running 'make
dt_binding_check' on your patch:/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: compatible: ['fsl,imx8qxp-usdhc'] is not valid under any of the given schemas (Possible causes of the failure):
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml: mmc@5b010000: compatible: ['fsl,imx8qxp-usdhc'] is too short
I will send a v4 just for this one patch. All others seem to be good.
Best regards,
Krzysztof
PATCH v3 13/19 dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles
In reply to Krzysztof KozlowskiDTSes with new i.MX 8M SoCs use two compatibles so update the binding to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: efuse@30350000: compatible:1: 'syscon' was expected
From schema: Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: efuse@30350000:
compatible: ['fsl,imx8mn-ocotp', 'fsl,imx8mm-ocotp', 'syscon'] is too long
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: efuse@30350000:
compatible: Additional items are not allowed ('syscon' was unexpected)
---
Changes since v2:
1. Remove moved compatibles.
--- .../devicetree/bindings/nvmem/imx-ocotp.yaml | 38 +++++++++++-------- 1 file changed, 23 insertions(+), 15 deletions(-)
Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml +23 -15
@@ -19,21 +19,29 @@ allOf: properties: compatible: - items: - - enum: - - fsl,imx6q-ocotp - - fsl,imx6sl-ocotp - - fsl,imx6sx-ocotp - - fsl,imx6ul-ocotp - - fsl,imx6ull-ocotp - - fsl,imx7d-ocotp - - fsl,imx6sll-ocotp - - fsl,imx7ulp-ocotp - - fsl,imx8mq-ocotp - - fsl,imx8mm-ocotp - - fsl,imx8mn-ocotp - - fsl,imx8mp-ocotp - - const: syscon + oneOf: + - items: + - enum: + - fsl,imx6q-ocotp + - fsl,imx6sl-ocotp + - fsl,imx6sx-ocotp + - fsl,imx6ul-ocotp + - fsl,imx6ull-ocotp + - fsl,imx7d-ocotp + - fsl,imx6sll-ocotp + - fsl,imx7ulp-ocotp + - fsl,imx8mq-ocotp + - fsl,imx8mm-ocotp + - const: syscon + - items: + - enum: + - fsl,imx8mn-ocotp + # i.MX8MP not really compatible with fsl,imx8mm-ocotp, however + # the code for getting SoC revision depends on fsl,imx8mm-ocotp + # compatible. + - fsl,imx8mp-ocotp + - const: fsl,imx8mm-ocotp + - const: syscon reg: maxItems: 1
Signature · 1 line
2.17.1
Re: [PATCH v3 13/19] dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles
Quoted 14 lines · Krzysztof Kozlowski
DTSes with new i.MX 8M SoCs use two compatibles so update the binding to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: efuse@30350000: compatible:1: 'syscon' was expected
From schema:Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: efuse@30350000:
compatible: ['fsl,imx8mn-ocotp', 'fsl,imx8mm-ocotp', 'syscon'] is too long
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: efuse@30350000:
compatible: Additional items are not allowed ('syscon' was unexpected)Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 8 lines
---
Changes since v2:
1. Remove moved compatibles.--- .../devicetree/bindings/nvmem/imx-ocotp.yaml | 38 +++++++++++-------- 1 file changed, 23 insertions(+), 15 deletions(-)
PATCH v3 14/19 dt-bindings: arm: fsl: Fix Toradex Colibri i.MX 8 binding
In reply to Krzysztof KozlowskiThe Toradex Colibri i.MX 8 Evaluation board has two Toradex compatibles so it needs separate entry. This fixes dtbs_check warning:
arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dt.yaml: /:
compatible: ['toradex,colibri-imx8x-eval-v3', 'toradex,colibri-imx8x', 'fsl,imx8qxp'] is not valid under any of the given schemas (Possible causes of the failure):
arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dt.yaml: /: compatible: ['toradex,colibri-imx8x-eval-v3', 'toradex,colibri-imx8x', 'fsl,imx8qxp'] is too long
--- Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++ 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +6 -0
@@ -379,7 +379,13 @@ properties: - einfochips,imx8qxp-ai_ml # i.MX8QXP AI_ML Board - fsl,imx8qxp-mek # i.MX8QXP MEK Board - toradex,colibri-imx8x # Colibri iMX8X Module + - const: fsl,imx8qxp + + - description: Toradex Colibri i.MX8 Evaluation Board + items: + - enum: - toradex,colibri-imx8x-eval-v3 # Colibri iMX8X Module on Colibri Evaluation Board V3 + - const: toradex,colibri-imx8x - const: fsl,imx8qxp - description:
Signature · 1 line
2.17.1
Shawn Guo
AppliedRe: [PATCH v3 14/19] dt-bindings: arm: fsl: Fix Toradex Colibri i.MX 8 binding
Quoted 9 lines · Krzysztof Kozlowski
The Toradex Colibri i.MX 8 Evaluation board has two Toradex compatibles so it needs separate entry. This fixes
dtbs_checkwarning:
arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dt.yaml: /:
compatible: ['toradex,colibri-imx8x-eval-v3', 'toradex,colibri-imx8x', 'fsl,imx8qxp'] is not valid under any of the given schemas (Possible causes of the failure):
arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dt.yaml: /: compatible: ['toradex,colibri-imx8x-eval-v3', 'toradex,colibri-imx8x', 'fsl,imx8qxp'] is too longSigned-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Rob Herring <[email protected]>
Applied, thanks.
PATCH v3 15/19 dt-bindings: arm: fsl: Add ZII Ultra boards binding
In reply to Krzysztof KozlowskiDocument the binding for Zodiac Inflight Innovations Ultra Boards.
--- Documentation/devicetree/bindings/arm/fsl.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +8 -0
@@ -373,6 +373,14 @@ properties: - technexion,pico-pi-imx8m # TechNexion PICO-PI-8M evk - const: fsl,imx8mq + - description: Zodiac Inflight Innovations Ultra Boards + items: + - enum: + - zii,imx8mq-ultra-rmb3 + - zii,imx8mq-ultra-zest + - const: zii,imx8mq-ultra + - const: fsl,imx8mq + - description: i.MX8QXP based Boards items: - enum:
Signature · 1 line
2.17.1
Shawn Guo
AppliedRe: [PATCH v3 15/19] dt-bindings: arm: fsl: Add ZII Ultra boards binding
Quoted 4 lines · Krzysztof Kozlowski
Document the binding for Zodiac Inflight Innovations Ultra Boards.
Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Rob Herring <[email protected]>
Applied, thanks.
PATCH v3 16/19 dt-bindings: interrupt-controller: fsl,irqsteer: Fix compatible matching
In reply to Krzysztof KozlowskiThe i.MX 8M DTSes use two compatibles so update the binding to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mq-thor96.dt.yaml: interrupt-controller@32e2d000:
compatible: ['fsl,imx8m-irqsteer', 'fsl,imx-irqsteer'] is too long From schema: Domentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
arch/arm64/boot/dts/freescale/imx8mq-thor96.dt.yaml: interrupt-controller@32e2d000:
compatible: Additional items are not allowed ('fsl,imx-irqsteer' was unexpected)
--- .../bindings/interrupt-controller/fsl,irqsteer.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml +5 -3
@@ -11,9 +11,11 @@ maintainers: properties: compatible: - enum: - - fsl,imx8m-irqsteer - - fsl,imx-irqsteer + oneOf: + - const: fsl,imx-irqsteer + - items: + - const: fsl,imx8m-irqsteer + - const: fsl,imx-irqsteer reg: maxItems: 1
Signature · 1 line
2.17.1
PATCH v3 17/19 dt-bindings: serial: fsl-lpuart: Fix compatible matching
In reply to Krzysztof KozlowskiThe i.MX 8QXP DTSes use two compatibles so update the binding to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: serial@5a060000:
compatible: ['fsl,imx8qxp-lpuart', 'fsl,imx7ulp-lpuart'] is too long From schema: Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: serial@5a060000:
compatible: Additional items are not allowed ('fsl,imx7ulp-lpuart' was unexpected)
---
Changes since v2:
1. Remove moved compatibles.
Changes since v1:
1. New patch.
--- .../devicetree/bindings/serial/fsl-lpuart.yaml | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +10 -7
@@ -14,13 +14,16 @@ allOf: properties: compatible: - enum: - - fsl,vf610-lpuart - - fsl,ls1021a-lpuart - - fsl,ls1028a-lpuart - - fsl,imx7ulp-lpuart - - fsl,imx8qxp-lpuart - - fsl,imx8qm-lpuart + oneOf: + - enum: + - fsl,vf610-lpuart + - fsl,ls1021a-lpuart + - fsl,ls1028a-lpuart + - fsl,imx7ulp-lpuart + - fsl,imx8qm-lpuart + - items: + - const: fsl,imx8qxp-lpuart + - const: fsl,imx7ulp-lpuart reg: maxItems: 1
Signature · 1 line
2.17.1
Re: [PATCH v3 17/19] dt-bindings: serial: fsl-lpuart: Fix compatible matching
Quoted 14 lines · Krzysztof Kozlowski
The i.MX 8QXP DTSes use two compatibles so update the binding to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: serial@5a060000:
compatible: ['fsl,imx8qxp-lpuart', 'fsl,imx7ulp-lpuart'] is too long From schema:Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: serial@5a060000:
compatible: Additional items are not allowed ('fsl,imx7ulp-lpuart' was unexpected)Signed-off-by Krzysztof Kozlowski <[email protected]>---
Quoted 9 lines
Changes since v2:
1. Remove moved compatibles.Changes since v1:
1. New patch.--- .../devicetree/bindings/serial/fsl-lpuart.yaml | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)
PATCH v3 18/19 arm64: dts: imx8mq-evk: Add hog suffix to wl-reg-on
In reply to Krzysztof KozlowskiAccording to device tree specification, device node names should be somewhat generic and reflecting the function of the device so add the "hog" suffix to wl-reg-on GPIO hog.
--- arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mq-evk.dts +1 -1
@@ -157,7 +157,7 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wifi_reset>; - wl-reg-on { + wl-reg-on-hog { gpio-hog; gpios = <29 GPIO_ACTIVE_HIGH>; output-high;
Signature · 1 line
2.17.1
Shawn Guo
AppliedRe: [PATCH v3 18/19] arm64: dts: imx8mq-evk: Add hog suffix to wl-reg-on
Quoted 5 lines · Krzysztof Kozlowski
According to device tree specification, device node names should be somewhat generic and reflecting the function of the device so add the "hog" suffix to wl-reg-on GPIO hog.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Applied, thanks.
PATCH v3 19/19 arm64: dts: imx8mq-zii-ultra: Add hog suffixes to GPIO hogs
In reply to Krzysztof KozlowskiAccording to device tree specification, device node names should be somewhat generic and reflecting the function of the device so add the "hog" suffixes to all GPIO hog nodes.
--- arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi +4 -4
@@ -229,28 +229,28 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_gpio3_hog>; - usb-emulation { + usb-emulation-hog { gpio-hog; gpios = <10 GPIO_ACTIVE_HIGH>; output-low; line-name = "usb-emulation"; }; - usb-mode1 { + usb-mode1-hog { gpio-hog; gpios = <11 GPIO_ACTIVE_HIGH>; output-high; line-name = "usb-mode1"; }; - usb-pwr { + usb-pwr-hog { gpio-hog; gpios = <12 GPIO_ACTIVE_LOW>; output-high; line-name = "usb-pwr-ctrl-en-n"; }; - usb-mode2 { + usb-mode2-hog { gpio-hog; gpios = <13 GPIO_ACTIVE_HIGH>; output-high;
Signature · 1 line
2.17.1
Shawn Guo
AppliedRe: [PATCH v3 19/19] arm64: dts: imx8mq-zii-ultra: Add hog suffixes to GPIO hogs
Quoted 5 lines · Krzysztof Kozlowski
According to device tree specification, device node names should be somewhat generic and reflecting the function of the device so add the "hog" suffixes to all GPIO hog nodes.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Applied, thanks.
Quoted 1 line · Krzysztof Kozlowski
This is a v3 of cleanup of i.XM 8 bindings and DTSes.
If you are going to be working a lot on Freescale SoC code going forward I wouldn't mind if you could add yourself as maintainer for the Freescale pin controller and GPIO at least, I already have high trust in you in general so if the Freescale maintainers also have that I think you should just sign up as maintainer. This makes it easier to do pull requests and things like that.
Yours,
Linus Walleij
Quoted 10 lines · Linus Walleij
Quoted 1 line · Krzysztof Kozlowski
This is a v3 of cleanup of i.XM 8 bindings and DTSes.
If you are going to be working a lot on Freescale SoC code going forward I wouldn't mind if you could add yourself as maintainer for the Freescale pin controller and GPIO at least, I already have high trust in you in general so if the Freescale maintainers also have that I think you should just sign up as maintainer. This makes it easier to do pull requests and things like that.
Thanks for encouragement. Indeed I am planning to do more work around i.MX 8M platforms from NXP/Freescale. However there are already four maintainers for Freescale pin controller drivers so I doubt there is need for fifth entry :).
Different question is the GPIO driver which apparently lacks entry in Maintainers file.
Best regards,
Krzysztof
Quoted 12 lines · Krzysztof Kozlowski
Quoted 10 lines · Linus Walleij
Quoted 1 line · Krzysztof Kozlowski
This is a v3 of cleanup of i.XM 8 bindings and DTSes.
If you are going to be working a lot on Freescale SoC code going forward I wouldn't mind if you could add yourself as maintainer for the Freescale pin controller and GPIO at least, I already have high trust in you in general so if the Freescale maintainers also have that I think you should just sign up as maintainer. This makes it easier to do pull requests and things like that.
Quoted 4 lines
Thanks for encouragement. Indeed I am planning to do more work around i.MX 8M platforms from NXP/Freescale. However there are already four maintainers for Freescale pin controller drivers so I doubt there is need for fifth entry :).
I beg to differ. As subsystem maintainer it has happened to me more than once that the i.MX pin control patches went unreviewed for weeks. Everyone listed for this driver is a kitchen sink maintainer that get way too much traffic and things fall over the edge.
Quoted 2 lines
Different question is the GPIO driver which apparently lacks entry in Maintainers file.
That's probably just an oversight. Feel free to add it!
Yours,
Linus Walleij