spi: pxa2xx: Add SSC2 and SSPSP2 SSP registers
PATCH 1/1 spi: pxa2xx: Add SSC2 and SSPSP2 SSP registers
Update list of SSP registers with SSC2 and SSPSP2. These registers are utilized by LPT/WPT AudioDSP architecture.
While SSC2 shares the same offset (0x40) as SSACDD, description of this register for SSP device present on mentioned AudioDSP is different so define separate constant to avoid any ambiguity.
--- include/linux/pxa2xx_ssp.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/pxa2xx_ssp.h +2 -0
@@ -41,6 +41,8 @@#define SSTSS (0x38)/* SSP Timeslot Status */ #define SSACD (0x3C)/* SSP Audio Clock Divider */ #define SSACDD (0x40)/* SSP Audio Clock Dither Divider */ +#define SSC2 (0x40)/* SSP Command / Status 2 */ +#define SSPSP2 (0x44)/* SSP Programmable Serial Protocol 2 */ /* Common PXA2xx bits first */ #define SSCR0_DSS (0x0000000f)/* Data Size Select (mask) */
Signature · 1 line
2.17.1
Quoted 6 lines · Cezary Rojewski
Update list of SSP registers with SSC2 and SSPSP2. These registers are utilized by LPT/WPT AudioDSP architecture.
While SSC2 shares the same offset (
0x40) as SSACDD, description of this register for SSP device present on mentioned AudioDSP is different so define separate constant to avoid any ambiguity.
In general it's okay, couple of nit-picks, though. After addressing,
Quoted 11 lines
Cc Andy Shevchenko <[email protected]>Signed-off-by Cezary Rojewski <[email protected]>--- include/linux/pxa2xx_ssp.h | 2 ++ 1 file changed, 2 insertions(+)include/linux/pxa2xx_ssp.h +0
-0
include/linux/pxa2xx_ssp.h line 44
Quoted 4 lines
include/linux/pxa2xx_ssp.h +1
-0@@ -41,6 +41,8 @@#define SSTSS (0x38)/* SSP Timeslot Status */ #define SSACD (0x3C)/* SSP Audio Clock Divider */ #define SSACDD (0x40)/* SSP Audio Clock Dither Divider */ +#define SSC2 (0x40)/* SSP Command / Status 2 */
Is it the same as been called SSCR2 in Tangier? (Also called SSP Command Status register 2) I guess we may name it with R applied.
include/linux/pxa2xx_ssp.h line 45
Quoted 1 line
include/linux/pxa2xx_ssp.h +1
-0+#define SSPSP2 (0x44)/* SSP Programmable Serial Protocol 2 */
Also, please move them below with a comment like LPSS SSP block:
https://elixir.bootlin.com/linux/latest/source/include/linux/pxa2xx_ssp.h#L181
Quoted 6 lines
include/linux/pxa2xx_ssp.h +0
-0/* Common PXA2xx bits first */ #define SSCR0_DSS (0x0000000f)/* Data Size Select (mask) */ Signature · 1 line
2.17.1
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 11 lines · Andy Shevchenko
Quoted 6 lines · Cezary Rojewski
Update list of SSP registers with SSC2 and SSPSP2. These registers are utilized by LPT/WPT AudioDSP architecture.
While SSC2 shares the same offset (
0x40) as SSACDD, description of this register for SSP device present on mentioned AudioDSP is different so define separate constant to avoid any ambiguity.In general it's okay, couple of nit-picks, though. After addressing,
Reviewed-by Andy Shevchenko <[email protected]>
Thanks for quick review, Andy.
Quoted 6 lines
Quoted 6 lines
Cc Andy Shevchenko <[email protected]>Signed-off-by Cezary Rojewski <[email protected]>--- include/linux/pxa2xx_ssp.h | 2 ++ 1 file changed, 2 insertions(+)
Quoted 13 lines
include/linux/pxa2xx_ssp.h line 44
Quoted 9 lines
include/linux/pxa2xx_ssp.h +1
-0@@ -41,6 +41,8 @@#define SSTSS (0x38)/* SSP Timeslot Status */ #define SSACD (0x3C)/* SSP Audio Clock Divider */ #define SSACDD (0x40)/* SSP Audio Clock Dither Divider */ +#define SSC2 (0x40)/* SSP Command / Status 2 */ Is it the same as been called SSCR2 in Tangier? (Also called SSP Command Status register 2) I guess we may name it with R applied.
It seems there is discrepancy in registers naming. LPT/ WPT specs have all 'R'(s) removed. Don't mind appending it - aligns with existing SSCR0 & SSCR1.
Know nothing about Tangier, though : )
Quoted 5 lines
include/linux/pxa2xx_ssp.h line 45
Quoted 1 line
include/linux/pxa2xx_ssp.h +1
-0+#define SSPSP2 (0x44)/* SSP Programmable Serial Protocol 2 */ Also, please move them below with a comment like LPSS SSP block:
https://elixir.bootlin.com/linux/latest/source/include/linux/pxa2xx_ssp.h#L181
Added in v2 as requested.