exfat: fix pointer error checking
Subsystems (2)
PATCH 1/1 exfat: fix pointer error checking
Fix missing result check of exfat_build_inode().
And use PTR_ERR_OR_ZERO instead of PTR_ERR.
Signed-off-by Tetsuhiro Kohada <[email protected]>
--- fs/exfat/namei.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
fs/exfat/namei.c +6 -7
@@ -578,7 +578,8 @@ static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t mode, i_pos =exfat_make_i_pos (&info); inode =exfat_build_inode (sb, &info, i_pos); -if (IS_ERR (inode)) + err =PTR_ERR_OR_ZERO (inode); +if (err) goto unlock;inode_inc_iversion (inode);
@@ -745,10 +746,9 @@ static struct dentry *exfat_lookup(struct inode *dir, struct dentry *dentry, i_pos =exfat_make_i_pos (&info); inode =exfat_build_inode (sb, &info, i_pos); -if (IS_ERR (inode)) { - err =PTR_ERR (inode); + err =PTR_ERR_OR_ZERO (inode); +if (err) goto unlock; - } i_mode = inode->i_mode; alias =d_find_alias (inode);
@@ -890,10 +890,9 @@ static int exfat_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode) i_pos =exfat_make_i_pos (&info); inode =exfat_build_inode (sb, &info, i_pos); -if (IS_ERR (inode)) { - err =PTR_ERR (inode); + err =PTR_ERR_OR_ZERO (inode); +if (err) goto unlock; - }inode_inc_iversion (inode); inode->i_mtime = inode->i_atime = inode->i_ctime =
Signature · 1 line
2.25.1
Quoted 4 lines
Fix missing result check of
exfat_build_inode().
And usePTR_ERR_OR_ZEROinstead ofPTR_ERR.Signed-off-by Tetsuhiro Kohada <[email protected]>
Pushed it to exfat #dev.
Thanks for your patch!