Skip to contentSkip to conversation

drm/amd/pm: suppress static checker warning

PATCH In review Evan Quan 2 participants 2 messages Aug 26, 2020

Subsystems (3)
lore
Share & tools
lore

Evan Quan

author
#0 lore raw

PATCH 1/1 drm/amd/pm: suppress static checker warning

Suppress the warning below:
drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:274 phm_check_smc_update_required_for_display_configuration()
warn: signedness bug returning '(-22)'

Change-Id If50e39fe401c16d981d917ef7d8d5ea81d6538df
---
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c +4 -1
index 9454ab50f9a1..1f9b9facdf1f 100644
@@ -271,7 +271,10 @@ int phm_start_thermal_controller(struct pp_hwmgr *hwmgr)
 
 bool phm_check_smc_update_required_for_display_configuration(struct pp_hwmgr *hwmgr)
 {
-	PHM_FUNC_CHECK(hwmgr);
+	if (hwmgr == NULL ||
+	    hwmgr->hwmgr_func == NULL)
+		return false;
+
 	if (hwmgr->pp_one_vf)
 		return false;
 
Signature · 6 lines
2.28.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
maintainer Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only - Internal Distribution Only]

________________________________
From: Quan, Evan <[email protected]>
Sent: Tuesday, August 25, 2020 11:32 PM
To: [email protected] <[email protected]>
Cc: Deucher, Alexander <[email protected]>; [email protected] <[email protected]>; Quan, Evan <[email protected]>
Subject: [PATCH] drm/amd/pm: suppress static checker warning

Suppress the warning below:
drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:274 phm_check_smc_update_required_for_display_configuration()
warn: signedness bug returning '(-22)'

Change-Id If50e39fe401c16d981d917ef7d8d5ea81d6538df
---
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c +4 -1
index 9454ab50f9a1..1f9b9facdf1f 100644
@@ -271,7 +271,10 @@ int phm_start_thermal_controller(struct pp_hwmgr *hwmgr)
 
 bool phm_check_smc_update_required_for_display_configuration(struct pp_hwmgr *hwmgr)
 {
-       PHM_FUNC_CHECK(hwmgr);
+       if (hwmgr == NULL ||
+           hwmgr->hwmgr_func == NULL)
+               return false;
+
         if (hwmgr->pp_one_vf)
                 return false;
 

--
2.28.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx