selftests/bpf: Fix open call in trigger_fstat_events
Subsystems (5)
Jiri Olsa
reviewerPATCH 1/1 selftests/bpf: Fix open call in trigger_fstat_events
Alexei reported compile breakage on newer systems with following error:
In file included from /usr/include/fcntl.h:290:0,
4814 from ./test_progs.h:29,
4815 from
.../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:3:
4816In function ‘open’,
4817 inlined from ‘trigger_fstat_events’ at
.../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:50:10,
4818 inlined from ‘test_d_path’ at
.../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:119:6:
4819/usr/include/x86_64-linux-gnu/bits/fcntl2.h:50:4: error: call to ‘__open_missing_mode’ declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments
4820 __open_missing_mode ();
4821 ^~~~~~~~~~~~~~~~~~~~~~
We're missing permission bits as 3rd argument
for open call with O_CREAT flag specified.
--- tools/testing/selftests/bpf/prog_tests/d_path.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/d_path.c +1 -1
@@ -47,7 +47,7 @@ static int trigger_fstat_events(pid_t pid) devfd =open ("/dev/urandom" ,O_RDONLY );if (CHECK (devfd <0 ,"trigger" ,"open /dev/urandom failed\n" )) goto out_close; - localfd =open ("/tmp/d_path_loadgen.txt" ,O_CREAT |O_RDONLY ); + localfd =open ("/tmp/d_path_loadgen.txt" ,O_CREAT |O_RDONLY ,0644 );if (CHECK (localfd <0 ,"trigger" ,"open /tmp/d_path_loadgen.txt failed\n" )) goto out_close;/* bpf_d_path will return path with (deleted) */
Signature · 1 line
2.25.4
Alexei Starovoitov
AppliedQuoted 19 lines · Jiri Olsa
Alexei reported compile breakage on newer systems with following error:
In file included from
/usr/include/fcntl.h:290:0,
4814 from ./test_progs.h:29,
4815 from
.../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:3:
4816In function ‘open’,
4817 inlined from ‘trigger_fstat_events’ at
.../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:50:10,
4818 inlined from ‘test_d_path’ at
.../bpf-next/tools/testing/selftests/bpf/prog_tests/d_path.c:119:6:
4819/usr/include/x86_64-linux-gnu/bits/fcntl2.h:50:4: error: call to ‘__open_missing_mode’ declared with attribute error: open withO_CREATorO_TMPFILEin second argument needs 3 arguments
4820__open_missing_mode();
4821 ^~~~~~~~~~~~~~~~~~~~~~
Quoted 6 lines
We're missing permission bits as 3rd argument
for open call withO_CREATflag specified.Reported-by Alexei Starovoitov <[email protected]>Fixes e4d1af4b16f8 ("selftests/bpf: Add test for d_path helper")Signed-off-by Jiri Olsa <[email protected]>
Applied. Thanks