Skip to contentSkip to conversation

afs: Remove erroneous fallthough annotation

PATCH In review Dan Carpenter 2 participants 2 messages Aug 26, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 afs: Remove erroneous fallthough annotation

The fall through annotation comes after a return statement so it's not reachable.

---
 fs/afs/flock.c | 1 -
 1 file changed, 1 deletion(-)
fs/afs/flock.c +0 -1
index eff82a6839e4..cb3054c7843e 100644
@@ -376,7 +376,6 @@ void afs_lock_work(struct work_struct *work)
 		spin_unlock(&vnode->lock);
 		return;
 
-		fallthrough;
 	default:
 		/* Looks like a lock request was withdrawn. */
 		spin_unlock(&vnode->lock);
Signature · 1 line
2.28.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Dan Carpenter

The fall through annotation comes after a return statement so it's not reachable.

Thanks
--
Gustavo

Quoted 17 lines
---
 fs/afs/flock.c | 1 -
 1 file changed, 1 deletion(-)
fs/afs/flock.c +0 -1
index eff82a6839e4..cb3054c7843e 100644
@@ -376,7 +376,6 @@ void afs_lock_work(struct work_struct *work)
 		spin_unlock(&vnode->lock);
 		return;
 
-		fallthrough;
 	default:
 		/* Looks like a lock request was withdrawn. */
 		spin_unlock(&vnode->lock);