Skip to contentSkip to conversation

poky.conf: do not force packagegroup-core-device-devel into all qemu images

PATCH In review Alexander Kanavin 2 participants 3 messages Aug 26, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 poky.conf: do not force packagegroup-core-device-devel into all qemu images

The packages in the group are not at all essential or required, and there is no way to switch it off, if they are unwanted, other than create a new distro that is independent of poky.

The group, if someone is still using it, should be added to specific images instead.

---
 meta-poky/conf/distro/poky.conf | 8 --------
 1 file changed, 8 deletions(-)
meta-poky/conf/distro/poky.conf +0 -8
index 826f0d633a..e55641d87f 100644
@@ -29,14 +29,6 @@ SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
 DISTRO_EXTRA_RDEPENDS += " ${POKY_DEFAULT_EXTRA_RDEPENDS}"
 DISTRO_EXTRA_RRECOMMENDS += " ${POKY_DEFAULT_EXTRA_RRECOMMENDS}"
 
-POKYQEMUDEPS = "${@bb.utils.contains("INCOMPATIBLE_LICENSE", "GPL-3.0", "", "packagegroup-core-device-devel",d)}"
-DISTRO_EXTRA_RDEPENDS_append_qemuarm = " ${POKYQEMUDEPS}"
-DISTRO_EXTRA_RDEPENDS_append_qemuarm64 = " ${POKYQEMUDEPS}"
-DISTRO_EXTRA_RDEPENDS_append_qemumips = " ${POKYQEMUDEPS}"
-DISTRO_EXTRA_RDEPENDS_append_qemuppc = " ${POKYQEMUDEPS}"
-DISTRO_EXTRA_RDEPENDS_append_qemux86 = " ${POKYQEMUDEPS}"
-DISTRO_EXTRA_RDEPENDS_append_qemux86-64 = " ${POKYQEMUDEPS}"
-
 TCLIBCAPPEND = ""
 
 PREMIRRORS ??= "\
Signature · 1 line
2.28.0
#1 lore raw
Quoted 1 line · Alexander Kanavin

The packages in the group are not at all essential or required,

Certainly that packagegroup is misnamed, elderly, should be in poky rather than OE-Core and is probably not that useful any more.

Quoted 2 lines

and there is no way to switch it off , if they are unwanted, other than create a new distro that is independent of poky.

apart from simply setting POKYQEMUDEPS = "" ?

Quoted 2 lines

The group, if someone is still using it, should be added to specific images instead.

I do agree its likely time to retire this, I disagree with the wording of the commit though and if we do this, we need to get rid of that packagegroup from OE-Core as its horrible.

I'm not sure what the implications are for our testing which is my bigger worry.

Cheers,

Richard

#2 lore raw
Quoted 4 lines · Richard Purdie

I do agree its likely time to retire this, I disagree with the wording of the commit though and if we do this, we need to get rid of that packagegroup from OE-Core as its horrible.

Yes, that was hastily written, I'll rephrase.

Quoted 3 lines

I'm not sure what the implications are for our testing which is my bigger worry.

I built and checked testimage with minimal/sato, which was ok. I didn't want to fire a-full for a single patch :)

Alex