Skip to contentSkip to conversation

package/gnuradio: GNURADIO_QTGUI option require GNURADIO_ANALOG

PATCH New Gwenhael Goavec-Merou 2 participants 4 messages Aug 26, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/gnuradio: GNURADIO_QTGUI option require GNURADIO_ANALOG

From: Gwenhael Goavec-Merou <[email protected]>

---
 package/gnuradio/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/gnuradio/Config.in +1 -0
index cd31ce8864..2282f799da 100644
@@ -138,6 +138,7 @@ config BR2_PACKAGE_GNURADIO_QTGUI
 	bool "gr-qtgui"
 	depends on BR2_PACKAGE_GNURADIO_PYTHON
 	depends on BR2_PACKAGE_QT5
+	select BR2_PACKAGE_GNURADIO_ANALOG
 	select BR2_PACKAGE_GNURADIO_FFT
 	select BR2_PACKAGE_GNURADIO_FILTER
 	select BR2_PACKAGE_PYTHON_PYQT5
Signature · 1 line
2.26.2
#1 lore raw

PATCH 2/2 package/gnuradio: select LIBERATION fonts by default when GNURADIO_QTGUI is enabled

From: Gwenhael Goavec-Merou <[email protected]>

qtgui option is used to display graph. All plot has legend and configuration options with text. Without font available no text is not displayed.

---
 package/gnuradio/Config.in   | 1 +
 package/gnuradio/gnuradio.mk | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
package/gnuradio/Config.in +1 -0
index 2282f799da..a47c7b20d0 100644
@@ -141,6 +141,7 @@ config BR2_PACKAGE_GNURADIO_QTGUI
 	select BR2_PACKAGE_GNURADIO_ANALOG
 	select BR2_PACKAGE_GNURADIO_FFT
 	select BR2_PACKAGE_GNURADIO_FILTER
+	select BR2_PACKAGE_LIBERATION # runtime
 	select BR2_PACKAGE_PYTHON_PYQT5
 	select BR2_PACKAGE_QT5BASE_FONTCONFIG # runtime
 	select BR2_PACKAGE_QT5BASE_GUI # runtime
package/gnuradio/gnuradio.mk +1 -1
index 0a818cfc24..d4b6984102 100644
@@ -137,7 +137,7 @@ GNURADIO_CONF_OPTS += -DENABLE_GR_PAGER=OFF
 endif
 
 ifeq ($(BR2_PACKAGE_GNURADIO_QTGUI),y)
-GNURADIO_DEPENDENCIES += qt5base python-pyqt5 qwt
+GNURADIO_DEPENDENCIES += liberation qt5base python-pyqt5 qwt
 GNURADIO_CONF_OPTS += -DENABLE_GR_QTGUI=ON
 else
 GNURADIO_CONF_OPTS += -DENABLE_GR_QTGUI=OFF
Signature · 1 line
2.26.2
#2 lore raw

PATCH 2/2 package/gnuradio: select LIBERATION fonts by default when GNURADIO_QTGUI is enabled

Quoted 6 lines · On Wed, 26 Aug 2020 11:30:28 +0200 Gwenhael Goavec-Merou…

From: Gwenhael Goavec-Merou <[email protected]>

qtgui option is used to display graph. All plot has legend and configuration options with text. Without font available no text is not displayed.

I think it's a bit annoying to force a certain font. In fact most Qt-based applications will want a font installed, so I'm not sure doing some random font selection in each application package is really the appropriate/scalable solution.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/2 package/gnuradio: GNURADIO_QTGUI option require GNURADIO_ANALOG

In reply to Gwenhael Goavec-Merou
Quoted 3 lines · On Wed, 26 Aug 2020 11:30:27 +0200 Gwenhael Goavec-Merou…

From: Gwenhael Goavec-Merou <[email protected]>

There's no commit log. Is this fixing a build issue? A runtime issue? Could you provide more details?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com