leds: lm3692x: Simplify with dev_err_probe()
PATCH 1/4 leds: lm3692x: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/leds/leds-lm3692x.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/leds/leds-lm3692x.c +4 -7
@@ -394,13 +394,10 @@ static int lm3692x_probe_dt(struct lm3692x_led *led) led->regulator =devm_regulator_get_optional (&led->client->dev,"vled" );if (IS_ERR (led->regulator)) { ret =PTR_ERR (led->regulator); -if (ret != -ENODEV ) { -if (ret != -EPROBE_DEFER ) -dev_err (&led->client->dev, -"Failed to get vled regulator: %d\n" , - ret); -return ret; - } +if (ret != -ENODEV ) +return dev_err_probe (&led->client->dev, ret, +"Failed to get vled regulator\n" ); + led->regulator =NULL ; }
Signature · 1 line
2.17.1
PATCH 2/4 leds: pwm: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/leds/leds-pwm.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/leds/leds-pwm.c +4 -7
@@ -78,13 +78,10 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, led_data->pwm =devm_fwnode_pwm_get (dev, fwnode,NULL ); else led_data->pwm = devm_pwm_get(dev, led->name); -if (IS_ERR (led_data->pwm)) { - ret =PTR_ERR (led_data->pwm); -if (ret != -EPROBE_DEFER ) -dev_err (dev,"unable to request PWM for %s: %d\n" , - led->name, ret); -return ret; - } +if (IS_ERR (led_data->pwm)) +return dev_err_probe (dev,PTR_ERR (led_data->pwm), +"unable to request PWM for %s\n" , + led->name); led_data->cdev.brightness_set_blocking = led_pwm_set;
Signature · 1 line
2.17.1
PATCH 3/4 leds: sgm3140: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiCommon pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/leds/leds-sgm3140.c | 27 +++++++++------------------ 1 file changed, 9 insertions(+), 18 deletions(-)
drivers/leds/leds-sgm3140.c +9 -18
@@ -195,30 +195,21 @@ static int sgm3140_probe(struct platform_device *pdev) priv->flash_gpio =devm_gpiod_get (&pdev->dev,"flash" ,GPIOD_OUT_LOW ); ret =PTR_ERR_OR_ZERO (priv->flash_gpio); -if (ret) { -if (ret != -EPROBE_DEFER ) -dev_err (&pdev->dev, -"Failed to request flash gpio: %d\n" , ret); -return ret; - } +if (ret) +return dev_err_probe (&pdev->dev, ret, +"Failed to request flash gpio\n" ); priv->enable_gpio =devm_gpiod_get (&pdev->dev,"enable" ,GPIOD_OUT_LOW ); ret =PTR_ERR_OR_ZERO (priv->enable_gpio); -if (ret) { -if (ret != -EPROBE_DEFER ) -dev_err (&pdev->dev, -"Failed to request enable gpio: %d\n" , ret); -return ret; - } +if (ret) +return dev_err_probe (&pdev->dev, ret, +"Failed to request enable gpio\n" ); priv->vin_regulator =devm_regulator_get (&pdev->dev,"vin" ); ret =PTR_ERR_OR_ZERO (priv->vin_regulator); -if (ret) { -if (ret != -EPROBE_DEFER ) -dev_err (&pdev->dev, -"Failed to request regulator: %d\n" , ret); -return ret; - } +if (ret) +return dev_err_probe (&pdev->dev, ret, +"Failed to request regulator\n" ); child_node =fwnode_get_next_available_child_node (pdev->dev.fwnode,NULL );
Signature · 1 line
2.17.1
PATCH 4/4 leds: tlc591xx: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiCommon pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/leds/leds-tlc591xx.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/leds/leds-tlc591xx.c +4 -6
@@ -213,12 +213,10 @@ tlc591xx_probe(struct i2c_client *client, led->ldev.max_brightness =TLC591XX_MAX_BRIGHTNESS ; err =devm_led_classdev_register_ext (dev, &led->ldev, &init_data); -if (err <0 ) { -if (err != -EPROBE_DEFER ) -dev_err (dev,"couldn't register LED %s\n" , - led->ldev.name); -return err; - } +if (err <0 ) +return dev_err_probe (dev, err, +"couldn't register LED %s\n" , + led->ldev.name); }return 0 ; }
Signature · 1 line
2.17.1
Pavel Machek
AppliedQuoted 4 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>
Thanks, applied.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html