Skip to contentSkip to conversation

drm/amdgpu: simplify hw status clear/set logic

PATCH In review Jiawei 3 participants 4 messages Aug 27, 2020

Subsystems (2)
lore
Share & tools
lore

Jiawei

author
#0 lore raw

PATCH 1/1 drm/amdgpu: simplify hw status clear/set logic

Optimize code to iterate less loops in
amdgpu_device_ip_reinit_early_sriov()

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +6 -7
index 8f37f9f99105..696a61cc3ac6 100644
@@ -2598,17 +2598,16 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
 		AMD_IP_BLOCK_TYPE_IH,
 	};
 
-	for (i = 0; i < adev->num_ip_blocks; i++)
-		adev->ip_blocks[i].status.hw = false;
-
-	for (i = 0; i < ARRAY_SIZE(ip_order); i++) {
+	for (i = 0; i < adev->num_ip_blocks; i++) {
 		int j;
 		struct amdgpu_ip_block *block;
 
-		for (j = 0; j < adev->num_ip_blocks; j++) {
-			block = &adev->ip_blocks[j];
+		block = &adev->ip_blocks[i];
+		block->status.hw = false;
 
-			if (block->version->type != ip_order[i] ||
+		for (j = 0; j < ARRAY_SIZE(ip_order); j++) {
+
+			if (block->version->type != ip_order[j] ||
 				!block->status.valid)
 				continue;
 
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#1 lore raw

[AMD Official Use Only - Internal Distribution Only]

Ping...

-----Original Message-----
From: Jiawei <[email protected]>
Sent: Thursday, August 27, 2020 10:32 AM
To: [email protected]
Cc: Gu, JiaWei (Will) <[email protected]>
Subject: [PATCH] drm/amdgpu: simplify hw status clear/set logic

Optimize code to iterate less loops in
amdgpu_device_ip_reinit_early_sriov()

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +6 -7
index 8f37f9f99105..696a61cc3ac6 100644
@@ -2598,17 +2598,16 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
 		AMD_IP_BLOCK_TYPE_IH,
 	};
 
-	for (i = 0; i < adev->num_ip_blocks; i++)
-		adev->ip_blocks[i].status.hw = false;
-
-	for (i = 0; i < ARRAY_SIZE(ip_order); i++) {
+	for (i = 0; i < adev->num_ip_blocks; i++) {
 		int j;
 		struct amdgpu_ip_block *block;
 
-		for (j = 0; j < adev->num_ip_blocks; j++) {
-			block = &adev->ip_blocks[j];
+		block = &adev->ip_blocks[i];
+		block->status.hw = false;
 
-			if (block->version->type != ip_order[i] ||
+		for (j = 0; j < ARRAY_SIZE(ip_order); j++) {
+
+			if (block->version->type != ip_order[j] ||
 				!block->status.valid)
 				continue;
 
Signature · 5 lines
2.17.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by
#2 lore raw
Quoted 60 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Gu, JiaWei (Will)
Sent: Thursday, August 27, 2020 2:50 PM
To: [email protected]
Cc: Gu, JiaWei (Will) <[email protected]>
Subject: RE: [PATCH] drm/amdgpu: simplify hw status clear/set logic

[AMD Official Use Only - Internal Distribution Only]

Ping...

-----Original Message-----
From: Jiawei <[email protected]>
Sent: Thursday, August 27, 2020 10:32 AM
To: [email protected]
Cc: Gu, JiaWei (Will) <[email protected]>
Subject: [PATCH] drm/amdgpu: simplify hw status clear/set logic

Optimize code to iterate less loops in
amdgpu_device_ip_reinit_early_sriov()

---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 13 ++++++-------

1 file changed, 6 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +6 -8
index 8f37f9f99105..696a61cc3ac6 100644
@@ -2598,17 +2598,16 @@ static int
 amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
 		AMD_IP_BLOCK_TYPE_IH,
 	};
 
-	for (i = 0; i < adev->num_ip_blocks; i++)
-		adev->ip_blocks[i].status.hw = false;
-
-	for (i = 0; i < ARRAY_SIZE(ip_order); i++) {
+	for (i = 0; i < adev->num_ip_blocks; i++) {
 		int j;
 		struct amdgpu_ip_block *block;
 
-		for (j = 0; j < adev->num_ip_blocks; j++) {
-			block = &adev->ip_blocks[j];
+		block = &adev->ip_blocks[i];
+		block->status.hw = false;
 
-			if (block->version->type != ip_order[i] ||
+		for (j = 0; j < ARRAY_SIZE(ip_order); j++) {
+
+			if (block->version->type != ip_order[j] ||
 				!block->status.valid)
 				continue;
 
--

2.17.1
_______________________________________________

Quoted 8 lines

amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.free
desktop.org%2Fmailman%2Flistinfo%2Famd- gfx&amp;data=02%7C01%7CEmily.Deng%40amd.com%7Cd49aeebc6337454ad be508d84a558474%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6 37341078483894286&amp;sdata=ORgvulljLZNfexMcXZCXi4JEmz3J357Oxa%2B GxYW3%2FSo%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw
In reply to Jiawei
Quoted 21 lines · Jiawei

Optimize code to iterate less loops in
amdgpu_device_ip_reinit_early_sriov()

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 13 ++++++-------
  1 file changed, 6 insertions(+), 7 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -4
index 8f37f9f99105..696a61cc3ac6 100644
@@ -2598,17 +2598,16 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
  		AMD_IP_BLOCK_TYPE_IH,
  	};
 
-	for (i = 0; i < adev->num_ip_blocks; i++)
-		adev->ip_blocks[i].status.hw = false;
-
-	for (i = 0; i < ARRAY_SIZE(ip_order); i++) {
+	for (i = 0; i < adev->num_ip_blocks; i++) {

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev) · line 2608

Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +3 -3
  		int j;
  		struct amdgpu_ip_block *block;
 
-		for (j = 0; j < adev->num_ip_blocks; j++) {
-			block = &adev->ip_blocks[j];
+		block = &adev->ip_blocks[i];
+		block->status.hw = false;
 
-			if (block->version->type != ip_order[i] ||
+		for (j = 0; j < ARRAY_SIZE(ip_order); j++) {

We could probably replace this "for" loop with a big if-statement

    if ( block->version->type== AMD_IP_BLOCK_TYPE_GMC ||

         block->version->type== AMD_IP_BLOCK_TYPE_COMMON ... )

But anyway it looks good to me as it is. Acked-by: Nirmoy Das <[email protected]>

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev) · line 2613

Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 -0
+
+			if (block->version->type != ip_order[j] ||
  				!block->status.valid)
  				continue;
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx