drm/mcde: Fix handling of platform_get_irq() error
Subsystems (4)
PATCH 1/2 drm/mcde: Fix handling of platform_get_irq() error
platform_get_irq() returns -ERRNO on error. In such case comparison to 0 would pass the check.
--- drivers/gpu/drm/mcde/mcde_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/mcde/mcde_drv.c +2 -2
@@ -331,8 +331,8 @@ static int mcde_probe(struct platform_device *pdev) } irq =platform_get_irq (pdev,0 ); -if (!irq) { - ret = -EINVAL ; +if (irq <0 ) { + ret = irq; goto clk_disable; }
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 2/2 drm/tve200: Fix handling of platform_get_irq() error
platform_get_irq() returns -ERRNO on error. In such case comparison to 0 would pass the check.
--- drivers/gpu/drm/tve200/tve200_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tve200/tve200_drv.c +2 -2
@@ -200,8 +200,8 @@ static int tve200_probe(struct platform_device *pdev) } irq =platform_get_irq (pdev,0 ); -if (!irq) { - ret = -EINVAL ; +if (irq <0 ) { + ret = irq; goto clk_disable; }
Signature · 1 line
2.17.1
Re: [PATCH 2/2] drm/tve200: Fix handling of platform_get_irq() error
Quoted 5 lines · Krzysztof Kozlowski
platform_get_irq()returns-ERRNOon error. In such case comparison to 0 would pass the check.Fixes 179c02fe90a4 ("drm/tve200: Add new driver for TVE200")Signed-off-by Krzysztof Kozlowski <[email protected]>
Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 5 lines · Krzysztof Kozlowski
platform_get_irq()returns-ERRNOon error. In such case comparison to 0 would pass the check.Fixes 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")Signed-off-by Krzysztof Kozlowski <[email protected]>
Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sam Ravnborg
AppliedHi Krzysztof
Quoted 5 lines · Krzysztof Kozlowski
platform_get_irq()returns-ERRNOon error. In such case comparison to 0 would pass the check.Fixes 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")Signed-off-by Krzysztof Kozlowski <[email protected]>
Thanks, applied this and the tve200 patch to drm-misc-next. They will appear in -next in a few weeks time.
Sam