Skip to contentSkip to conversation

ath9k: Do not select MAC80211_LEDS by default

PATCH In review Krzysztof Kozlowski 2 participants 2 messages Aug 20, 2020 – Aug 27, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath9k: Do not select MAC80211_LEDS by default

The ath9k driver hides all LEDs related code behind CONFIG_MAC80211_LEDS ifdefs so it does not really require the MAC80211_LEDS. The code builds fine. Convert the "select" into "imply" to allow disabling LED trigger when not needed.

---

Not tested on HW.

Continuation of: https://lore.kernel.org/lkml/[email protected]/

---
 drivers/net/wireless/ath/ath9k/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath9k/Kconfig +3 -3
index 5effb3886631..a84bb9b6573f 100644
@@ -22,10 +22,10 @@ config ATH9K
 	tristate "Atheros 802.11n wireless cards support"
 	depends on MAC80211 && HAS_DMA
 	select ATH9K_HW
-	select MAC80211_LEDS
-	select LEDS_CLASS
-	select NEW_LEDS
 	select ATH9K_COMMON
+	imply NEW_LEDS
+	imply LEDS_CLASS
+	imply MAC80211_LEDS
 	help
 	  This module adds support for wireless adapters based on
 	  Atheros IEEE 802.11n AR5008, AR9001 and AR9002 family
Signature · 1 line
2.17.1
#1 lore raw
Quoted 7 lines · Krzysztof Kozlowski

The ath9k driver hides all LEDs related code behind CONFIG_MAC80211_LEDS ifdefs so it does not really require the MAC80211_LEDS. The code builds fine. Convert the "select" into "imply" to allow disabling LED trigger when not needed.

Patch applied to ath-next branch of ath.git, thanks.

72cdab808714 ath9k: Do not select MAC80211_LEDS by default

Signature · 3 lines
https://patchwork.kernel.org/patch/11727077/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches