Skip to contentSkip to conversation

sched: idle: Change the cpu_idle_poll() return type to void

PATCH New Frank Lee 1 participant 1 message Aug 27, 2020 Scheduler

lore
Share & tools
lore

Frank Lee

author
#0 lore raw

PATCH 1/1 sched: idle: Change the cpu_idle_poll() return type to void

From: Yangtao Li <[email protected]>

No one cares about the return value of this function, which only increases the time spent in idle loop. Let's drop it.

---
 kernel/sched/idle.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
kernel/sched/idle.c +1 -3
index 6bf34986f45c..5250a7c466e6 100644
@@ -52,7 +52,7 @@ static int __init cpu_idle_nopoll_setup(char *__unused)
 __setup("hlt", cpu_idle_nopoll_setup);
 #endif
 
-static noinline int __cpuidle cpu_idle_poll(void)
+static noinline void __cpuidle cpu_idle_poll(void)
 {
 	rcu_idle_enter();
 	trace_cpu_idle_rcuidle(0, smp_processor_id());
@@ -65,8 +65,6 @@ static noinline int __cpuidle cpu_idle_poll(void)
 	start_critical_timings();
 	trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
 	rcu_idle_exit();
-
-	return 1;
 }
 
 /* Weak implementations for optional arch specific functions */
Signature · 1 line
2.28.0