staging: ion: remove from the tree
Greg Kroah-Hartman
maintainerPATCH 1/1 staging: ion: remove from the tree
The ION android code has long been marked to be removed, now that we dma-buf support merged into the real part of the kernel.
It was thought that we could wait to remove the ion kernel at a later time, but as the out-of-tree Android fork of the ion code has diverged quite a bit, and any Android device using the ion interface uses that forked version and not this in-tree version, the in-tree copy of the code is abandonded and not used by anyone.
Combine this abandoned codebase with the need to make changes to it in order to keep the kernel building properly, which then causes merge issues when merging those changes into the out-of-tree Android code, and you end up with two different groups of people (the in-kernel-tree developers, and the Android kernel developers) who are both annoyed at the current situation. Because of this problem, just drop the in-kernel copy of the ion code now, as it's not used, and is only causing problems for everyone involved.
--- MAINTAINERS | 10 - drivers/staging/android/Kconfig | 2 - drivers/staging/android/Makefile | 2 - drivers/staging/android/TODO | 5 - drivers/staging/android/ion/Kconfig | 27 - drivers/staging/android/ion/Makefile | 4 - drivers/staging/android/ion/ion.c | 649 ------------------ drivers/staging/android/ion/ion.h | 302 -------- drivers/staging/android/ion/ion_cma_heap.c | 138 ---- drivers/staging/android/ion/ion_heap.c | 286 -------- drivers/staging/android/ion/ion_page_pool.c | 155 ----- drivers/staging/android/ion/ion_system_heap.c | 377 ---------- drivers/staging/android/uapi/ion.h | 127 ---- tools/testing/selftests/Makefile | 3 +- tools/testing/selftests/android/Makefile | 39 -- tools/testing/selftests/android/config | 5 - .../testing/selftests/android/ion/.gitignore | 4 - tools/testing/selftests/android/ion/Makefile | 20 - tools/testing/selftests/android/ion/README | 101 --- tools/testing/selftests/android/ion/ion.h | 134 ---- .../testing/selftests/android/ion/ion_test.sh | 58 -- .../selftests/android/ion/ionapp_export.c | 127 ---- .../selftests/android/ion/ionapp_import.c | 79 --- .../selftests/android/ion/ionmap_test.c | 136 ---- .../testing/selftests/android/ion/ionutils.c | 253 ------- .../testing/selftests/android/ion/ionutils.h | 55 -- .../testing/selftests/android/ion/ipcsocket.c | 227 ------ .../testing/selftests/android/ion/ipcsocket.h | 35 - tools/testing/selftests/android/run.sh | 3 - 29 files changed, 1 insertion(+), 3362 deletions(-) delete mode 100644 drivers/staging/android/ion/Kconfig delete mode 100644 drivers/staging/android/ion/Makefile delete mode 100644 drivers/staging/android/ion/ion.c delete mode 100644 drivers/staging/android/ion/ion.h delete mode 100644 drivers/staging/android/ion/ion_cma_heap.c delete mode 100644 drivers/staging/android/ion/ion_heap.c delete mode 100644 drivers/staging/android/ion/ion_page_pool.c delete mode 100644 drivers/staging/android/ion/ion_system_heap.c delete mode 100644 drivers/staging/android/uapi/ion.h delete mode 100644 tools/testing/selftests/android/Makefile delete mode 100644 tools/testing/selftests/android/config delete mode 100644 tools/testing/selftests/android/ion/.gitignore delete mode 100644 tools/testing/selftests/android/ion/Makefile delete mode 100644 tools/testing/selftests/android/ion/README delete mode 100644 tools/testing/selftests/android/ion/ion.h delete mode 100755 tools/testing/selftests/android/ion/ion_test.sh delete mode 100644 tools/testing/selftests/android/ion/ionapp_export.c delete mode 100644 tools/testing/selftests/android/ion/ionapp_import.c delete mode 100644 tools/testing/selftests/android/ion/ionmap_test.c delete mode 100644 tools/testing/selftests/android/ion/ionutils.c delete mode 100644 tools/testing/selftests/android/ion/ionutils.h delete mode 100644 tools/testing/selftests/android/ion/ipcsocket.c delete mode 100644 tools/testing/selftests/android/ion/ipcsocket.h delete mode 100755 tools/testing/selftests/android/run.sh
MAINTAINERS +0 -10
@@ -1200,16 +1200,6 @@ S: Supported F: Documentation/devicetree/bindings/rtc/google,goldfish-rtc.txt F: drivers/rtc/rtc-goldfish.c -ANDROID ION DRIVER -M: Laura Abbott <[email protected]> -M: Sumit Semwal <[email protected]> -L: [email protected] -L: [email protected] -L: [email protected] (moderated for non-subscribers) -S: Supported -F: drivers/staging/android/ion -F: drivers/staging/android/uapi/ion.h - AOA (Apple Onboard Audio) ALSA DRIVER M: Johannes Berg <[email protected]> L: [email protected]
drivers/staging/android/Kconfig +0 -2
@@ -14,8 +14,6 @@ config ASHMEM It is, in theory, a good memory allocator for low-memory devices, because it can discard shared memory units when under memory pressure. -source "drivers/staging/android/ion/Kconfig" - endif # if ANDROID endmenu
drivers/staging/android/Makefile +0 -2
@@ -1,6 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 ccflags-y += -I$(src) # needed for trace events -obj-y += ion/ - obj-$(CONFIG_ASHMEM) += ashmem.o
drivers/staging/android/TODO +0 -5
@@ -4,10 +4,5 @@ TODO: - add proper arch dependencies as needed - audit userspace interfaces to make sure they are sane - -ion/ - - Split /dev/ion up into multiple nodes (e.g. /dev/ion/heap0) - - Better test framework (integration with VGEM was suggested) - Please send patches to Greg Kroah-Hartman <[email protected]> and Cc: Arve Hjønnevåg <[email protected]> and Riley Andrews <[email protected]>
drivers/staging/android/ion/Kconfig deleted +0 -27
@@ -1,27 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -menuconfig ION - bool "Ion Memory Manager" - depends on HAS_DMA && MMU - select GENERIC_ALLOCATOR - select DMA_SHARED_BUFFER - help - Choose this option to enable the ION Memory Manager, - used by Android to efficiently allocate buffers - from userspace that can be shared between drivers. - If you're not using Android its probably safe to - say N here. - -config ION_SYSTEM_HEAP - bool "Ion system heap" - depends on ION - help - Choose this option to enable the Ion system heap. The system heap - is backed by pages from the buddy allocator. If in doubt, say Y. - -config ION_CMA_HEAP - bool "Ion CMA heap support" - depends on ION && DMA_CMA - help - Choose this option to enable CMA heaps with Ion. This heap is backed - by the Contiguous Memory Allocator (CMA). If your system has these - regions, you should say Y here.
drivers/staging/android/ion/Makefile deleted +0 -4
@@ -1,4 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_ION) += ion.o ion_heap.o -obj-$(CONFIG_ION_SYSTEM_HEAP) += ion_system_heap.o ion_page_pool.o -obj-$(CONFIG_ION_CMA_HEAP) += ion_cma_heap.o
drivers/staging/android/ion/ion.c deleted +0 -649
649 lines not on this page · raw message
drivers/staging/android/ion/ion.h deleted +0 -302
302 lines not on this page · raw message
drivers/staging/android/ion/ion_cma_heap.c deleted +0 -138
138 lines not on this page · raw message
drivers/staging/android/ion/ion_heap.c deleted +0 -286
286 lines not on this page · raw message
drivers/staging/android/ion/ion_page_pool.c deleted +0 -155
155 lines not on this page · raw message
drivers/staging/android/ion/ion_system_heap.c deleted +0 -377
377 lines not on this page · raw message
drivers/staging/android/uapi/ion.h deleted +0 -127
127 lines not on this page · raw message
tools/testing/selftests/Makefile +1 -2
@@ -1,6 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -TARGETS = android -TARGETS += arm64 +TARGETS = arm64 TARGETS += bpf TARGETS += breakpoints TARGETS += capabilities
tools/testing/selftests/android/Makefile deleted +0 -39
@@ -1,39 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-only -SUBDIRS := ion - -TEST_PROGS := run.sh - -.PHONY: all clean - -include ../lib.mk - -all: - @for DIR in $(SUBDIRS); do \ - BUILD_TARGET=$(OUTPUT)/$$DIR; \ - mkdir $$BUILD_TARGET -p; \ - make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\ - #SUBDIR test prog name should be in the form: SUBDIR_test.sh \ - TEST=$$DIR"_test.sh"; \ - if [ -e $$DIR/$$TEST ]; then \ - rsync -a $$DIR/$$TEST $$BUILD_TARGET/; \ - fi \ - done - -override define INSTALL_RULE - mkdir -p $(INSTALL_PATH) -install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) - - @for SUBDIR in $(SUBDIRS); do \ - BUILD_TARGET=$(OUTPUT)/$$SUBDIR; \ - mkdir $$BUILD_TARGET -p; \ - $(MAKE) OUTPUT=$$BUILD_TARGET -C $$SUBDIR INSTALL_PATH=$(INSTALL_PATH)/$$SUBDIR install; \ - done; -endef - -override define CLEAN - @for DIR in $(SUBDIRS); do \ - BUILD_TARGET=$(OUTPUT)/$$DIR; \ - mkdir $$BUILD_TARGET -p; \ - make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\ - done -endef
tools/testing/selftests/android/config deleted +0 -5
@@ -1,5 +0,0 @@ -CONFIG_ANDROID=y -CONFIG_STAGING=y -CONFIG_ION=y -CONFIG_ION_SYSTEM_HEAP=y -CONFIG_DRM_VGEM=y
tools/testing/selftests/android/ion/.gitignore deleted +0 -4
@@ -1,4 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-only -ionapp_export -ionapp_import -ionmap_test
tools/testing/selftests/android/ion/Makefile deleted +0 -20
@@ -1,20 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-only - -INCLUDEDIR := -I. -I../../../../../drivers/staging/android/uapi/ -I../../../../../usr/include/ -CFLAGS := $(CFLAGS) $(INCLUDEDIR) -Wall -O2 -g - -TEST_GEN_FILES := ionapp_export ionapp_import ionmap_test - -all: $(TEST_GEN_FILES) - -$(TEST_GEN_FILES): ipcsocket.c ionutils.c - -TEST_PROGS := ion_test.sh - -KSFT_KHDR_INSTALL := 1 -top_srcdir = ../../../../.. -include ../../lib.mk - -$(OUTPUT)/ionapp_export: ionapp_export.c ipcsocket.c ionutils.c -$(OUTPUT)/ionapp_import: ionapp_import.c ipcsocket.c ionutils.c -$(OUTPUT)/ionmap_test: ionmap_test.c ionutils.c ipcsocket.c
tools/testing/selftests/android/ion/README deleted +0 -101
101 lines not on this page · raw message
tools/testing/selftests/android/ion/ion.h deleted +0 -134
134 lines not on this page · raw message
tools/testing/selftests/android/ion/ion_test.sh deleted +0 -58
58 lines not on this page · raw message
tools/testing/selftests/android/ion/ionapp_export.c deleted +0 -127
127 lines not on this page · raw message
tools/testing/selftests/android/ion/ionapp_import.c deleted +0 -79
79 lines not on this page · raw message
tools/testing/selftests/android/ion/ionmap_test.c deleted +0 -136
136 lines not on this page · raw message
tools/testing/selftests/android/ion/ionutils.c deleted +0 -253
185 lines not on this page · raw message
tools/testing/selftests/android/ion/ionutils.h deleted +0 -55
55 lines not on this page · raw message
tools/testing/selftests/android/ion/ipcsocket.c deleted +0 -227
227 lines not on this page · raw message
tools/testing/selftests/android/ion/ipcsocket.h deleted +0 -35
Lines of this file are not shown. View the raw message.
tools/testing/selftests/android/run.sh deleted +0 -3
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 6 lines
2.28.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Part of the diff is not shown here. View the raw message.
Quoted 27 lines · Greg Kroah-Hartman
The ION android code has long been marked to be removed, now that we dma-buf support merged into the real part of the kernel.
It was thought that we could wait to remove the ion kernel at a later time, but as the out-of-tree Android fork of the ion code has diverged quite a bit, and any Android device using the ion interface uses that forked version and not this in-tree version, the in-tree copy of the code is abandonded and not used by anyone.
Combine this abandoned codebase with the need to make changes to it in order to keep the kernel building properly, which then causes merge issues when merging those changes into the out-of-tree Android code, and you end up with two different groups of people (the in-kernel-tree developers, and the Android kernel developers) who are both annoyed at the current situation. Because of this problem, just drop the in-kernel copy of the ion code now, as it's not used, and is only causing problems for everyone involved.
Cc "Arve Hjønnevåg" <[email protected]>Cc "Christian König" <[email protected]>Cc Christian Brauner <[email protected]>Cc Christoph Hellwig <[email protected]>Cc Hridya Valsaraju <[email protected]>Cc Joel Fernandes <[email protected]>Cc John Stultz <[email protected]>Cc Laura Abbott <[email protected]>Cc Martijn Coenen <[email protected]>
Quoted 8 lines
Cc Shuah Khan <[email protected]>Cc Sumit Semwal <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Todd Kjos <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
We discussed this at the Android MC on Monday and the plan was to remove it after the next LTS release.
Greg Kroah-Hartman
maintainerQuoted 37 lines · Laura Abbott
Quoted 27 lines · Greg Kroah-Hartman
The ION android code has long been marked to be removed, now that we dma-buf support merged into the real part of the kernel.
It was thought that we could wait to remove the ion kernel at a later time, but as the out-of-tree Android fork of the ion code has diverged quite a bit, and any Android device using the ion interface uses that forked version and not this in-tree version, the in-tree copy of the code is abandonded and not used by anyone.
Combine this abandoned codebase with the need to make changes to it in order to keep the kernel building properly, which then causes merge issues when merging those changes into the out-of-tree Android code, and you end up with two different groups of people (the in-kernel-tree developers, and the Android kernel developers) who are both annoyed at the current situation. Because of this problem, just drop the in-kernel copy of the ion code now, as it's not used, and is only causing problems for everyone involved.
Cc "Arve Hjønnevåg" <[email protected]>Cc "Christian König" <[email protected]>Cc Christian Brauner <[email protected]>Cc Christoph Hellwig <[email protected]>Cc Hridya Valsaraju <[email protected]>Cc Joel Fernandes <[email protected]>Cc John Stultz <[email protected]>Cc Laura Abbott <[email protected]>Cc Martijn Coenen <[email protected]>Quoted 8 lines
Cc Shuah Khan <[email protected]>Cc Sumit Semwal <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Todd Kjos <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 2 lines
We discussed this at the Android MC on Monday and the plan was to remove it after the next LTS release.
I know it was discussed, my point is that it is actually causing problems now (with developers who want to change the internal kernel api hitting issues, and newbies trying to clean up code in ways that isn't exactly optimal wasting maintainer cycles), and that anyone who uses this code, is not actually using this version of the code. Everyone who relies on ion right now, is using the version that is in the Android common kernel tree, which has diverged from this in-kernel way quite a bit now for the reason that we didn't want to take any of those new features in the in-kernel version.
So this is a problem that we have caused by just wanting to wait, no one is using this code, combined with it causing problems for the upstream developers.
There is nothing "magic" about the last kernel of the year that requires this code to sit here until then. At that point in time, all users will, again, be using the forked Android kernel version, and if we delete this now here, that fork can remain just fine, with the added benifit of it reducing developer workloads here in-kernel.
So why wait?
thanks,
greg k-h
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 56 lines · Greg Kroah-Hartman
Quoted 37 lines · Laura Abbott
Quoted 27 lines · Greg Kroah-Hartman
The ION android code has long been marked to be removed, now that we dma-buf support merged into the real part of the kernel.
It was thought that we could wait to remove the ion kernel at a later time, but as the out-of-tree Android fork of the ion code has diverged quite a bit, and any Android device using the ion interface uses that forked version and not this in-tree version, the in-tree copy of the code is abandonded and not used by anyone.
Combine this abandoned codebase with the need to make changes to it in order to keep the kernel building properly, which then causes merge issues when merging those changes into the out-of-tree Android code, and you end up with two different groups of people (the in-kernel-tree developers, and the Android kernel developers) who are both annoyed at the current situation. Because of this problem, just drop the in-kernel copy of the ion code now, as it's not used, and is only causing problems for everyone involved.
Cc "Arve Hjønnevåg" <[email protected]>Cc "Christian König" <[email protected]>Cc Christian Brauner <[email protected]>Cc Christoph Hellwig <[email protected]>Cc Hridya Valsaraju <[email protected]>Cc Joel Fernandes <[email protected]>Cc John Stultz <[email protected]>Cc Laura Abbott <[email protected]>Cc Martijn Coenen <[email protected]>Quoted 8 lines
Cc Shuah Khan <[email protected]>Cc Sumit Semwal <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Todd Kjos <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Quoted 2 lines
We discussed this at the Android MC on Monday and the plan was to remove it after the next LTS release.
I know it was discussed, my point is that it is actually causing problems now (with developers who want to change the internal kernel api hitting issues, and newbies trying to clean up code in ways that isn't exactly optimal wasting maintainer cycles), and that anyone who uses this code, is not actually using this version of the code. Everyone who relies on ion right now, is using the version that is in the Android common kernel tree, which has diverged from this in-kernel way quite a bit now for the reason that we didn't want to take any of those new features in the in-kernel version.
So this is a problem that we have caused by just wanting to wait, no one is using this code, combined with it causing problems for the upstream developers.
Quoted 7 lines
There is nothing "magic" about the last kernel of the year that requires this code to sit here until then. At that point in time, all users will, again, be using the forked Android kernel version, and if we delete this now here, that fork can remain just fine, with the added benifit of it reducing developer workloads here in-kernel.
So why wait?
Hi,
I don't know what is the right thing to do here. I just want to highlight that AOSP's audio (codec2) HAL depends on the ION system heap and it will break AOSP for people who boot mainline on their devices, even for just testing purpose like we do in Linaro. Right now we need only 1 (Android specific out-of-tree) patch to boot AOSP with mainline and Sumit is already trying to upstream that vma naming patch. Removal of in-kernel ION, will just add more to that delta.
Regards,
Amit Pundir
Quoted 4 lines
thanks,
greg k-h
Quoted 68 lines · Amit Pundir
Quoted 56 lines · Greg Kroah-Hartman
Quoted 37 lines · Laura Abbott
Quoted 27 lines · Greg Kroah-Hartman
The ION android code has long been marked to be removed, now that we dma-buf support merged into the real part of the kernel.
It was thought that we could wait to remove the ion kernel at a later time, but as the out-of-tree Android fork of the ion code has diverged quite a bit, and any Android device using the ion interface uses that forked version and not this in-tree version, the in-tree copy of the code is abandonded and not used by anyone.
Combine this abandoned codebase with the need to make changes to it in order to keep the kernel building properly, which then causes merge issues when merging those changes into the out-of-tree Android code, and you end up with two different groups of people (the in-kernel-tree developers, and the Android kernel developers) who are both annoyed at the current situation. Because of this problem, just drop the in-kernel copy of the ion code now, as it's not used, and is only causing problems for everyone involved.
Cc "Arve Hjønnevåg" <[email protected]>Cc "Christian König" <[email protected]>Cc Christian Brauner <[email protected]>Cc Christoph Hellwig <[email protected]>Cc Hridya Valsaraju <[email protected]>Cc Joel Fernandes <[email protected]>Cc John Stultz <[email protected]>Cc Laura Abbott <[email protected]>Cc Martijn Coenen <[email protected]>Quoted 8 lines
Cc Shuah Khan <[email protected]>Cc Sumit Semwal <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Todd Kjos <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Quoted 2 lines
We discussed this at the Android MC on Monday and the plan was to remove it after the next LTS release.
I know it was discussed, my point is that it is actually causing problems now (with developers who want to change the internal kernel api hitting issues, and newbies trying to clean up code in ways that isn't exactly optimal wasting maintainer cycles), and that anyone who uses this code, is not actually using this version of the code. Everyone who relies on ion right now, is using the version that is in the Android common kernel tree, which has diverged from this in-kernel way quite a bit now for the reason that we didn't want to take any of those new features in the in-kernel version.
So this is a problem that we have caused by just wanting to wait, no one is using this code, combined with it causing problems for the upstream developers.
Quoted 7 lines
There is nothing "magic" about the last kernel of the year that requires this code to sit here until then. At that point in time, all users will, again, be using the forked Android kernel version, and if we delete this now here, that fork can remain just fine, with the added benifit of it reducing developer workloads here in-kernel.
So why wait?
Hi,
Quoted 7 lines
I don't know what is the right thing to do here. I just want to highlight that AOSP's audio (codec2) HAL depends on the ION system heap and it will break AOSP for people who boot mainline on their devices, even for just testing purpose like we do in Linaro. Right now we need only 1 (Android specific out-of-tree) patch to boot AOSP with mainline and Sumit is already trying to upstream that vma naming patch. Removal of in-kernel ION, will just add more to that delta.
So that means you now have to carry 2 patches instead of 1, right? That's not that bad :-D.
BTW, why doesn't your mainline testing use dmabuf already?
AFAIK, upstream has inertia catching up to products etc, so sooner its removed the better if it is mostly dead (Before it turns into ashmem which nobody can remove). My 2c.
thanks,
- Joel
Greg Kroah-Hartman
maintainerQuoted 68 lines · Amit Pundir
Quoted 56 lines · Greg Kroah-Hartman
Quoted 37 lines · Laura Abbott
Quoted 27 lines · Greg Kroah-Hartman
The ION android code has long been marked to be removed, now that we dma-buf support merged into the real part of the kernel.
It was thought that we could wait to remove the ion kernel at a later time, but as the out-of-tree Android fork of the ion code has diverged quite a bit, and any Android device using the ion interface uses that forked version and not this in-tree version, the in-tree copy of the code is abandonded and not used by anyone.
Combine this abandoned codebase with the need to make changes to it in order to keep the kernel building properly, which then causes merge issues when merging those changes into the out-of-tree Android code, and you end up with two different groups of people (the in-kernel-tree developers, and the Android kernel developers) who are both annoyed at the current situation. Because of this problem, just drop the in-kernel copy of the ion code now, as it's not used, and is only causing problems for everyone involved.
Cc "Arve Hjønnevåg" <[email protected]>Cc "Christian König" <[email protected]>Cc Christian Brauner <[email protected]>Cc Christoph Hellwig <[email protected]>Cc Hridya Valsaraju <[email protected]>Cc Joel Fernandes <[email protected]>Cc John Stultz <[email protected]>Cc Laura Abbott <[email protected]>Cc Martijn Coenen <[email protected]>Quoted 8 lines
Cc Shuah Khan <[email protected]>Cc Sumit Semwal <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Todd Kjos <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Quoted 2 lines
We discussed this at the Android MC on Monday and the plan was to remove it after the next LTS release.
I know it was discussed, my point is that it is actually causing problems now (with developers who want to change the internal kernel api hitting issues, and newbies trying to clean up code in ways that isn't exactly optimal wasting maintainer cycles), and that anyone who uses this code, is not actually using this version of the code. Everyone who relies on ion right now, is using the version that is in the Android common kernel tree, which has diverged from this in-kernel way quite a bit now for the reason that we didn't want to take any of those new features in the in-kernel version.
So this is a problem that we have caused by just wanting to wait, no one is using this code, combined with it causing problems for the upstream developers.
Quoted 7 lines
There is nothing "magic" about the last kernel of the year that requires this code to sit here until then. At that point in time, all users will, again, be using the forked Android kernel version, and if we delete this now here, that fork can remain just fine, with the added benifit of it reducing developer workloads here in-kernel.
So why wait?
Hi,
Quoted 7 lines
I don't know what is the right thing to do here. I just want to highlight that AOSP's audio (codec2) HAL depends on the ION system heap and it will break AOSP for people who boot mainline on their devices, even for just testing purpose like we do in Linaro. Right now we need only 1 (Android specific out-of-tree) patch to boot AOSP with mainline and Sumit is already trying to upstream that vma naming patch. Removal of in-kernel ION, will just add more to that delta.
As AOSP will continue to rely on ION after December of this year, all you are doing is postponing the inevitable a few more months.
Push back on the Android team to fix up the code to not use ION, they know this needs to happen.
thanks,
greg k-h
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 78 lines · Greg Kroah-Hartman
Quoted 68 lines · Amit Pundir
Quoted 56 lines · Greg Kroah-Hartman
Quoted 37 lines · Laura Abbott
Quoted 27 lines · Greg Kroah-Hartman
The ION android code has long been marked to be removed, now that we dma-buf support merged into the real part of the kernel.
It was thought that we could wait to remove the ion kernel at a later time, but as the out-of-tree Android fork of the ion code has diverged quite a bit, and any Android device using the ion interface uses that forked version and not this in-tree version, the in-tree copy of the code is abandonded and not used by anyone.
Combine this abandoned codebase with the need to make changes to it in order to keep the kernel building properly, which then causes merge issues when merging those changes into the out-of-tree Android code, and you end up with two different groups of people (the in-kernel-tree developers, and the Android kernel developers) who are both annoyed at the current situation. Because of this problem, just drop the in-kernel copy of the ion code now, as it's not used, and is only causing problems for everyone involved.
Cc "Arve Hjønnevåg" <[email protected]>Cc "Christian König" <[email protected]>Cc Christian Brauner <[email protected]>Cc Christoph Hellwig <[email protected]>Cc Hridya Valsaraju <[email protected]>Cc Joel Fernandes <[email protected]>Cc John Stultz <[email protected]>Cc Laura Abbott <[email protected]>Cc Martijn Coenen <[email protected]>Quoted 8 lines
Cc Shuah Khan <[email protected]>Cc Sumit Semwal <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Todd Kjos <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>Quoted 2 lines
We discussed this at the Android MC on Monday and the plan was to remove it after the next LTS release.
I know it was discussed, my point is that it is actually causing problems now (with developers who want to change the internal kernel api hitting issues, and newbies trying to clean up code in ways that isn't exactly optimal wasting maintainer cycles), and that anyone who uses this code, is not actually using this version of the code. Everyone who relies on ion right now, is using the version that is in the Android common kernel tree, which has diverged from this in-kernel way quite a bit now for the reason that we didn't want to take any of those new features in the in-kernel version.
So this is a problem that we have caused by just wanting to wait, no one is using this code, combined with it causing problems for the upstream developers.
Quoted 7 lines
There is nothing "magic" about the last kernel of the year that requires this code to sit here until then. At that point in time, all users will, again, be using the forked Android kernel version, and if we delete this now here, that fork can remain just fine, with the added benifit of it reducing developer workloads here in-kernel.
So why wait?
Hi,
Quoted 7 lines
I don't know what is the right thing to do here. I just want to highlight that AOSP's audio (codec2) HAL depends on the ION system heap and it will break AOSP for people who boot mainline on their devices, even for just testing purpose like we do in Linaro. Right now we need only 1 (Android specific out-of-tree) patch to boot AOSP with mainline and Sumit is already trying to upstream that vma naming patch. Removal of in-kernel ION, will just add more to that delta.
Quoted 6 lines
As AOSP will continue to rely on ION after December of this year, all you are doing is postponing the inevitable a few more months.
Push back on the Android team to fix up the code to not use ION, they know this needs to happen.
Hi all,
We are currently working with the codec2 team to transition codec2 to use libdmabufheap instead of libion. It will definitely happen during the Android S timeframe.
Thanks,
Hridya
Quoted 3 lines
thanks,
greg k-h
Quoted 9 lines · Greg Kroah-Hartman
Quoted 7 lines · Amit Pundir
I don't know what is the right thing to do here. I just want to highlight that AOSP's audio (codec2) HAL depends on the ION system heap and it will break AOSP for people who boot mainline on their devices, even for just testing purpose like we do in Linaro. Right now we need only 1 (Android specific out-of-tree) patch to boot AOSP with mainline and Sumit is already trying to upstream that vma naming patch. Removal of in-kernel ION, will just add more to that delta.
Quoted 5 lines
As AOSP will continue to rely on ION after December of this year, all you are doing is postponing the inevitable a few more months.
Push back on the Android team to fix up the code to not use ION, they know this needs to happen.
The point though, is your main premise that no one is using this isn't true.
I'm actively working with Hridya and folks on the codec2 HAL side to transition this on the userland side:
https://android-review.googlesource.com/c/platform/frameworks/av/+/1368918/3
I'd like AOSP to not use ION after September (though being external I can't promise anything), much less continuing after December.
I want this migration to happen as much as anyone. But I'd prefer to keep ION in staging until after the LTS is announced. Having both around helps development for the transition, which helps us have a reliable solution, which helps vendors to migrate and be able to do comparative performance testing.
I do appreciate that keeping it isn't free, but I also don't feel the chaos-monkey approach here is really motivational in the way you intend.
thanks
-john
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Greg Kroah-Hartman
maintainerQuoted 11 lines · John Stultz
Quoted 9 lines · Greg Kroah-Hartman
Quoted 7 lines · Amit Pundir
I don't know what is the right thing to do here. I just want to highlight that AOSP's audio (codec2) HAL depends on the ION system heap and it will break AOSP for people who boot mainline on their devices, even for just testing purpose like we do in Linaro. Right now we need only 1 (Android specific out-of-tree) patch to boot AOSP with mainline and Sumit is already trying to upstream that vma naming patch. Removal of in-kernel ION, will just add more to that delta.
Quoted 7 lines
Quoted 5 lines
As AOSP will continue to rely on ION after December of this year, all you are doing is postponing the inevitable a few more months.
Push back on the Android team to fix up the code to not use ION, they know this needs to happen.
The point though, is your main premise that no one is using this isn't true.
They are using the version of ion in the Android kernel tree, yes, as it has new features that many people are relying on.
The version that is currently in the kernel tree is crippled, and maybe works for some use cases, but not the majority, right?
Quoted 6 lines
I'm actively working with Hridya and folks on the codec2 HAL side to transition this on the userland side:
https://android-review.googlesource.com/c/platform/frameworks/av/+/1368918/3I'd like AOSP to not use ION after September (though being external I can't promise anything), much less continuing after December.
The android team has said they will be dropping ION use for the "next" Android release, which is sometime next year from what I recall. December is probably not going to happen :)
Quoted 5 lines
I want this migration to happen as much as anyone. But I'd prefer to keep ION in staging until after the LTS is announced. Having both around helps development for the transition, which helps us have a reliable solution, which helps vendors to migrate and be able to do comparative performance testing.
I don't understand what having this in the "next" kernel helps us with here. And I would really really prefer to NOT have an outdated version of this code in a kernel tree that I am going to have to support for the next X number of years, when no one is using that version of the driver.
What is this LTS fixation to keep this code around for? Who does it help?
Quoted 3 lines
I do appreciate that keeping it isn't free, but I also don't feel the chaos-monkey approach here is really motivational in the way you intend.
I don't see it helping anyone to leave this around, except to cause merge issues for me, and development issues for other developers.
Anyone who really wants this code, can easily revert the deletion and move on and grab the AOSP copy of the code. That's what they did when we deleted other Android features that are still relied on.
Given that the "isn't free" is causing _me_ real pain, and not the actual users of this code, I am leaning toward wanting to move that pain/cost to those users, for obvious reasons.
thanks,
greg k-h
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 19 lines · Greg Kroah-Hartman
Quoted 17 lines · John Stultz
Quoted 14 lines · Greg Kroah-Hartman
Quoted 7 lines · Amit Pundir
I don't know what is the right thing to do here. I just want to highlight that AOSP's audio (codec2) HAL depends on the ION system heap and it will break AOSP for people who boot mainline on their devices, even for just testing purpose like we do in Linaro. Right now we need only 1 (Android specific out-of-tree) patch to boot AOSP with mainline and Sumit is already trying to upstream that vma naming patch. Removal of in-kernel ION, will just add more to that delta.
As AOSP will continue to rely on ION after December of this year, all you are doing is postponing the inevitable a few more months.
Push back on the Android team to fix up the code to not use ION, they know this needs to happen.
Quoted 7 lines
Quoted 1 line
The point though, is your main premise that no one is using this isn't true.
They are using the version of ion in the Android kernel tree, yes, as it has new features that many people are relying on.
The version that is currently in the kernel tree is crippled, and maybe works for some use cases, but not the majority, right?
So my understanding is the Android Common Kernel tree version was mostly reworked to allow heaps as modules, and allowed heaps to have their own exporter logic (not unlike how dmabuf heaps do it). The main allocation interface is maybe slightly tweaked for out-of-tree vendor heaps, but doesn't affect the in-staging heaps. There's also a few optimizations we have skipped taking upstream. So yes, there are differences, but I don't feel your characterization is quite accurate.
Quoted 10 lines
Quoted 6 lines
I'm actively working with Hridya and folks on the codec2 HAL side to transition this on the userland side:
https://android-review.googlesource.com/c/platform/frameworks/av/+/1368918/3I'd like AOSP to not use ION after September (though being external I can't promise anything), much less continuing after December.
The android team has said they will be dropping ION use for the "next" Android release, which is sometime next year from what I recall. December is probably not going to happen :)
AOSP is what the next Android release forks off of, so it needs to be fixed first.
Quoted 6 lines
Quoted 5 lines
I want this migration to happen as much as anyone. But I'd prefer to keep ION in staging until after the LTS is announced. Having both around helps development for the transition, which helps us have a reliable solution, which helps vendors to migrate and be able to do comparative performance testing.
Quoted 7 lines
I don't understand what having this in the "next" kernel helps us with here. And I would really really prefer to NOT have an outdated version of this code in a kernel tree that I am going to have to support for the next X number of years, when no one is using that version of the driver.
What is this LTS fixation to keep this code around for? Who does it help?
Vendors usually target LTS releases for their hardware bringups. Having a LTS release with both ION and DMA BUF Heaps helps them validate their old ION solution as performant, and then migrate to DMA BUF Heaps and be able to do performance comparisons holding all other things equal.
Quoted 7 lines
Quoted 3 lines
I do appreciate that keeping it isn't free, but I also don't feel the chaos-monkey approach here is really motivational in the way you intend.
I don't see it helping anyone to leave this around, except to cause merge issues for me, and development issues for other developers.
Quoted 7 lines
Anyone who really wants this code, can easily revert the deletion and move on and grab the AOSP copy of the code. That's what they did when we deleted other Android features that are still relied on.
Given that the "isn't free" is causing _me_ real pain, and not the actual users of this code, I am leaning toward wanting to move that pain/cost to those users, for obvious reasons.
Sure. Again, I do understand the desire to remove it, and it's your right to do so. Keeping the code for an extra year in LTS (over 5.4) is a cost, so I understand if you drop it. But I'll ask that you make that judgement clear as the main motivator/rationale of the commit message, rather than flippantly pretending it's not being used, and that everyone agrees it has no usefulness to keep around (especially after we've had this conversation a few times already this year).
thanks
-john
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Greg Kroah-Hartman
maintainerQuoted 37 lines · Laura Abbott
Quoted 27 lines · Greg Kroah-Hartman
The ION android code has long been marked to be removed, now that we dma-buf support merged into the real part of the kernel.
It was thought that we could wait to remove the ion kernel at a later time, but as the out-of-tree Android fork of the ion code has diverged quite a bit, and any Android device using the ion interface uses that forked version and not this in-tree version, the in-tree copy of the code is abandonded and not used by anyone.
Combine this abandoned codebase with the need to make changes to it in order to keep the kernel building properly, which then causes merge issues when merging those changes into the out-of-tree Android code, and you end up with two different groups of people (the in-kernel-tree developers, and the Android kernel developers) who are both annoyed at the current situation. Because of this problem, just drop the in-kernel copy of the ion code now, as it's not used, and is only causing problems for everyone involved.
Cc "Arve Hjønnevåg" <[email protected]>Cc "Christian König" <[email protected]>Cc Christian Brauner <[email protected]>Cc Christoph Hellwig <[email protected]>Cc Hridya Valsaraju <[email protected]>Cc Joel Fernandes <[email protected]>Cc John Stultz <[email protected]>Cc Laura Abbott <[email protected]>Cc Martijn Coenen <[email protected]>Quoted 8 lines
Cc Shuah Khan <[email protected]>Cc Sumit Semwal <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Todd Kjos <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 2 lines
We discussed this at the Android MC on Monday and the plan was to remove it after the next LTS release.
As 5.10 will be the next LTS release, I have now merged it to my "testing" branch to go into 5.11-rc1.
thanks,
greg k-h
Quoted 39 lines · Greg Kroah-Hartman
Quoted 37 lines · Laura Abbott
Quoted 35 lines · Greg Kroah-Hartman
The ION android code has long been marked to be removed, now that we dma-buf support merged into the real part of the kernel.
It was thought that we could wait to remove the ion kernel at a later time, but as the out-of-tree Android fork of the ion code has diverged quite a bit, and any Android device using the ion interface uses that forked version and not this in-tree version, the in-tree copy of the code is abandonded and not used by anyone.
Combine this abandoned codebase with the need to make changes to it in order to keep the kernel building properly, which then causes merge issues when merging those changes into the out-of-tree Android code, and you end up with two different groups of people (the in-kernel-tree developers, and the Android kernel developers) who are both annoyed at the current situation. Because of this problem, just drop the in-kernel copy of the ion code now, as it's not used, and is only causing problems for everyone involved.
Cc "Arve Hjønnevåg" <[email protected]>Cc "Christian König" <[email protected]>Cc Christian Brauner <[email protected]>Cc Christoph Hellwig <[email protected]>Cc Hridya Valsaraju <[email protected]>Cc Joel Fernandes <[email protected]>Cc John Stultz <[email protected]>Cc Laura Abbott <[email protected]>Cc Martijn Coenen <[email protected]>Cc Shuah Khan <[email protected]>Cc Sumit Semwal <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Todd Kjos <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 5 lines
Quoted 2 lines
We discussed this at the Android MC on Monday and the plan was to remove it after the next LTS release.
As 5.10 will be the next LTS release, I have now merged it to my "testing" branch to go into 5.11-rc1.
Sounds great! Thanks so much for waiting a bit on this, I really appreciate it! -john
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 82 lines · Greg Kroah-Hartman
The ION android code has long been marked to be removed, now that we dma-buf support merged into the real part of the kernel.
It was thought that we could wait to remove the ion kernel at a later time, but as the out-of-tree Android fork of the ion code has diverged quite a bit, and any Android device using the ion interface uses that forked version and not this in-tree version, the in-tree copy of the code is abandonded and not used by anyone.
Combine this abandoned codebase with the need to make changes to it in order to keep the kernel building properly, which then causes merge issues when merging those changes into the out-of-tree Android code, and you end up with two different groups of people (the in-kernel-tree developers, and the Android kernel developers) who are both annoyed at the current situation. Because of this problem, just drop the in-kernel copy of the ion code now, as it's not used, and is only causing problems for everyone involved.
Cc "Arve Hjønnevåg" <[email protected]>Cc "Christian König" <[email protected]>Cc Christian Brauner <[email protected]>Cc Christoph Hellwig <[email protected]>Cc Hridya Valsaraju <[email protected]>Cc Joel Fernandes <[email protected]>Cc John Stultz <[email protected]>Cc Laura Abbott <[email protected]>Cc Martijn Coenen <[email protected]>Cc Shuah Khan <[email protected]>Cc Sumit Semwal <[email protected]>Cc Suren Baghdasaryan <[email protected]>Cc Todd Kjos <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- MAINTAINERS | 10 - drivers/staging/android/Kconfig | 2 - drivers/staging/android/Makefile | 2 - drivers/staging/android/TODO | 5 - drivers/staging/android/ion/Kconfig | 27 - drivers/staging/android/ion/Makefile | 4 - drivers/staging/android/ion/ion.c | 649 ------------------ drivers/staging/android/ion/ion.h | 302 -------- drivers/staging/android/ion/ion_cma_heap.c | 138 ---- drivers/staging/android/ion/ion_heap.c | 286 -------- drivers/staging/android/ion/ion_page_pool.c | 155 ----- drivers/staging/android/ion/ion_system_heap.c | 377 ---------- drivers/staging/android/uapi/ion.h | 127 ---- tools/testing/selftests/Makefile | 3 +- tools/testing/selftests/android/Makefile | 39 -- tools/testing/selftests/android/config | 5 - .../testing/selftests/android/ion/.gitignore | 4 - tools/testing/selftests/android/ion/Makefile | 20 - tools/testing/selftests/android/ion/README | 101 --- tools/testing/selftests/android/ion/ion.h | 134 ---- .../testing/selftests/android/ion/ion_test.sh | 58 -- .../selftests/android/ion/ionapp_export.c | 127 ---- .../selftests/android/ion/ionapp_import.c | 79 --- .../selftests/android/ion/ionmap_test.c | 136 ---- .../testing/selftests/android/ion/ionutils.c | 253 ------- .../testing/selftests/android/ion/ionutils.h | 55 -- .../testing/selftests/android/ion/ipcsocket.c | 227 ------ .../testing/selftests/android/ion/ipcsocket.h | 35 - tools/testing/selftests/android/run.sh | 3 - 29 files changed, 1 insertion(+), 3362 deletions(-)delete mode 100644
drivers/staging/android/ion/Kconfigdelete mode 100644drivers/staging/android/ion/Makefiledelete mode 100644drivers/staging/android/ion/ion.cdelete mode 100644drivers/staging/android/ion/ion.hdelete mode 100644drivers/staging/android/ion/ion_cma_heap.cdelete mode 100644drivers/staging/android/ion/ion_heap.cdelete mode 100644drivers/staging/android/ion/ion_page_pool.cdelete mode 100644drivers/staging/android/ion/ion_system_heap.cdelete mode 100644drivers/staging/android/uapi/ion.hdelete mode 100644tools/testing/selftests/android/Makefiledelete mode 100644tools/testing/selftests/android/configdelete mode 100644tools/testing/selftests/android/ion/.gitignoredelete mode 100644tools/testing/selftests/android/ion/Makefiledelete mode 100644tools/testing/selftests/android/ion/READMEdelete mode 100644tools/testing/selftests/android/ion/ion.hdelete mode 100755tools/testing/selftests/android/ion/ion_test.sh
Quoted 10 lines
delete mode 100644
tools/testing/selftests/android/ion/ionapp_export.cdelete mode 100644tools/testing/selftests/android/ion/ionapp_import.cdelete mode 100644tools/testing/selftests/android/ion/ionmap_test.cdelete mode 100644tools/testing/selftests/android/ion/ionutils.cdelete mode 100644tools/testing/selftests/android/ion/ionutils.hdelete mode 100644tools/testing/selftests/android/ion/ipcsocket.cdelete mode 100644tools/testing/selftests/android/ion/ipcsocket.hdelete mode 100755tools/testing/selftests/android/run.sh
For selftest changes in this patch:
thanks,
-- Shuah