Skip to contentSkip to conversation

package/pipewire: bump to version 0.3.6

PATCH New James Hilliard 3 participants 5 messages Jul 6, 2020 – Apr 25, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/pipewire: bump to version 0.3.6

Add pipewire optional dependencies/configurations.

Remove BR2_PACKAGE_PIPEWIRE_GSTREAMER config option and enable automatically based on dependencies to avoid recursive dependency error caused by the gobject-introspection python3 dependency.

---
 Config.in.legacy               |  10 +++
 package/pipewire/Config.in     |  27 +-------
 package/pipewire/pipewire.hash |   6 +-
 package/pipewire/pipewire.mk   | 114 +++++++++++++++++++++++++++------
 4 files changed, 110 insertions(+), 47 deletions(-)
Config.in.legacy +10 -0
index 7a5435188b..4541acc979 100644
@@ -146,6 +146,16 @@ endif
 
 comment "Legacy options removed in 2020.08"
 
+config BR2_PACKAGE_PIPEWIRE_GSTREAMER
+	bool "pipewire gstreamer option removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_GOBJECT_INTROSPECTION
+	select BR2_PACKAGE_GSTREAMER1
+	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	help
+	  This option is now automatically selected when the required
+	  dependencies are present.
+
 config BR2_BINUTILS_VERSION_2_31_X
 	bool "binutils version 2.31.1 support removed"
 	select BR2_LEGACY
package/pipewire/Config.in +3 -24
index 57e70d65f8..9b8416e27a 100644
@@ -1,9 +1,7 @@
 config BR2_PACKAGE_PIPEWIRE
 	bool "pipewire"
-	depends on BR2_PACKAGE_HAS_UDEV # libudev
-	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, alsa-lib
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus
 	depends on BR2_USE_MMU # dbus
-	select BR2_PACKAGE_ALSA_LIB
 	select BR2_PACKAGE_DBUS
 	help
 	  PipeWire is a server and user space API to deal with
@@ -11,25 +9,6 @@ config BR2_PACKAGE_PIPEWIRE
 
 	  https://pipewire.org/
 
-if BR2_PACKAGE_PIPEWIRE
-
-config BR2_PACKAGE_PIPEWIRE_GSTREAMER
-	bool "pipewire gstreamer plugins"
-	depends on BR2_USE_WCHAR # libglib2
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
-	depends on BR2_USE_MMU # libglib2
-	select BR2_PACKAGE_LIBGLIB2
-	select BR2_PACKAGE_GSTREAMER1
-	select BR2_PACKAGE_GST1_PLUGINS_BASE
-	help
-	  Build GStreamer plugins
-
-comment "pipewire gstreamer support needs a toolchain w/ wchar, threads"
-	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
-
-endif
-
-comment "pipewire needs udev and a toolchain w/ threads"
+comment "pipewire needs a toolchain w/ threads"
 	depends on BR2_USE_MMU
-	depends on !BR2_PACKAGE_HAS_UDEV || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/pipewire/pipewire.hash +3 -3
index 81c53867e2..bce319dda7 100644
@@ -1,4 +1,4 @@
 # Locally calculated
-sha256 bfaa0f6ae6c0791e2e0b59234d399753bf24f1b33dbf587682363a8463dd8df1  pipewire-0.2.7.tar.gz
-sha256 88c0ca786c735a11e0eb508196d3aa1389fbaacb8d5de9adb5ccb15bcd4009d9  LICENSE
-sha256 a9bdde5616ecdd1e980b44f360600ee8783b1f99b8cc83a2beb163a0a390e861  LGPL
+sha256  927301640f87d68e52f4480667977bc6f47186ee7877f7aa86ce9172ff144edc  pipewire-0.3.6.tar.gz
+sha256  8909c319a7e27dbb33a15b9035f89ab3b7b2f6a12f8bcddc755206a8db1ada44  COPYING
+sha256  7db6138b0385e260ae8f09f050ea66c4e4fe775a11060d7f6ca2beb47f192d6f  LICENSE
package/pipewire/pipewire.mk +94 -20

139 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/pipewire: bump to version 0.3.6

Quoted 5 lines · On Sun, 5 Jul 2020 19:04:44 -0600 James Hilliard <[email protected]>…

Add pipewire optional dependencies/configurations.

Remove BR2_PACKAGE_PIPEWIRE_GSTREAMER config option and enable automatically based on dependencies to avoid recursive dependency error caused by the gobject-introspection python3 dependency.

Could you give more details about this recursive dependency ?

Quoted 14 lines
---
 Config.in.legacy               |  10 +++
 package/pipewire/Config.in     |  27 +-------
 package/pipewire/pipewire.hash |   6 +-
 package/pipewire/pipewire.mk   | 114 +++++++++++++++++++++++++++------
 4 files changed, 110 insertions(+), 47 deletions(-)
Config.in.legacy +0 -0
index 7a5435188b..4541acc979 100644

Config.in.legacy endif · line 154

Quoted 9 lines
Config.in.legacy +6 -0
@@ -146,6 +146,16 @@ endif
 
 comment "Legacy options removed in 2020.08"
 
+config BR2_PACKAGE_PIPEWIRE_GSTREAMER
+	bool "pipewire gstreamer option removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_GOBJECT_INTROSPECTION
+	select BR2_PACKAGE_GSTREAMER1
+	select BR2_PACKAGE_GST1_PLUGINS_BASE

But isn't that going to cause that circular dependency you're trying to prevent, since you're selecting BR2_PACKAGE_GOBJECT_INTROSPECTION here ?

Or maybe what you're talking about is not a Kconfig recursive dependency, but a makefile circular dependency ? But in the later case, I'm not sure how dropping the Config.in option helps.

Could you clarify ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/pipewire: bump to version 0.3.6

Quoted 29 lines · Thomas Petazzoni
Quoted 5 lines · On Sun, 5 Jul 2020 19:04:44 -0600 James Hilliard <[email protected]>…

Add pipewire optional dependencies/configurations.

Remove BR2_PACKAGE_PIPEWIRE_GSTREAMER config option and enable automatically based on dependencies to avoid recursive dependency error caused by the gobject-introspection python3 dependency.

Could you give more details about this recursive dependency ?

Quoted 17 lines
---
 Config.in.legacy               |  10 +++
 package/pipewire/Config.in     |  27 +-------
 package/pipewire/pipewire.hash |   6 +-
 package/pipewire/pipewire.mk   | 114 +++++++++++++++++++++++++++------
 4 files changed, 110 insertions(+), 47 deletions(-)
Config.in.legacy +0 -0
index 7a5435188b..4541acc979 100644
@@ -146,6 +146,16 @@ endif
 
 comment "Legacy options removed in 2020.08"
 
Quoted 9 lines

Config.in.legacy endif · line 154

Quoted 6 lines
Config.in.legacy +6 -0
+config BR2_PACKAGE_PIPEWIRE_GSTREAMER
+     bool "pipewire gstreamer option removed"
+     select BR2_LEGACY
+     select BR2_PACKAGE_GOBJECT_INTROSPECTION
+     select BR2_PACKAGE_GSTREAMER1
+     select BR2_PACKAGE_GST1_PLUGINS_BASE

But isn't that going to cause that circular dependency you're trying to prevent, since you're selecting BR2_PACKAGE_GOBJECT_INTROSPECTION here ?

Looks to be related to a conflict involving these:
https://github.com/buildroot/buildroot/blob/master/package/python-gobject/Config.in
https://github.com/buildroot/buildroot/blob/master/package/gstreamer1/gst1-python/Config.in

Quoted 14 lines

Or maybe what you're talking about is not a Kconfig recursive dependency, but a makefile circular dependency ? But in the later case, I'm not sure how dropping the Config.in option helps.

Could you clarify ?

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#3 lore raw

PATCH 1/1 package/pipewire: bump to version 0.3.6

James, All,

Sorry to come back so late on that one...

On 2020-10-15 23:50 -0600, James Hilliard spake thusly:

Quoted 10 lines
Quoted 8 lines · Thomas Petazzoni
Quoted 5 lines · On Sun, 5 Jul 2020 19:04:44 -0600 James Hilliard <[email protected]>…

Add pipewire optional dependencies/configurations.

Remove BR2_PACKAGE_PIPEWIRE_GSTREAMER config option and enable automatically based on dependencies to avoid recursive dependency error caused by the gobject-introspection python3 dependency.

Could you give more details about this recursive dependency ?

[--SNIP--]

Quoted 17 lines
Quoted 8 lines
Quoted 8 lines
Config.in.legacy +0 -0
index 7a5435188b..4541acc979 100644
@@ -146,6 +146,16 @@ endif
 
 comment "Legacy options removed in 2020.08"
 
Quoted 9 lines

Config.in.legacy endif · line 154

Quoted 6 lines
Config.in.legacy +6 -0
+config BR2_PACKAGE_PIPEWIRE_GSTREAMER
+     bool "pipewire gstreamer option removed"
+     select BR2_LEGACY
+     select BR2_PACKAGE_GOBJECT_INTROSPECTION
+     select BR2_PACKAGE_GSTREAMER1
+     select BR2_PACKAGE_GST1_PLUGINS_BASE

But isn't that going to cause that circular dependency you're trying to prevent, since you're selecting BR2_PACKAGE_GOBJECT_INTROSPECTION here ?

Quoted 3 lines

Looks to be related to a conflict involving these:
https://github.com/buildroot/buildroot/blob/master/package/python-gobject/Config.in
https://github.com/buildroot/buildroot/blob/master/package/gstreamer1/gst1-python/Config.in

Sorry, but this answer is too terse to try and understand the issue... :-( In the meantime, pipewire has had new releases.

To ease acceptance, could you split the patch in a small series:

1. a first patch that drops the option and relies on pacjages being enabled

2. a bump still keeping v4l2 mandatory, and disabling all new features that have dependencies

3. a new option for enabling v4l2 support

4. as many patches as needed to add new options for new optional features that have dependencies

This should make for simpler patches, easier to review.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 package/pipewire: bump to version 0.3.6

James, All,

On 2021-04-25 21:52 +0200, Yann E. MORIN spake thusly:

Quoted 5 lines

On 2020-10-15 23:50 -0600, James Hilliard spake thusly:

Quoted 4 lines
Quoted 2 lines · Thomas Petazzoni

On Sun, 5 Jul 2020 19:04:44 -0600
James Hilliard <[email protected]> wrote:

[--SNIP--]

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

Config.in.legacy endif · line 154

Quoted 6 lines
Config.in.legacy +6 -0
+config BR2_PACKAGE_PIPEWIRE_GSTREAMER
+     bool "pipewire gstreamer option removed"
+     select BR2_LEGACY
+     select BR2_PACKAGE_GOBJECT_INTROSPECTION
+     select BR2_PACKAGE_GSTREAMER1
+     select BR2_PACKAGE_GST1_PLUGINS_BASE

But isn't that going to cause that circular dependency you're trying to prevent, since you're selecting BR2_PACKAGE_GOBJECT_INTROSPECTION here ?

Quoted 8 lines
Quoted 3 lines

Looks to be related to a conflict involving these:
https://github.com/buildroot/buildroot/blob/master/package/python-gobject/Config.in
https://github.com/buildroot/buildroot/blob/master/package/gstreamer1/gst1-python/Config.in

Sorry, but this answer is too terse to try and understand the issue... :-( In the meantime, pipewire has had new releases.

To ease acceptance, could you split the patch in a small series:

0. backport the two weston upstream fixes to support building against

    pipewire 0.3.x
Quoted 6 lines

1. a first patch that drops the option and relies on pacjages being enabled

2. a bump still keeping v4l2 mandatory, and disabling all new features that have dependencies

Quoted 6 lines

3. a new option for enabling v4l2 support

4. as many patches as needed to add new options for new optional features that have dependencies

This should make for simpler patches, easier to review.

Regards,
Yann E. MORIN.

Quoted 14 lines

Regards,
Yann E. MORIN.

Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'