hinic: add debugfs support
Subsystems (3)
v2 cover hinic: add debugfs support
add debugfs node for querying sq/rq info and function table
Luo bin (3):
hinic: add support to query sq info
hinic: add support to query rq info
hinic: add support to query function table
drivers/net/ethernet/huawei/hinic/Makefile | 3 +- .../net/ethernet/huawei/hinic/hinic_debugfs.c | 318 ++++++++++++++++++ .../net/ethernet/huawei/hinic/hinic_debugfs.h | 114 +++++++ drivers/net/ethernet/huawei/hinic/hinic_dev.h | 20 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 1 + .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 2 + .../net/ethernet/huawei/hinic/hinic_hw_io.c | 2 + .../net/ethernet/huawei/hinic/hinic_hw_io.h | 1 + .../net/ethernet/huawei/hinic/hinic_hw_qp.h | 6 + .../net/ethernet/huawei/hinic/hinic_main.c | 83 ++++- 10 files changed, 544 insertions(+), 6 deletions(-) create mode 100644 drivers/net/ethernet/huawei/hinic/hinic_debugfs.c create mode 100644 drivers/net/ethernet/huawei/hinic/hinic_debugfs.h
Signature · 1 line
2.17.1
PATCH v2 1/3 hinic: add support to query sq info
add debugfs node for querying sq info, for example:
cat /sys/kernel/debug/hinic/0000:15:00.0/SQs/0x0/sq_pi
---
V0~V1:
- remove command interfaces to the read only files
- split addition of each object into a separate patch
drivers/net/ethernet/huawei/hinic/Makefile | 3 +- .../net/ethernet/huawei/hinic/hinic_debugfs.c | 162 ++++++++++++++++++ .../net/ethernet/huawei/hinic/hinic_debugfs.h | 27 +++ drivers/net/ethernet/huawei/hinic/hinic_dev.h | 15 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 1 + .../net/ethernet/huawei/hinic/hinic_hw_io.c | 1 + .../net/ethernet/huawei/hinic/hinic_hw_io.h | 1 + .../net/ethernet/huawei/hinic/hinic_hw_qp.h | 3 + .../net/ethernet/huawei/hinic/hinic_main.c | 45 ++++- 9 files changed, 254 insertions(+), 4 deletions(-) create mode 100644 drivers/net/ethernet/huawei/hinic/hinic_debugfs.c create mode 100644 drivers/net/ethernet/huawei/hinic/hinic_debugfs.h
drivers/net/ethernet/huawei/hinic/Makefile +2 -1
@@ -4,4 +4,5 @@ obj-$(CONFIG_HINIC) += hinic.o hinic-y := hinic_main.o hinic_tx.o hinic_rx.o hinic_port.o hinic_hw_dev.o \ hinic_hw_io.o hinic_hw_qp.o hinic_hw_cmdq.o hinic_hw_wq.o \ hinic_hw_mgmt.o hinic_hw_api_cmd.o hinic_hw_eqs.o hinic_hw_if.o \ - hinic_common.o hinic_ethtool.o hinic_devlink.o hinic_hw_mbox.o hinic_sriov.o + hinic_common.o hinic_ethtool.o hinic_devlink.o hinic_hw_mbox.o \ + hinic_sriov.o hinic_debugfs.o
drivers/net/ethernet/huawei/hinic/hinic_debugfs.c new file +162 -0
162 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic/hinic_debugfs.h new file +27 -0
@@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* Huawei HiNIC PCI Express Linux driver +* Copyright(c) 2017 Huawei Technologies Co., Ltd +*/ + +#ifndef HINIC_DEBUGFS_H +#define HINIC_DEBUGFS_H + +#include "hinic_dev.h" + +int hinic_sq_debug_add (struct hinic_dev *dev,u16 sq_id); + +void hinic_sq_debug_rem (struct hinic_sq *sq); + +void hinic_sq_dbgfs_init (struct hinic_dev *nic_dev); + +void hinic_sq_dbgfs_uninit (struct hinic_dev *nic_dev); + +void hinic_dbg_init (struct hinic_dev *nic_dev); + +void hinic_dbg_uninit (struct hinic_dev *nic_dev); + +void hinic_dbg_register_debugfs (const char *debugfs_dir_name); + +void hinic_dbg_unregister_debugfs (void ); + +#endif
drivers/net/ethernet/huawei/hinic/hinic_dev.h +15 -0
@@ -58,6 +58,18 @@ struct hinic_intr_coal_info {u8 resend_timer_cfg; }; +enum hinic_dbg_type { +HINIC_DBG_SQ_INFO , +}; + +struct hinic_debug_priv { +struct hinic_dev *dev; +void *object; +enum hinic_dbg_type type; +struct dentry *root; +int field_id[64 ]; +}; +struct hinic_dev {struct net_device *netdev;struct hinic_hwdev *hwdev;
@@ -97,6 +109,9 @@ struct hinic_dev {int lb_test_rx_idx;int lb_pkt_len;u8 *lb_test_rx_buf; + +struct dentry *dbgfs_root; +struct dentry *sq_dbgfs;struct devlink *devlink;bool cable_unplugged;bool module_unrecognized;
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c +1 -0
@@ -465,6 +465,7 @@ int hinic_hwdev_ifup(struct hinic_hwdev *hwdev, u16 sq_depth, u16 rq_depth) func_to_io->hwdev = hwdev; func_to_io->sq_depth = sq_depth; func_to_io->rq_depth = rq_depth; + func_to_io->global_qpn = base_qpn; err =hinic_io_init (func_to_io, hwif, nic_cap->max_qps, num_ceqs, ceq_msix_entries);
drivers/net/ethernet/huawei/hinic/hinic_hw_io.c +1 -0
@@ -305,6 +305,7 @@ static int init_qp(struct hinic_func_to_io *func_to_io, func_to_io->sq_db[q_id] = db_base; + qp->sq.qid = q_id; err = hinic_init_sq(&qp->sq, hwif, &func_to_io->sq_wq[q_id], sq_msix_entry, CI_ADDR(func_to_io->ci_addr_base, q_id),
drivers/net/ethernet/huawei/hinic/hinic_hw_io.h +1 -0
@@ -59,6 +59,7 @@ struct hinic_nic_cfg {struct hinic_func_to_io {struct hinic_hwif *hwif;struct hinic_hwdev *hwdev; +u16 global_qpn;struct hinic_ceqs ceqs;struct hinic_wqs wqs;
drivers/net/ethernet/huawei/hinic/hinic_hw_qp.h +3 -0
@@ -81,6 +81,8 @@ struct hinic_sq {struct hinic_wq *wq; +u16 qid; +u32 irq;u16 msix_entry;
@@ -90,6 +92,7 @@ struct hinic_sq {void __iomem *db_base;struct sk_buff **saved_skb; +struct hinic_debug_priv *dbg; };struct hinic_rq {
drivers/net/ethernet/huawei/hinic/hinic_main.c +42 -3
97 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH v2 2/3 hinic: add support to query rq info
In reply to Luo binadd debugfs node for querying rq info, for example:
cat /sys/kernel/debug/hinic/0000:15:00.0/RQs/0x0/rq_hw_pi
---
V0~V1:
- remove command interfaces to the read only files
- split addition of each object into a separate patch
.../net/ethernet/huawei/hinic/hinic_debugfs.c | 66 +++++++++++++++++++ .../net/ethernet/huawei/hinic/hinic_debugfs.h | 8 +++ drivers/net/ethernet/huawei/hinic/hinic_dev.h | 2 + .../net/ethernet/huawei/hinic/hinic_hw_io.c | 1 + .../net/ethernet/huawei/hinic/hinic_hw_qp.h | 3 + .../net/ethernet/huawei/hinic/hinic_main.c | 23 ++++++- 6 files changed, 101 insertions(+), 2 deletions(-)
drivers/net/ethernet/huawei/hinic/hinic_debugfs.c +66 -0
@@ -40,6 +40,36 @@ static u64 hinic_dbg_get_sq_info(struct hinic_dev *nic_dev, struct hinic_sq *sq,return 0 ; } +enum rq_dbg_info { +GLB_RQ_ID , +RQ_HW_PI , +RQ_SW_CI , +RQ_SW_PI , +RQ_MSIX_ENTRY , +}; + +static char *rq_fields[] = {"glb_rq_id" ,"rq_hw_pi" ,"rq_sw_ci" ,"rq_sw_pi" ,"rq_msix_entry" }; + +static u64 hinic_dbg_get_rq_info (struct hinic_dev *nic_dev,struct hinic_rq *rq,int idx) +{ +struct hinic_wq *wq = rq->wq; + +switch (idx) { +case GLB_RQ_ID : +return nic_dev->hwdev->func_to_io.global_qpn + rq->qid; +case RQ_HW_PI : +return be16_to_cpu (*(__be16 *)(rq->pi_virt_addr)) & wq->mask; +case RQ_SW_CI : +return atomic_read (&wq->cons_idx) & wq->mask; +case RQ_SW_PI : +return atomic_read (&wq->prod_idx) & wq->mask; +case RQ_MSIX_ENTRY : +return rq->msix_entry; + } + +return 0 ; +} +static ssize_t hinic_dbg_cmd_read (struct file *filp,char __user *buffer,size_t count,loff_t *ppos) {
@@ -57,6 +87,10 @@ static ssize_t hinic_dbg_cmd_read(struct file *filp, char __user *buffer, size_t out =hinic_dbg_get_sq_info (dbg->dev, dbg->object, *desc);break ; +case HINIC_DBG_RQ_INFO : + out =hinic_dbg_get_rq_info (dbg->dev, dbg->object, *desc); +break ; +default :netif_warn (dbg->dev, drv, dbg->dev->netdev,"Invalid hinic debug cmd: %d\n" , dbg->type);
@@ -128,6 +162,28 @@ void hinic_sq_debug_rem(struct hinic_sq *sq)rem_dbg_files (sq->dbg); } +int hinic_rq_debug_add (struct hinic_dev *dev,u16 rq_id) +{ +struct hinic_rq *rq; +struct dentry *root; +char sub_dir[16 ]; + + rq = dev->rxqs[rq_id].rq; + +sprintf (sub_dir,"0x%x" , rq_id); + + root =debugfs_create_dir (sub_dir, dev->rq_dbgfs); + +return create_dbg_files (dev,HINIC_DBG_RQ_INFO , rq, root, &rq->dbg, rq_fields, +ARRAY_SIZE (rq_fields)); +} + +void hinic_rq_debug_rem (struct hinic_rq *rq) +{ +if (rq->dbg) +rem_dbg_files (rq->dbg); +} +void hinic_sq_dbgfs_init (struct hinic_dev *nic_dev) { nic_dev->sq_dbgfs =debugfs_create_dir ("SQs" , nic_dev->dbgfs_root);
@@ -138,6 +194,16 @@ void hinic_sq_dbgfs_uninit(struct hinic_dev *nic_dev)debugfs_remove_recursive (nic_dev->sq_dbgfs); } +void hinic_rq_dbgfs_init (struct hinic_dev *nic_dev) +{ + nic_dev->rq_dbgfs =debugfs_create_dir ("RQs" , nic_dev->dbgfs_root); +} + +void hinic_rq_dbgfs_uninit (struct hinic_dev *nic_dev) +{ +debugfs_remove_recursive (nic_dev->rq_dbgfs); +} +void hinic_dbg_init (struct hinic_dev *nic_dev) { nic_dev->dbgfs_root = debugfs_create_dir(pci_name(nic_dev->hwdev->hwif->pdev),
drivers/net/ethernet/huawei/hinic/hinic_debugfs.h +8 -0
@@ -12,10 +12,18 @@ int hinic_sq_debug_add(struct hinic_dev *dev, u16 sq_id);void hinic_sq_debug_rem (struct hinic_sq *sq); +int hinic_rq_debug_add (struct hinic_dev *dev,u16 rq_id); + +void hinic_rq_debug_rem (struct hinic_rq *rq); +void hinic_sq_dbgfs_init (struct hinic_dev *nic_dev);void hinic_sq_dbgfs_uninit (struct hinic_dev *nic_dev); +void hinic_rq_dbgfs_init (struct hinic_dev *nic_dev); + +void hinic_rq_dbgfs_uninit (struct hinic_dev *nic_dev); +void hinic_dbg_init (struct hinic_dev *nic_dev);void hinic_dbg_uninit (struct hinic_dev *nic_dev);
drivers/net/ethernet/huawei/hinic/hinic_dev.h +2 -0
@@ -60,6 +60,7 @@ struct hinic_intr_coal_info {enum hinic_dbg_type {HINIC_DBG_SQ_INFO , +HINIC_DBG_RQ_INFO , };struct hinic_debug_priv {
@@ -112,6 +113,7 @@ struct hinic_dev {struct dentry *dbgfs_root;struct dentry *sq_dbgfs; +struct dentry *rq_dbgfs;struct devlink *devlink;bool cable_unplugged;bool module_unrecognized;
drivers/net/ethernet/huawei/hinic/hinic_hw_io.c +1 -0
@@ -315,6 +315,7 @@ static int init_qp(struct hinic_func_to_io *func_to_io, goto err_sq_init; } + qp->rq.qid = q_id; err =hinic_init_rq (&qp->rq, hwif, &func_to_io->rq_wq[q_id], rq_msix_entry);if (err) {
drivers/net/ethernet/huawei/hinic/hinic_hw_qp.h +3 -0
@@ -100,6 +100,8 @@ struct hinic_rq {struct hinic_wq *wq; +u16 qid; +struct cpumask affinity_mask;u32 irq;u16 msix_entry;
@@ -113,6 +115,7 @@ struct hinic_rq {u16 *pi_virt_addr;dma_addr_t pi_dma_addr; +struct hinic_debug_priv *dbg; };struct hinic_qp {
drivers/net/ethernet/huawei/hinic/hinic_main.c +21 -2
@@ -234,6 +234,8 @@ static int create_rxqs(struct hinic_dev *nic_dev)if (!nic_dev->rxqs)return -ENOMEM ; +hinic_rq_dbgfs_init (nic_dev); +for (i =0 ; i < num_rxqs; i++) {struct hinic_rq *rq =hinic_hwdev_get_rq (nic_dev->hwdev, i);
@@ -243,13 +245,26 @@ static int create_rxqs(struct hinic_dev *nic_dev) "Failed to init rxq\n"); goto err_init_rxq; } + + err =hinic_rq_debug_add (nic_dev, i); +if (err) { +netif_err (nic_dev, drv, netdev, +"Failed to add RQ%d debug\n" , i); + goto err_add_rq_dbg; + } }return 0 ; +err_add_rq_dbg: +hinic_clean_rxq (&nic_dev->rxqs[i]); err_init_rxq: -for (j =0 ; j < i; j++) +for (j =0 ; j < i; j++) { +hinic_rq_debug_rem (nic_dev->rxqs[j].rq);hinic_clean_rxq (&nic_dev->rxqs[j]); + } + +hinic_rq_dbgfs_uninit (nic_dev);devm_kfree (&netdev->dev, nic_dev->rxqs);return err;
@@ -267,8 +282,12 @@ static void free_rxqs(struct hinic_dev *nic_dev)if (!nic_dev->rxqs)return ; -for (i =0 ; i < num_rxqs; i++) +for (i =0 ; i < num_rxqs; i++) { +hinic_rq_debug_rem (nic_dev->rxqs[i].rq);hinic_clean_rxq (&nic_dev->rxqs[i]); + } + +hinic_rq_dbgfs_uninit (nic_dev);devm_kfree (&netdev->dev, nic_dev->rxqs); nic_dev->rxqs =NULL ;
Signature · 1 line
2.17.1
PATCH v2 3/3 hinic: add support to query function table
In reply to Luo binadd debugfs node for querying function table, for example:
cat /sys/kernel/debug/hinic/0000:15:00.0/func_table/valid
---
V0~V1:
- remove command interfaces to the read only files
- split addition of each object into a separate patch
V1~V2:
- remove vlan_id and vlan_mode from the func_table_fields
.../net/ethernet/huawei/hinic/hinic_debugfs.c | 92 ++++++++++++++++++- .../net/ethernet/huawei/hinic/hinic_debugfs.h | 79 ++++++++++++++++ drivers/net/ethernet/huawei/hinic/hinic_dev.h | 3 + .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 2 + .../net/ethernet/huawei/hinic/hinic_main.c | 15 +++ 5 files changed, 190 insertions(+), 1 deletion(-)
drivers/net/ethernet/huawei/hinic/hinic_debugfs.c +91 -1
@@ -70,6 +70,63 @@ static u64 hinic_dbg_get_rq_info(struct hinic_dev *nic_dev, struct hinic_rq *rq,return 0 ; } +enum func_tbl_info { +VALID , +RX_MODE , +MTU , +RQ_DEPTH , +QUEUE_NUM , +}; + +static char *func_table_fields[] = {"valid" ,"rx_mode" ,"mtu" ,"rq_depth" ,"cfg_q_num" }; + +static int hinic_dbg_get_func_table (struct hinic_dev *nic_dev,int idx) +{ +struct tag_sml_funcfg_tbl *funcfg_table_elem; +struct hinic_cmd_lt_rd *read_data; +u16 out_size =sizeof (*read_data); +int err; + + read_data =kzalloc (sizeof (*read_data),GFP_KERNEL ); +if (!read_data) +return ~0 ; + + read_data->node =TBL_ID_FUNC_CFG_SM_NODE ; + read_data->inst =TBL_ID_FUNC_CFG_SM_INST ; + read_data->entry_size =HINIC_FUNCTION_CONFIGURE_TABLE_SIZE ; + read_data->lt_index =HINIC_HWIF_FUNC_IDX (nic_dev->hwdev->hwif); + read_data->len =HINIC_FUNCTION_CONFIGURE_TABLE_SIZE ; + + err =hinic_port_msg_cmd (nic_dev->hwdev,HINIC_PORT_CMD_RD_LINE_TBL , read_data, +sizeof (*read_data), read_data, &out_size); +if (err || out_size !=sizeof (*read_data) || read_data->status) { +netif_err (nic_dev, drv, nic_dev->netdev, +"Failed to get func table, err: %d, status: 0x%x, out size: 0x%x\n" , + err, read_data->status, out_size); +kfree (read_data); +return ~0 ; + } + + funcfg_table_elem = (struct tag_sml_funcfg_tbl *)read_data->data; + +switch (idx) { +case VALID : +return funcfg_table_elem->dw0.bs.valid; +case RX_MODE : +return funcfg_table_elem->dw0.bs.nic_rx_mode; +case MTU : +return funcfg_table_elem->dw1.bs.mtu; +case RQ_DEPTH : +return funcfg_table_elem->dw13.bs.cfg_rq_depth; +case QUEUE_NUM : +return funcfg_table_elem->dw13.bs.cfg_q_num; + } + +kfree (read_data); + +return ~0 ; +} +static ssize_t hinic_dbg_cmd_read (struct file *filp,char __user *buffer,size_t count,loff_t *ppos) {
@@ -91,6 +148,10 @@ static ssize_t hinic_dbg_cmd_read(struct file *filp, char __user *buffer, size_t out =hinic_dbg_get_rq_info (dbg->dev, dbg->object, *desc);break ; +case HINIC_DBG_FUNC_TABLE : + out =hinic_dbg_get_func_table (dbg->dev, *desc); +break ; +default :netif_warn (dbg->dev, drv, dbg->dev->netdev,"Invalid hinic debug cmd: %d\n" , dbg->type);
@@ -136,7 +197,9 @@ static int create_dbg_files(struct hinic_dev *dev, enum hinic_dbg_type type, voistatic void rem_dbg_files (struct hinic_debug_priv *dbg) { -debugfs_remove_recursive (dbg->root); +if (dbg->type !=HINIC_DBG_FUNC_TABLE ) +debugfs_remove_recursive (dbg->root); +kfree (dbg); }
@@ -184,6 +247,21 @@ void hinic_rq_debug_rem(struct hinic_rq *rq)rem_dbg_files (rq->dbg); } +int hinic_func_table_debug_add (struct hinic_dev *dev) +{ +if (HINIC_IS_VF (dev->hwdev->hwif)) +return 0 ; + +return create_dbg_files (dev,HINIC_DBG_FUNC_TABLE , dev, dev->func_tbl_dbgfs, &dev->dbg, + func_table_fields,ARRAY_SIZE (func_table_fields)); +} + +void hinic_func_table_debug_rem (struct hinic_dev *dev) +{ +if (!HINIC_IS_VF (dev->hwdev->hwif) && dev->dbg) +rem_dbg_files (dev->dbg); +} +void hinic_sq_dbgfs_init (struct hinic_dev *nic_dev) { nic_dev->sq_dbgfs =debugfs_create_dir ("SQs" , nic_dev->dbgfs_root);
@@ -204,6 +282,18 @@ void hinic_rq_dbgfs_uninit(struct hinic_dev *nic_dev)debugfs_remove_recursive (nic_dev->rq_dbgfs); } +void hinic_func_tbl_dbgfs_init (struct hinic_dev *nic_dev) +{ +if (!HINIC_IS_VF (nic_dev->hwdev->hwif)) + nic_dev->func_tbl_dbgfs =debugfs_create_dir ("func_table" , nic_dev->dbgfs_root); +} + +void hinic_func_tbl_dbgfs_uninit (struct hinic_dev *nic_dev) +{ +if (!HINIC_IS_VF (nic_dev->hwdev->hwif)) +debugfs_remove_recursive (nic_dev->func_tbl_dbgfs); +} +void hinic_dbg_init (struct hinic_dev *nic_dev) { nic_dev->dbgfs_root = debugfs_create_dir(pci_name(nic_dev->hwdev->hwif->pdev),
drivers/net/ethernet/huawei/hinic/hinic_debugfs.h +79 -0
97 lines not on this page · raw message
drivers/net/ethernet/huawei/hinic/hinic_dev.h +3 -0
@@ -61,6 +61,7 @@ struct hinic_intr_coal_info {enum hinic_dbg_type {HINIC_DBG_SQ_INFO ,HINIC_DBG_RQ_INFO , +HINIC_DBG_FUNC_TABLE , };struct hinic_debug_priv {
@@ -114,6 +115,8 @@ struct hinic_dev {struct dentry *dbgfs_root;struct dentry *sq_dbgfs;struct dentry *rq_dbgfs; +struct dentry *func_tbl_dbgfs; +struct hinic_debug_priv *dbg;struct devlink *devlink;bool cable_unplugged;bool module_unrecognized;
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.h +2 -0
@@ -96,6 +96,8 @@ enum hinic_port_cmd {HINIC_PORT_CMD_RSS_TEMP_MGR =49 , +HINIC_PORT_CMD_RD_LINE_TBL =57 , +HINIC_PORT_CMD_RSS_CFG =66 , HINIC_PORT_CMD_FWCTXT_INIT = 69,
drivers/net/ethernet/huawei/hinic/hinic_main.c +15 -0
@@ -1302,6 +1302,14 @@ static int nic_dev_init(struct pci_dev *pdev)hinic_dbg_init (nic_dev); +hinic_func_tbl_dbgfs_init (nic_dev); + + err =hinic_func_table_debug_add (nic_dev); +if (err) { +dev_err (&pdev->dev,"Failed to add func_table debug\n" ); + goto err_add_func_table_dbg; + } + err =register_netdev (netdev);if (err) {dev_err (&pdev->dev,"Failed to register netdev\n" );
@@ -1311,6 +1319,9 @@ static int nic_dev_init(struct pci_dev *pdev)return 0 ; err_reg_netdev: +hinic_func_table_debug_rem (nic_dev); +err_add_func_table_dbg: +hinic_func_tbl_dbgfs_uninit (nic_dev);hinic_dbg_uninit (nic_dev);hinic_free_intr_coalesce (nic_dev); err_init_intr:
@@ -1434,6 +1445,10 @@ static void hinic_remove(struct pci_dev *pdev)unregister_netdev (netdev); +hinic_func_table_debug_rem (nic_dev); + +hinic_func_tbl_dbgfs_uninit (nic_dev); +hinic_dbg_uninit (nic_dev);hinic_free_intr_coalesce (nic_dev);
Signature · 1 line
2.17.1
David Miller
maintainerFrom: Luo bin <[email protected]>
Date: Fri, 28 Aug 2020 11:37:45 +0800
Quoted 1 line
add debugfs node for querying sq/rq info and function table
Series applied, thanks.