mfd: madera: Simplify with dev_err_probe()
PATCH 1/3 mfd: madera: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/mfd/madera-core.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/mfd/madera-core.c +3 -8
@@ -369,19 +369,14 @@ EXPORT_SYMBOL_GPL(madera_of_match);static int madera_get_reset_gpio (struct madera *madera) {struct gpio_desc *reset; -int ret;if (madera->pdata.reset)return 0 ; reset =devm_gpiod_get_optional (madera->dev,"reset" ,GPIOD_OUT_LOW ); -if (IS_ERR (reset)) { - ret =PTR_ERR (reset); -if (ret != -EPROBE_DEFER ) -dev_err (madera->dev,"Failed to request /RESET: %d\n" , - ret); -return ret; - } +if (IS_ERR (reset)) +return dev_err_probe (madera->dev,PTR_ERR (reset), +"Failed to request /RESET" );/* * A hard reset is needed for full reset of the chip. We allow running
Signature · 1 line
2.17.1
PATCH 2/3 mfd: stmfx: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/mfd/stmfx.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/mfd/stmfx.c +3 -5
@@ -331,11 +331,9 @@ static int stmfx_chip_init(struct i2c_client *client) ret =PTR_ERR_OR_ZERO (stmfx->vdd);if (ret == -ENODEV ) { stmfx->vdd =NULL ; - }else if (ret == -EPROBE_DEFER ) { -return ret; - }else if (ret) { -dev_err (&client->dev,"Failed to get VDD regulator: %d\n" , ret); -return ret; + }else { +return dev_err_probe (&client->dev, ret, +"Failed to get VDD regulator\n" ); }if (stmfx->vdd) {
Signature · 1 line
2.17.1
Lee Jones
AppliedRe: [PATCH 2/3] mfd: stmfx: Simplify with dev_err_probe()
Quoted 7 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/mfd/stmfx.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 3/3 mfd: wcd934x: Simplify with dev_err_probe()
In reply to Krzysztof KozlowskiCommon pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value.
--- drivers/mfd/wcd934x.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/mfd/wcd934x.c +3 -6
@@ -219,12 +219,9 @@ static int wcd934x_slim_probe(struct slim_device *sdev)return -ENOMEM ; ddata->irq =of_irq_get (np,0 ); -if (ddata->irq <0 ) { -if (ddata->irq != -EPROBE_DEFER ) -dev_err (ddata->dev,"Failed to get IRQ: err = %d\n" , - ddata->irq); -return ddata->irq; - } +if (ddata->irq <0 ) +return dev_err_probe (ddata->dev, ddata->irq, +"Failed to get IRQ\n" ); reset_gpio =of_get_named_gpio (np,"reset-gpios" ,0 );if (reset_gpio <0 ) {
Signature · 1 line
2.17.1
Lee Jones
AppliedRe: [PATCH 3/3] mfd: wcd934x: Simplify with dev_err_probe()
Quoted 7 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/mfd/wcd934x.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 5 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>---
Thanks,
Charles
Lee Jones
AppliedQuoted 7 lines · Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/mfd/madera-core.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog