Skip to contentSkip to conversation

ia64: Fix build error with !COREDUMP

PATCH RESEND Applied Krzysztof Kozlowski 2 participants 2 messages Aug 19, 2020 – Aug 28, 2020 Stable branch

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 ia64: Fix build error with !COREDUMP

Fix linkage error when CONFIG_BINFMT_ELF is selected but CONFIG_COREDUMP is not:

ia64-linux-ld: arch/ia64/kernel/elfcore.o: in function `elf_core_write_extra_phdrs':
elfcore.c:(.text+0x172): undefined reference to `dump_emit'
ia64-linux-ld: arch/ia64/kernel/elfcore.o: in function `elf_core_write_extra_data':
elfcore.c:(.text+0x2b2): undefined reference to `dump_emit'

Fixes 1fcccbac89f5 ("elf coredump: replace ELF_CORE_EXTRA_* macros by functions")

---

This is similar fix to commit 42d91f612c87 ("um: Fix build error and kconfig for i386") although I put different fixes tag - the commit which introduced this part of code.

---
 arch/ia64/kernel/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/Makefile +1 -1
index 1a8df6669eee..18d6008b151f 100644
@@ -41,7 +41,7 @@ obj-y				+= esi_stub.o	# must be in kernel proper
 endif
 obj-$(CONFIG_INTEL_IOMMU)	+= pci-dma.o
 
-obj-$(CONFIG_BINFMT_ELF)	+= elfcore.o
+obj-$(CONFIG_ELF_CORE)		+= elfcore.o
 
 # fp_emulate() expects f2-f5,f16-f31 to contain the user-level state.
 CFLAGS_traps.o  += -mfixed-rangeò-f5,f16-f31
Signature · 1 line
2.17.1
#1 lore raw
I love your patch! Yet something to improve:

Hi Krzysztof,

I love your patch! Yet something to improve:

[auto build test ERROR on ia64/next]
[also build test ERROR on v5.9-rc2]
[cannot apply to next-20200827]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Krzysztof-Kozlowski/ia64-Fix-build-error-with-COREDUMP/20200819-144301
base:   https://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git next
config: ia64-randconfig-r025-20200827 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>, old ones prefixed by <<):

ERROR: modpost: "min_low_pfn" [drivers/block/aoe/aoe.ko] undefined!

>> ERROR: modpost: "max_low_pfn" [drivers/block/aoe/aoe.ko] undefined!

ERROR: modpost: "max_low_pfn" [drivers/dma/fsl-edma-common.ko] undefined!
ERROR: modpost: "min_low_pfn" [drivers/dma/fsl-edma-common.ko] undefined!
ERROR: modpost: "min_low_pfn" [fs/pstore/ramoops.ko] undefined!
ERROR: modpost: "max_low_pfn" [fs/pstore/ramoops.ko] undefined!

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org