Skip to contentSkip to conversation

board: tbs2910: Use recommended distroboot addresses

PATCH New Soeren Moch 4 participants 9 messages Aug 27, 2020 – Oct 2, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 board: tbs2910: Use recommended distroboot addresses

According to doc/README.distro fdt_addr must not be set when DTB is not available from hardware. So remove this entry.

Use address 32MB above the start of DRAM for kernel_addr_r. This way we likely can avoid the self-relocation of the compressed kernel image before it decompresses to offset 0x8000 from start of DRAM.

Use address 128MB above the start of DRAM for fdt_addr_r, since this is the maximum location for the end of the kernel. So we avoid overwriting the DTB.

Use 512k above that for ramdisk_addr_r. This should be enough for the DTB, rest of DRAM can be used for initrd.

Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM. This space is available for processing in U-Boot.

---
Cc: Stefano Babic <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Denis 'GNUtoo' Carikli <[email protected]>
Cc: u-boot at lists.denx.de

Recommendations taken from [1].

Distroboot support for the tbs2910 board was added in the v2020.10 merge window. So please pull this in as fix for v2020.10.

Thanks,
Soeren

[1] https://lists.denx.de/pipermail/u-boot/2020-January/398482.html

---
 include/configs/tbs2910.h | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
include/configs/tbs2910.h +5 -6
index 8092b9edfb..b05034945e 100644
@@ -85,13 +85,12 @@
 			"bootm 0x10800000 0x10d00000\0" \
 	"console=ttymxc0\0" \
 	"fan=gpio set 92\0" \
-	"fdt_addr=0x13000000\0" \
-	"fdt_addr_r=0x13000000\0" \
+	"fdt_addr_r=0x18000000\0" \
 	"fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
-	"kernel_addr_r=0x10008000\0" \
-	"pxefile_addr_r=0x10008000\0" \
-	"ramdisk_addr_r=0x18000000\0" \
-	"scriptaddr=0x14000000\0" \
+	"kernel_addr_r=0x12000000\0" \
+	"pxefile_addr_r=0x10100000\0" \
+	"ramdisk_addr_r=0x18080000\0" \
+	"scriptaddr=0x10000000\0" \
 	"set_con_serial=setenv stdout serial; " \
 			"setenv stderr serial\0" \
 	"set_con_hdmi=setenv stdout serial,vidconsole; " \

--
2.17.1

#1 lore raw

PATCH 1/2 board: tbs2910: Use recommended distroboot addresses

Stefano, Tom,

I would really like to see this merged for v2020.10. Maybe there are no other imx patches pending for v2020.10, so maybe Tom can pick up this directly (as the original patch for sysboot support, that was merged in -next for v2020.10-rc1)?

This really is a fix for this newly added sysboot support on tbs2910, so it would be great to get the properly fixed addresses and dtb declaration into the final release. The u-boot internal device tree must not be used for booting linux, since this dtb is stripped down. And the recommended kernel address avoids the additional self-relocation of the kernel after starting linux.

Thanks,
Soeren

Quoted 63 lines · Soeren Moch

According to doc/README.distro fdt_addr must not be set when DTB is not available from hardware. So remove this entry.

Use address 32MB above the start of DRAM for kernel_addr_r. This way we likely can avoid the self-relocation of the compressed kernel image before it decompresses to offset 0x8000 from start of DRAM.

Use address 128MB above the start of DRAM for fdt_addr_r, since this is the maximum location for the end of the kernel. So we avoid overwriting the DTB.

Use 512k above that for ramdisk_addr_r. This should be enough for the DTB, rest of DRAM can be used for initrd.

Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM. This space is available for processing in U-Boot.

---
Cc: Stefano Babic <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Denis 'GNUtoo' Carikli <[email protected]>
Cc: u-boot at lists.denx.de

Recommendations taken from [1].

Distroboot support for the tbs2910 board was added in the v2020.10 merge window. So please pull this in as fix for v2020.10.

Thanks,
Soeren

[1] https://lists.denx.de/pipermail/u-boot/2020-January/398482.html

---
 include/configs/tbs2910.h | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
include/configs/tbs2910.h +5 -7
index 8092b9edfb..b05034945e 100644
@@ -85,13 +85,12 @@
 			"bootm 0x10800000 0x10d00000\0" \
 	"console=ttymxc0\0" \
 	"fan=gpio set 92\0" \
-	"fdt_addr=0x13000000\0" \
-	"fdt_addr_r=0x13000000\0" \
+	"fdt_addr_r=0x18000000\0" \
 	"fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
-	"kernel_addr_r=0x10008000\0" \
-	"pxefile_addr_r=0x10008000\0" \
-	"ramdisk_addr_r=0x18000000\0" \
-	"scriptaddr=0x14000000\0" \
+	"kernel_addr_r=0x12000000\0" \
+	"pxefile_addr_r=0x10100000\0" \
+	"ramdisk_addr_r=0x18080000\0" \
+	"scriptaddr=0x10000000\0" \
 	"set_con_serial=setenv stdout serial; " \
 			"setenv stderr serial\0" \
 	"set_con_hdmi=setenv stdout serial,vidconsole; " \
--

2.17.1

#2 lore raw

PATCH 1/2 board: tbs2910: Use recommended distroboot addresses

Hi Soeren,

Quoted 4 lines · Soeren Moch

Stefano, Tom,

I would really like to see this merged for v2020.10. Maybe there are no other imx patches pending for v2020.10,

Right, I do not see urgent fixes, and remaining patches will be merged after release.

Quoted 3 lines

so maybe Tom can pick up this
directly (as the original patch for sysboot support, that was merged in -next for v2020.10-rc1)?

Fine with me - @Tom, could you pick up this ?

Quoted 7 lines

This really is a fix for this newly added sysboot support on tbs2910, so it would be great to get the properly fixed addresses and dtb declaration into the final release. The u-boot internal device tree must not be used for booting linux, since this dtb is stripped down. And the recommended kernel address avoids the additional self-relocation of the kernel after starting linux.

Regards,
Stefano

Quoted 68 lines

Thanks,
Soeren

Quoted 63 lines · Soeren Moch

According to doc/README.distro fdt_addr must not be set when DTB is not available from hardware. So remove this entry.

Use address 32MB above the start of DRAM for kernel_addr_r. This way we likely can avoid the self-relocation of the compressed kernel image before it decompresses to offset 0x8000 from start of DRAM.

Use address 128MB above the start of DRAM for fdt_addr_r, since this is the maximum location for the end of the kernel. So we avoid overwriting the DTB.

Use 512k above that for ramdisk_addr_r. This should be enough for the DTB, rest of DRAM can be used for initrd.

Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM. This space is available for processing in U-Boot.

---
Cc: Stefano Babic <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Denis 'GNUtoo' Carikli <[email protected]>
Cc: u-boot at lists.denx.de

Recommendations taken from [1].

Distroboot support for the tbs2910 board was added in the v2020.10 merge window. So please pull this in as fix for v2020.10.

Thanks,
Soeren

[1] https://lists.denx.de/pipermail/u-boot/2020-January/398482.html

---
 include/configs/tbs2910.h | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
include/configs/tbs2910.h +5 -7
index 8092b9edfb..b05034945e 100644
@@ -85,13 +85,12 @@
 			"bootm 0x10800000 0x10d00000\0" \
 	"console=ttymxc0\0" \
 	"fan=gpio set 92\0" \
-	"fdt_addr=0x13000000\0" \
-	"fdt_addr_r=0x13000000\0" \
+	"fdt_addr_r=0x18000000\0" \
 	"fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
-	"kernel_addr_r=0x10008000\0" \
-	"pxefile_addr_r=0x10008000\0" \
-	"ramdisk_addr_r=0x18000000\0" \
-	"scriptaddr=0x14000000\0" \
+	"kernel_addr_r=0x12000000\0" \
+	"pxefile_addr_r=0x10100000\0" \
+	"ramdisk_addr_r=0x18080000\0" \
+	"scriptaddr=0x10000000\0" \
 	"set_con_serial=setenv stdout serial; " \
 			"setenv stderr serial\0" \
 	"set_con_hdmi=setenv stdout serial,vidconsole; " \
--

2.17.1

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/2 board: tbs2910: Use recommended distroboot addresses

In reply to Soeren Moch

Hi Soeren,

Quoted 12 lines · Soeren Moch

According to doc/README.distro fdt_addr must not be set when DTB is not available from hardware. So remove this entry.

Use address 32MB above the start of DRAM for kernel_addr_r. This way we likely can avoid the self-relocation of the compressed kernel image before it decompresses to offset 0x8000 from start of DRAM.

Use address 128MB above the start of DRAM for fdt_addr_r, since this is the maximum location for the end of the kernel. So we avoid overwriting the DTB.

Quoted 7 lines

Use 512k above that for ramdisk_addr_r. This should be enough for the DTB, rest of DRAM can be used for initrd.

Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM. This space is available for processing in U-Boot.

#4 lore raw

PATCH 1/2 board: tbs2910: Use recommended distroboot addresses

In reply to Soeren Moch
Quoted 11 lines · Soeren Moch

According to doc/README.distro fdt_addr must not be set when DTB is not available from hardware. So remove this entry.

Use address 32MB above the start of DRAM for kernel_addr_r. This way we likely can avoid the self-relocation of the compressed kernel image before it decompresses to offset 0x8000 from start of DRAM.

Use address 128MB above the start of DRAM for fdt_addr_r, since this is the maximum location for the end of the kernel. So we avoid overwriting the DTB.

Quoted 7 lines

Use 512k above that for ramdisk_addr_r. This should be enough for the DTB, rest of DRAM can be used for initrd.

Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM. This space is available for processing in U-Boot.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200828/d0e6f617/attachment.sig>
#5 lore raw

PATCH 2/2 board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

In reply to Soeren Moch

This is not required for sysboot (we defined fdtfile), let's save a few bytes in the binary image without these variables.

---
Cc: Stefano Babic <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Denis 'GNUtoo' Carikli <[email protected]>
Cc: u-boot at lists.denx.de

---
 configs/tbs2910_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/tbs2910_defconfig +0 -1
index 34d240565e..070aea59b5 100644
@@ -11,7 +11,6 @@ CONFIG_PRE_CON_BUF_ADDR=0x7c000000
 CONFIG_CMD_HDMIDETECT=y
 CONFIG_DEFAULT_DEVICE_TREE="imx6q-tbs2910"
 CONFIG_AHCI=y
-CONFIG_ENV_VARS_UBOOT_CONFIG=y
 CONFIG_BOOTDELAY=3
 CONFIG_USE_BOOTCOMMAND=y
 CONFIG_BOOTCOMMAND="mmc rescan; if run bootcmd_up1; then run bootcmd_up2; else run bootcmd_mmc || run distro_bootcmd; fi"

--
2.17.1

#7 lore raw

PATCH 2/2 board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

In reply to Soeren Moch
Quoted 4 lines

This is not required for sysboot (we defined fdtfile), let's save a few bytes in the binary image without these variables.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#8 lore raw

PATCH 1/2 board: tbs2910: Use recommended distroboot addresses

In reply to Soeren Moch
Quoted 14 lines · Soeren Moch

According to doc/README.distro fdt_addr must not be set when DTB is not available from hardware. So remove this entry.

Use address 32MB above the start of DRAM for kernel_addr_r. This way we likely can avoid the self-relocation of the compressed kernel image before it decompresses to offset 0x8000 from start of DRAM.

Use address 128MB above the start of DRAM for fdt_addr_r, since this is the maximum location for the end of the kernel. So we avoid overwriting the DTB.

Use 512k above that for ramdisk_addr_r. This should be enough for the DTB, rest of DRAM can be used for initrd.

Quoted 6 lines

Place boot script / extlinux.conf at offset 0 / 1MB from start of DRAM. This space is available for processing in U-Boot.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201002/07290455/attachment.sig>