Skip to contentSkip to conversation

lpfc: Fix setting irq affinity with an empty cpu mask.

PATCH New James Smart 1 participant 1 message Aug 28, 2020 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/4 lpfc: Fix setting irq affinity with an empty cpu mask.

Some systems are reporting the following log message during driver unload or system shutdown:
ics_rtas_set_affinity: No online cpus in the mask

A prior commit introduced the writing of an empty affinity mask in calls to irq_set_affinity_hint() when disabling interrupts or when there are no remaining online cpus to service an eq interrupt. At least some ppc64 systems are checking whether affinity masks are empty or not.

Fix: Do not call irq_set_affinity_hint() with an empty cpu mask.

Fixes dcaa21367938 ("scsi: lpfc: Change default IRQ model on AMD architectures")
Cc <[email protected]> # v5.5+
---
 drivers/scsi/lpfc/lpfc_init.c | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/lpfc/lpfc_init.c +0 -1
index 05ace6916b66..89c3ba0a0df9 100644
@@ -11376,7 +11376,6 @@ lpfc_irq_clear_aff(struct lpfc_hba_eq_hdl *eqhdl)
 {
 	cpumask_clear(&eqhdl->aff_mask);
 	irq_clear_status_flags(eqhdl->irq, IRQ_NO_BALANCING);
-	irq_set_affinity_hint(eqhdl->irq, &eqhdl->aff_mask);
 }
 
 /**
Signature · 1 line
2.26.2