Skip to contentSkip to conversation

package/chocolate-doom: fix build with gcc 10

PATCH New Fabrice Fontaine 2 participants 2 messages Aug 28, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/chocolate-doom: fix build with gcc 10

Fixes:
- http://autobuild.buildroot.org/results/02828f2d9956d1e3727774b5045790aa3611428d

---
 ...move-redundant-demoextend-definition.patch | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 package/chocolate-doom/0001-Remove-redundant-demoextend-definition.patch
package/chocolate-doom/0001-Remove-redundant-demoextend-definition.patch new file +29 -0
new file mode 100644
index 0000000000..bbfbdbb2d6
@@ -0,0 +1,29 @@
+From a8fd4b1f563d24d4296c3e8225c8404e2724d4c2 Mon Sep 17 00:00:00 2001
+From: Jordan Christiansen <[email protected]>
+Date: Sun, 15 Mar 2020 16:55:33 -0500
+Subject: [PATCH] Remove redundant demoextend definition
+
+GCC 10 enables -fno-common by default, which causes the linker to fail when
+there are multple definitions of a global variable.
+
+See https://gcc.gnu.org/gcc-10/porting_to.html
+
+[Retrieved from:
+https://github.com/chocolate-doom/chocolate-doom/commit/a8fd4b1f563d24d4296c3e8225c8404e2724d4c2]
+Signed-off-by: Fabrice Fontaine <[email protected]>
+---
+ src/hexen/mn_menu.c | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/src/hexen/mn_menu.c b/src/hexen/mn_menu.c
+index 059f45b3e..a97b7fcd1 100644
+--- a/src/hexen/mn_menu.c
++++ b/src/hexen/mn_menu.c
+@@ -131,7 +131,6 @@ boolean MenuActive;
+ int InfoType;
+ int messageson = true;
+ boolean mn_SuicideConsole;
+-boolean demoextend; // from h2def.h
+ 
+ // PRIVATE DATA DEFINITIONS ------------------------------------------------
+ 
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/chocolate-doom: fix build with gcc 10

Quoted 8 lines · On Sat, 29 Aug 2020 00:07:20 +0200 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/02828f2d9956d1e3727774b5045790aa3611428d

---
 ...move-redundant-demoextend-definition.patch | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 package/chocolate-doom/0001-Remove-redundant-demoextend-definition.patch

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com