Skip to contentSkip to conversation

package/easyframes: new package

PATCH New Horatiu Vultur 3 participants 3 messages Aug 29, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 package/easyframes: new package

---
Changes v3 -> v4:
- update the version
- remove C++ dependecy

Changes v2 -> v3:
- add missing changelog

Changes v1 -> v2:
- add missing comment in easyframes.hash
- add sha256 for COPYING
- remove zlib dependency
- change from using sha to use tag

---
 DEVELOPERS                         |  3 +++
 package/Config.in                  |  1 +
 package/easyframes/Config.in       |  9 +++++++++
 package/easyframes/easyframes.hash |  3 +++
 package/easyframes/easyframes.mk   | 15 +++++++++++++++
 5 files changed, 31 insertions(+)
 create mode 100644 package/easyframes/Config.in
 create mode 100644 package/easyframes/easyframes.hash
 create mode 100644 package/easyframes/easyframes.mk
DEVELOPERS +3 -0
index 3c3dcda859..96414f5b4b 100644
@@ -1111,6 +1111,9 @@ F:	package/gauche/
 F:	package/gmrender-resurrect/
 F:	package/squeezelite/
 
+N:	Horatiu Vultur <[email protected]>
+F:	package/easyframes/
+
 N:	Ian Haylock <[email protected]>
 F:	package/python-rpi-gpio/
 
package/Config.in +1 -0
index d7e79f4795..3965d523c6 100644
@@ -2039,6 +2039,7 @@ menu "Networking applications"
 	source "package/dnsmasq/Config.in"
 	source "package/drbd-utils/Config.in"
 	source "package/dropbear/Config.in"
+	source "package/easyframes/Config.in"
 	source "package/ebtables/Config.in"
 	source "package/ejabberd/Config.in"
 	source "package/ethtool/Config.in"
package/easyframes/Config.in new file +9 -0
new file mode 100644
index 0000000000..f3a4ddbb34
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_EASYFRAMES
+	bool "easyframes"
+	select BR2_PACKAGE_LIBPCAP
+	help
+	  This is a small and simple command-line tool for network testing.
+	  The tool makes it simple to compose a frame, inject and express what
+	  and where frames are expected to be received.
+
+	  https://github.com/microchip-ung/easyframes
package/easyframes/easyframes.hash new file +3 -0
new file mode 100644
index 0000000000..a0b193ca6e
@@ -0,0 +1,3 @@
+# locally calculated
+sha256 3c0449b3129c29b5ecf67b689f1a75ffc65fde3c5f62811e2f0439ce4f4af392 easyframes-v0.3.tar.gz
+sha256 24f37598e822a1411fb7164ce7eb3ef120aea8279016399abc282c2381ce3f57 COPYING
package/easyframes/easyframes.mk new file +15 -0
new file mode 100644
index 0000000000..b0ec1ae7e5
@@ -0,0 +1,15 @@
+################################################################################
+#
+# easyframes
+#
+################################################################################
+
+EASYFRAMES_VERSION = v0.3
+EASYFRAMES_SITE = $(call github,microchip-ung,easyframes,$(EASYFRAMES_VERSION))
+EASYFRAMES_INSTALL_STAGING = YES
+EASYFRAMES_DEPENDENCIES = libpcap
+
+EASYFRAMES_LICENSE = MIT
+EASYFRAMES_LICENSE_FILES = COPYING
+
+$(eval $(cmake-package))
Signature · 1 line
2.27.0
#1 lore raw

PATCH v4 1/1 package/easyframes: new package

Hello,

Quoted 59 lines · Horatiu Vultur via buildroot

---
Changes v3 -> v4:
- update the version
- remove C++ dependecy

Changes v2 -> v3:
- add missing changelog

Changes v1 -> v2:
- add missing comment in easyframes.hash
- add sha256 for COPYING
- remove zlib dependency
- change from using sha to use tag

---
 DEVELOPERS                         |  3 +++
 package/Config.in                  |  1 +
 package/easyframes/Config.in       |  9 +++++++++
 package/easyframes/easyframes.hash |  3 +++
 package/easyframes/easyframes.mk   | 15 +++++++++++++++
 5 files changed, 31 insertions(+)
 create mode 100644 package/easyframes/Config.in
 create mode 100644 package/easyframes/easyframes.hash
 create mode 100644 package/easyframes/easyframes.mk
DEVELOPERS +3 -0
index 3c3dcda859..96414f5b4b 100644
@@ -1111,6 +1111,9 @@ F:        package/gauche/
 F:     package/gmrender-resurrect/
 F:     package/squeezelite/
 
+N:     Horatiu Vultur <[email protected]>
+F:     package/easyframes/
+
 N:     Ian Haylock <[email protected]>
 F:     package/python-rpi-gpio/
 
package/Config.in +1 -0
index d7e79f4795..3965d523c6 100644
@@ -2039,6 +2039,7 @@ menu "Networking applications"
        source "package/dnsmasq/Config.in"
        source "package/drbd-utils/Config.in"
        source "package/dropbear/Config.in"
+       source "package/easyframes/Config.in"
        source "package/ebtables/Config.in"
        source "package/ejabberd/Config.in"
        source "package/ethtool/Config.in"
package/easyframes/Config.in new file +0 -0
new file mode 100644
index 0000000000..f3a4ddbb34

package/easyframes/Config.in line 7

Quoted 7 lines
package/easyframes/Config.in new file +7 -0
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_EASYFRAMES
+       bool "easyframes"
+       select BR2_PACKAGE_LIBPCAP
+       help
+         This is a small and simple command-line tool for network testing.
+         The tool makes it simple to compose a frame, inject and express what
+         and where frames are expected to be received.

Pay attention to the Config.in file conventions:
http://nightly.buildroot.org/#writing-rules-config-in4 ("make check-package" validates that).

Quoted 17 lines
package/easyframes/Config.in new file +2 -0
+
+         https://github.com/microchip-ung/easyframes
package/easyframes/easyframes.hash new file +3 -0
new file mode 100644
index 0000000000..a0b193ca6e
@@ -0,0 +1,3 @@
+# locally calculated
+sha256 3c0449b3129c29b5ecf67b689f1a75ffc65fde3c5f62811e2f0439ce4f4af392 easyframes-v0.3.tar.gz
+sha256 24f37598e822a1411fb7164ce7eb3ef120aea8279016399abc282c2381ce3f57 COPYING
package/easyframes/easyframes.mk new file +0 -0
new file mode 100644
index 0000000000..b0ec1ae7e5

package/easyframes/easyframes.mk line 9

Quoted 9 lines
package/easyframes/easyframes.mk new file +9 -0
@@ -0,0 +1,15 @@
+################################################################################
+#
+# easyframes
+#
+################################################################################
+
+EASYFRAMES_VERSION = v0.3
+EASYFRAMES_SITE = $(call github,microchip-ung,easyframes,$(EASYFRAMES_VERSION))
+EASYFRAMES_INSTALL_STAGING = YES

Now I notice that the only file installed with this package is the 'ef binary. In this case, there's no need to install easyframes to the staging dir.

Quoted 9 lines
package/easyframes/easyframes.mk new file +6 -1
+EASYFRAMES_DEPENDENCIES = libpcap
+
+EASYFRAMES_LICENSE = MIT
+EASYFRAMES_LICENSE_FILES = COPYING
+
+$(eval $(cmake-package))
--

2.27.0

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Regards,
Asaf.

#2 lore raw

PATCH v4 1/1 package/easyframes: new package

In reply to Horatiu Vultur

Hello,

Quoted 1 line · On Sat, 29 Aug 2020 09:24:16 +0200 Horatiu Vultur via buildroot…

Thanks, I've applied to next, with a few changes, see below.

package/easyframes/Config.in line 7

Quoted 13 lines
package/easyframes/Config.in new file +7 -0
new file mode 100644
index 0000000000..f3a4ddbb34
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_EASYFRAMES
+	bool "easyframes"
+	select BR2_PACKAGE_LIBPCAP
+	help
+	  This is a small and simple command-line tool for network testing.
+	  The tool makes it simple to compose a frame, inject and express what
+	  and where frames are expected to be received.

These lines were too long, so I wrapped them.

package/easyframes/Config.in

Quoted 8 lines
package/easyframes/Config.in new file +8 -0
+################################################################################
+#
+# easyframes
+#
+################################################################################
+
+EASYFRAMES_VERSION = v0.3
+EASYFRAMES_SITE = $(call github,microchip-ung,easyframes,$(EASYFRAMES_VERSION))

I changed this so that the version is just 0.3. Indeed, we want our _VERSION variable to not have any "v" prefix, so that its value can be matched against what release-monitoring.org is reporting for upstream projects.

Quoted 1 line

+EASYFRAMES_INSTALL_STAGING = YES

I dropped this line, since easyframes does not install a library.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com