Skip to contentSkip to conversation

bus: arm-integrator-lm: Add of_node_put() before return statement

PATCH In review Sumera Priyadarsini 2 participants 2 messages Aug 29, 2020 – Sep 12, 2020 Arm integrator, versatile and realview support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bus: arm-integrator-lm: Add of_node_put() before return statement

Every iteration of for_each_available_child_of_node() decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak.

Fix a potential memory leak in arm-integrator-lm.c by inserting of_node_put() before a return statement.

Issue found with Coccinelle.

---
 drivers/bus/arm-integrator-lm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/bus/arm-integrator-lm.c +1 -0
index 845b6c43fef8..2344d560b144 100644
@@ -54,6 +54,7 @@ static int integrator_lm_populate(int num, struct device *dev)
 			ret = of_platform_default_populate(child, NULL, dev);
 			if (ret) {
 				dev_err(dev, "failed to populate module\n");
+				of_node_put(child);
 				return ret;
 			}
 		}
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · Sumera Priyadarsini

Every iteration of for_each_available_child_of_node() decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak.

Quoted 6 lines

Fix a potential memory leak in arm-integrator-lm.c by inserting of_node_put() before a return statement.

Issue found with Coccinelle.

Patch applied.

Yours,
Linus Walleij