infra/kconfig-package: quote HOSTCC_NOCCACHE
PATCH 1/1 infra/kconfig-package: quote HOSTCC_NOCCACHE
HOSTCC may contain spaces, so needs to be quoted.
Most of the places hwere it is already quoted use double-quotes, so we use that.
--- package/pkg-kconfig.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-kconfig.mk +1 -1
@@ -28,7 +28,7 @@ define kconfig-package-update-config endef PKG_KCONFIG_COMMON_OPTS = \ - HOSTCC=$(HOSTCC_NOCCACHE) + HOSTCC="$(HOSTCC_NOCCACHE)" # Macro to save the defconfig file # $(1): the name of the package in upper-case letters
Signature · 1 line
2.20.1
PATCH 1/1 infra/kconfig-package: quote HOSTCC_NOCCACHE
Hello,
Quoted 1 line · On Sat, 29 Aug 2020 22:42:52 +0200 "Yann E. MORIN" <[email protected]>…
HOSTCC may contain spaces, so needs to be quoted.
HOSTCC yes, but HOSTCC_NOCCACHE ?
Quoted 5 lines
Most of the places hwere it is already quoted use double-quotes, so we use that.
Signed-off-by Yann E. MORIN <[email protected]>Cc Thomas Petazzoni <[email protected]>
Minor nit: the commit title prefix should be package/pkg-kconfig.mk.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 infra/kconfig-package: quote HOSTCC_NOCCACHE
Thomas, All,
On 2020-08-29 22:54 +0200, Thomas Petazzoni spake thusly:
Quoted 4 lines
Quoted 1 line · On Sat, 29 Aug 2020 22:42:52 +0200 "Yann E. MORIN" <[email protected]>…
HOSTCC may contain spaces, so needs to be quoted.
HOSTCC yes, but
HOSTCC_NOCCACHE?
Yes, why not?
$ make HOSTCC="distcc gcc-4.1"
which would yield a HOSTCC_MOCCACHE with a space in it.
Note also that HOSTCC_NOCCACHE is already quoted in most places it is used.
Regards,
Yann E. MORIN.
Quoted 13 lines
Quoted 5 lines
Most of the places hwere it is already quoted use double-quotes, so we use that.
Signed-off-by Yann E. MORIN <[email protected]>Cc Thomas Petazzoni <[email protected]>Minor nit: the commit title prefix should be
package/pkg-kconfig.mk.Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'