ARM: dts: exynos: Silence i2c-gpio dtschema warning in Galaxy I9100
Subsystems (2)
Krzysztof Kozlowski
maintainerPATCH 1/33 ARM: dts: exynos: Silence i2c-gpio dtschema warning in Galaxy I9100
The name of I2C controller over GPIO lines node ends with '-gpio' which confuses dtschema:
/arch/arm/boot/dts/exynos4210-i9100.dt.yaml: /: i2c-gpio:
{'compatible': ['i2c-gpio'], ... 'maxim,over-volt': [[4500]]}} is not of type 'array' From schema: lib/python3.6/site-packages/dtschema/schemas/gpio/gpio-consumer.yaml
Add a '-0' suffix to silence it. This pattern on naming i2c-gpio is already present in many other dts. No functional change.
--- arch/arm/boot/dts/exynos4210-i9100.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4210-i9100.dts +1 -1
@@ -123,7 +123,7 @@ reset-gpios = <&gpl1 2 GPIO_ACTIVE_LOW>; }; - i2c_max17042_fuel: i2c-gpio { + i2c_max17042_fuel: i2c-gpio-0 { compatible = "i2c-gpio"; #address-cells = <1>; #size-cells = <0>;
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 2/33 ARM: dts: exynos: Correct GPU regulator properties in Galaxy I9100
The regulator property 'regulator-microvolt-offset' should be put next to regulator definition, not consumer.
The property 'regulator-microsecs-delay' is not valid at all.
--- arch/arm/boot/dts/exynos4210-i9100.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/exynos4210-i9100.dts +1 -2
@@ -304,8 +304,6 @@ status = "okay"; mali-supply = <&vg3d_breg>; - regulator-microvolt-offset = <50000>; - regulator-microsecs-delay = <50>; }; &hsotg {
@@ -524,6 +522,7 @@ regulator-name = "G3D_1.1V"; regulator-min-microvolt = <900000>; regulator-max-microvolt = <1200000>; + regulator-microvolt-offset = <50000>; regulator-always-on; };
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 3/33 ARM: dts: exynos: Correct S3C RTC bindings and enable it in Galaxy I9100
In reply to Krzysztof KozlowskiThe S3C RTC requires 32768 Hz clock as input which is provided by PMIC (Maxim MAX8997). However there is no clock provided for the PMIC and the driver registers the clock as regulator. This is an old driver which will not be updated so add a workaround:
1. Enable the "clock" regulator in PMIC,
2. Add a fixed-clock to fill missing clock phandle reference in S3C RTC.
This allows to enable the S3C RTC and fixes dtbs_check warnings:
arch/arm/boot/dts/exynos4210-i9100.dt.yaml: rtc@10070000: clocks: [[5, 346]] is too short arch/arm/boot/dts/exynos4210-i9100.dt.yaml: rtc@10070000: clock-names: ['rtc'] is too short
--- arch/arm/boot/dts/exynos4210-i9100.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
arch/arm/boot/dts/exynos4210-i9100.dts +18 -0
@@ -209,6 +209,13 @@ compatible = "samsung,clock-xusbxti"; clock-frequency = <24000000>; }; + + pmic_ap_clk: pmic-ap-clk { + /* Workaround for missing clock on max8997 PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; }; thermal-zones {
@@ -568,6 +575,11 @@ regulator-max-microvolt = <4100000>; regulator-always-on; }; + + EN32KHZ_AP { + regulator-name = "EN32KHZ_AP"; + regulator-always-on; + }; }; }; };
@@ -688,6 +700,12 @@ }; }; +&rtc { + status = "okay"; + clocks = <&clock CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; +}; + &sdhci_0 { status = "okay";
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 4/33 ARM: dts: exynos: Correct S3C RTC bindings and enable it in Origen
In reply to Krzysztof KozlowskiThe S3C RTC requires 32768 Hz clock as input which is provided by PMIC (Maxim MAX8997). However there is no clock provided for the PMIC and the driver registers the clock as regulator. This is an old driver which will not be updated so add a workaround:
1. Enable the "clock" regulator in PMIC,
2. Add a fixed-clock to fill missing clock phandle reference in S3C RTC.
This allows to enable the S3C RTC and fixes dtbs_check warnings:
arch/arm/boot/dts/exynos4210-origen.dt.yaml: rtc@10070000: clocks: [[5, 346]] is too short arch/arm/boot/dts/exynos4210-origen.dt.yaml: rtc@10070000: clock-names: ['rtc'] is too short
--- arch/arm/boot/dts/exynos4210-origen.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
arch/arm/boot/dts/exynos4210-origen.dts +14 -0
@@ -100,6 +100,13 @@ compatible = "samsung,clock-xusbxti"; clock-frequency = <24000000>; }; + + pmic_ap_clk: pmic-ap-clk { + /* Workaround for missing clock on max8997 PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; }; display-timings {
@@ -286,6 +293,11 @@ regulator-boot-on; regulator-always-on; }; + + EN32KHZ_AP { + regulator-name = "EN32KHZ_AP"; + regulator-always-on; + }; }; }; };
@@ -331,6 +343,8 @@ &rtc { status = "okay"; + clocks = <&clock CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; }; &tmu {
Signature · 1 line
2.17.1
Re: [PATCH 04/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Origen
Quoted 7 lines · Krzysztof Kozlowski
The S3C RTC requires 32768 Hz clock as input which is provided by PMIC (Maxim MAX8997). However there is no clock provided for the PMIC and the driver registers the clock as regulator. This is an old driver which will not be updated so add a workaround:
1. Enable the "clock" regulator in PMIC,
2. Add a fixed-clock to fill missing clock phandle reference in S3C RTC.
Quoted 6 lines
This allows to enable the S3C RTC and fixes
dtbs_checkwarnings:arch/arm/boot/dts/exynos4210-origen.dt.yaml: rtc@10070000: clocks: [[5, 346]] is too short arch/arm/boot/dts/exynos4210-origen.dt.yaml: rtc@10070000: clock-names: ['rtc'] is too shortSigned-off-by Krzysztof Kozlowski <[email protected]>
Confirmed, this workaround enables s3c-rtc driver operation on this board.
Quoted 35 lines
--- arch/arm/boot/dts/exynos4210-origen.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)arch/arm/boot/dts/exynos4210-origen.dts +12
-0@@ -100,6 +100,13 @@ compatible = "samsung,clock-xusbxti"; clock-frequency = <24000000>; }; + + pmic_ap_clk: pmic-ap-clk { + /* Workaround for missing clock on max8997 PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; }; display-timings {@@ -286,6 +293,11 @@ regulator-boot-on; regulator-always-on; }; + + EN32KHZ_AP { + regulator-name = "EN32KHZ_AP"; + regulator-always-on; + }; }; }; };
arch/arm/boot/dts/exynos4210-origen.dts line 350
Quoted 8 lines
arch/arm/boot/dts/exynos4210-origen.dts +2
-0@@ -331,6 +343,8 @@ &rtc { status = "okay"; + clocks = <&clock CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; }; &tmu {
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Krzysztof Kozlowski
maintainerPATCH 5/33 ARM: dts: exynos: Correct S3C RTC bindings and enable it in Trats
In reply to Krzysztof KozlowskiThe S3C RTC requires 32768 Hz clock as input which is provided by PMIC (Maxim MAX8997). However there is no clock provided for the PMIC and the driver registers the clock as regulator. This is an old driver which will not be updated so add a workaround:
1. Enable the "clock" regulator in PMIC,
2. Add a fixed-clock to fill missing clock phandle reference in S3C RTC.
This allows to enable the S3C RTC and fixes dtbs_check warnings:
arch/arm/boot/dts/exynos4210-trats.dt.yaml: rtc@10070000: clocks: [[5, 346]] is too short arch/arm/boot/dts/exynos4210-trats.dt.yaml: rtc@10070000: clock-names: ['rtc'] is too short
--- arch/arm/boot/dts/exynos4210-trats.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
arch/arm/boot/dts/exynos4210-trats.dts +18 -0
@@ -132,6 +132,13 @@ compatible = "samsung,clock-xusbxti"; clock-frequency = <24000000>; }; + + pmic_ap_clk: pmic-ap-clk { + /* Workaround for missing clock on max8997 PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; }; thermal-zones {
@@ -444,10 +451,21 @@ regulator-name = "SAFEOUT2"; regulator-boot-on; }; + + EN32KHZ_AP { + regulator-name = "EN32KHZ_AP"; + regulator-always-on; + }; }; }; }; +&rtc { + status = "okay"; + clocks = <&clock CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; +}; + &sdhci_0 { bus-width = <8>; non-removable;
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 05/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Trats
Quoted 7 lines · Krzysztof Kozlowski
The S3C RTC requires 32768 Hz clock as input which is provided by PMIC (Maxim MAX8997). However there is no clock provided for the PMIC and the driver registers the clock as regulator. This is an old driver which will not be updated so add a workaround:
1. Enable the "clock" regulator in PMIC,
2. Add a fixed-clock to fill missing clock phandle reference in S3C RTC.
Quoted 6 lines
This allows to enable the S3C RTC and fixes
dtbs_checkwarnings:arch/arm/boot/dts/exynos4210-trats.dt.yaml: rtc@10070000: clocks: [[5, 346]] is too short arch/arm/boot/dts/exynos4210-trats.dt.yaml: rtc@10070000: clock-names: ['rtc'] is too shortSigned-off-by Krzysztof Kozlowski <[email protected]>
Confirmed, this workaround enables s3c-rtc driver operation on this board.
Quoted 34 lines
--- arch/arm/boot/dts/exynos4210-trats.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)arch/arm/boot/dts/exynos4210-trats.dts +12
-0@@ -132,6 +132,13 @@ compatible = "samsung,clock-xusbxti"; clock-frequency = <24000000>; }; + + pmic_ap_clk: pmic-ap-clk { + /* Workaround for missing clock on max8997 PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; }; thermal-zones {@@ -444,10 +451,21 @@ regulator-name = "SAFEOUT2"; regulator-boot-on; }; + + EN32KHZ_AP { + regulator-name = "EN32KHZ_AP"; + regulator-always-on; + }; }; }; };
arch/arm/boot/dts/exynos4210-trats.dts line 471
Quoted 10 lines
arch/arm/boot/dts/exynos4210-trats.dts +6
-0+&rtc { + status = "okay"; + clocks = <&clock CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; +}; + &sdhci_0 { bus-width = <8>; non-removable;
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Krzysztof Kozlowski
maintainerPATCH 6/33 ARM: dts: exynos: Correct S3C RTC bindings and enable it in Universal C210
In reply to Krzysztof KozlowskiThe S3C RTC requires 32768 Hz clock as input which is provided by PMIC. However there is no clock provided for the PMIC and the driver registers the clock as regulator. This is an old driver which will not be updated so add a workaround - add a fixed-clock to fill missing clock phandle reference in S3C RTC. The "clock" regulator in PMIC is already present and enabled.
This allows to enable the S3C RTC and fixes dtbs_check warnings:
arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml: rtc@10070000: clocks: [[5, 346]] is too short arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml: rtc@10070000: clock-names: ['rtc'] is too short
--- arch/arm/boot/dts/exynos4210-universal_c210.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm/boot/dts/exynos4210-universal_c210.dts +13 -0
@@ -39,6 +39,13 @@ compatible = "samsung,clock-xusbxti"; clock-frequency = <24000000>; }; + + pmic_ap_clk: pmic-ap-clk { + /* Workaround for missing clock on PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; }; vemmc_reg: voltage-regulator {
@@ -537,6 +544,12 @@ status = "okay"; }; +&rtc { + status = "okay"; + clocks = <&clock CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; +}; + &sdhci_0 { bus-width = <8>; non-removable;
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 06/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Universal C210
Quoted 7 lines · Krzysztof Kozlowski
The S3C RTC requires 32768 Hz clock as input which is provided by PMIC. However there is no clock provided for the PMIC and the driver registers the clock as regulator. This is an old driver which will not be updated so add a workaround - add a fixed-clock to fill missing clock phandle reference in S3C RTC. The "clock" regulator in PMIC is already present and enabled.
Quoted 6 lines
This allows to enable the S3C RTC and fixes
dtbs_checkwarnings:arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml: rtc@10070000: clocks: [[5, 346]] is too short arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml: rtc@10070000: clock-names: ['rtc'] is too shortSigned-off-by Krzysztof Kozlowski <[email protected]>
Confirmed, this workaround enables s3c-rtc driver operation on this board.
Quoted 25 lines
--- arch/arm/boot/dts/exynos4210-universal_c210.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)arch/arm/boot/dts/exynos4210-universal_c210.dts +7
-0@@ -39,6 +39,13 @@ compatible = "samsung,clock-xusbxti"; clock-frequency = <24000000>; }; + + pmic_ap_clk: pmic-ap-clk { + /* Workaround for missing clock on PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; }; vemmc_reg: voltage-regulator {@@ -537,6 +544,12 @@ status = "okay"; };
arch/arm/boot/dts/exynos4210-universal_c210.dts line 555
Quoted 10 lines
arch/arm/boot/dts/exynos4210-universal_c210.dts +6
-0+&rtc { + status = "okay"; + clocks = <&clock CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; +}; + &sdhci_0 { bus-width = <8>; non-removable;
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Krzysztof Kozlowski
maintainerPATCH 7/33 ARM: dts: exynos: Correct S3C RTC bindings in SMDKv310
In reply to Krzysztof KozlowskiThe S3C RTC requires 32768 Hz clock as input which is provided by PMIC. However there is no clock provided for the PMIC and the driver registers the clock as regulator. This is an old driver which will not be updated so add a workaround - a fixed-clock to fill missing clock phandle reference in S3C RTC.
This allows to enable the S3C RTC and fixes dtbs_check warnings:
arch/arm/boot/dts/exynos4210-smdkv310.dt.yaml: rtc@10070000: clocks: [[5, 346]] is too short arch/arm/boot/dts/exynos4210-smdkv310.dt.yaml: rtc@10070000: clock-names: ['rtc'] is too short
--- arch/arm/boot/dts/exynos4210-smdkv310.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/arm/boot/dts/exynos4210-smdkv310.dts +12 -0
@@ -40,6 +40,13 @@ compatible = "samsung,clock-xusbxti"; clock-frequency = <24000000>; }; + + pmic_ap_clk: pmic-ap-clk { + /* Workaround for missing clock on PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; }; };
@@ -148,6 +155,11 @@ }; }; +&rtc { + clocks = <&clock CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; +}; + &sdhci_2 { bus-width = <4>; pinctrl-names = "default";
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 8/33 ARM: dts: exynos: Add and enable 32 kHz modem clock in Galaxy I9100
In reply to Krzysztof KozlowskiThe PMIC has a 32768 Hz clock used by the modem which is implemented by driver as a regulator. Add and enable it to be sure modem get's its signal.
--- arch/arm/boot/dts/exynos4210-i9100.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/exynos4210-i9100.dts +5 -0
@@ -580,6 +580,11 @@ regulator-name = "EN32KHZ_AP"; regulator-always-on; }; + + EN32KHZ_CP { + regulator-name = "EN32KHZ_CP"; + regulator-always-on; + }; }; }; };
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerRe: [PATCH 08/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Galaxy I9100
Quoted 8 lines · Krzysztof Kozlowski
The PMIC has a 32768 Hz clock used by the modem which is implemented by driver as a regulator. Add and enable it to be sure modem get's its signal.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/boot/dts/exynos4210-i9100.dts | 5 +++++ 1 file changed, 5 insertions(+)
Applied all 1-8. Skipping 9th patch.
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerPATCH 9/33 ARM: dts: exynos: Add and enable 32 kHz modem clock in Origen
In reply to Krzysztof KozlowskiThe PMIC has a 32768 Hz clock used by the modem which is implemented by driver as a regulator. Add and enable it to be sure modem get's its signal.
--- arch/arm/boot/dts/exynos4210-origen.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/exynos4210-origen.dts +5 -0
@@ -298,6 +298,11 @@ regulator-name = "EN32KHZ_AP"; regulator-always-on; }; + + EN32KHZ_CP { + regulator-name = "EN32KHZ_CP"; + regulator-always-on; + }; }; }; };
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 09/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Origen
Hi Krzysztof,
Quoted 5 lines · Krzysztof Kozlowski
The PMIC has a 32768 Hz clock used by the modem which is implemented by driver as a regulator. Add and enable it to be sure modem get's its signal.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Origen board doesn't have any modem/cp, so I see no point in enabling this clock.
Quoted 10 lines
--- arch/arm/boot/dts/exynos4210-origen.dts | 5 +++++ 1 file changed, 5 insertions(+)arch/arm/boot/dts/exynos4210-origen.dts +0
-0@@ -298,6 +298,11 @@ regulator-name = "EN32KHZ_AP";
arch/arm/boot/dts/exynos4210-origen.dts line 308
Quoted 10 lines
arch/arm/boot/dts/exynos4210-origen.dts +5
-0regulator-always-on; }; + + EN32KHZ_CP { + regulator-name = "EN32KHZ_CP"; + regulator-always-on; + }; }; }; };
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Krzysztof Kozlowski
maintainerRe: [PATCH 09/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Origen
Quoted 4 lines · Marek Szyprowski
Hi Krzysztof,
On 30.08.2020 15:51, Krzysztof Kozlowski wrote:
Quoted 8 lines
Quoted 5 lines
The PMIC has a 32768 Hz clock used by the modem which is implemented by driver as a regulator. Add and enable it to be sure modem get's its signal.
Signed-off-by Krzysztof Kozlowski <[email protected]>Origen board doesn't have any modem/cp, so I see no point in enabling this clock.
Good point, thanks for review.
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerPATCH 10/33 ARM: dts: exynos: Add and enable 32 kHz modem clock in Trats
In reply to Krzysztof KozlowskiThe PMIC has a 32768 Hz clock used by the modem which is implemented by driver as a regulator. Add and enable it to be sure modem get's its signal.
--- arch/arm/boot/dts/exynos4210-trats.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/exynos4210-trats.dts +5 -0
@@ -456,6 +456,11 @@ regulator-name = "EN32KHZ_AP"; regulator-always-on; }; + + EN32KHZ_CP { + regulator-name = "EN32KHZ_CP"; + regulator-always-on; + }; }; }; };
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 11/33 ARM: dts: exynos: Remove empty camera pinctrl configuration in Trats
In reply to Krzysztof KozlowskiThe camera's pinctrl configuration is simply empty and not effective. Remove it to fix dtbs_check warning:
arch/arm/boot/dts/exynos4210-trats.dt.yaml: camera: pinctrl-0: True is not of type 'array'
--- arch/arm/boot/dts/exynos4210-trats.dts | 2 -- 1 file changed, 2 deletions(-)
arch/arm/boot/dts/exynos4210-trats.dts +0 -2
@@ -159,8 +159,6 @@ }; &camera { - pinctrl-names = "default"; - pinctrl-0 = <>; status = "okay"; };
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 12/33 ARM: dts: exynos: Remove empty camera pinctrl configuration in Universal C210
In reply to Krzysztof KozlowskiThe camera's pinctrl configuration is simply empty and not effective. Remove it to fix dtbs_check warning:
arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml: camera: pinctrl-0: True is not of type 'array'
--- arch/arm/boot/dts/exynos4210-universal_c210.dts | 3 --- 1 file changed, 3 deletions(-)
arch/arm/boot/dts/exynos4210-universal_c210.dts +0 -3
@@ -190,9 +190,6 @@ &camera { status = "okay"; - - pinctrl-names = "default"; - pinctrl-0 = <>; }; &cpu0 {
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 13/33 ARM: dts: exynos: Align SPI GPIO node name with dtschema in Universal C210
In reply to Krzysztof KozlowskiThe device tree schema expects SPI controller to be named "spi", otherwise dtbs_check complain with a warning like:
arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml: spi-lcd:
$nodename:0: 'spi-lcd' does not match '^spi(@.*|-[0-9a-f])*$'
--- arch/arm/boot/dts/exynos4210-universal_c210.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4210-universal_c210.dts +1 -1
@@ -119,7 +119,7 @@ enable-active-high; }; - spi-lcd { + spi-3 { compatible = "spi-gpio"; #address-cells = <1>; #size-cells = <0>;
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 14/33 ARM: dts: exynos: Replace deprecated GPIO spi-gpio properties in Universal C210
In reply to Krzysztof Kozlowski"gpio-sck" and "gpio-mosi" are deprecated so update the DTS to fix dtbs_checks warnings like:
arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml: spi-lcd:
gpio-sck: False schema does not allow [[85, 1, 0]]
--- arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/exynos4210-universal_c210.dts +2 -2
@@ -124,8 +124,8 @@ #address-cells = <1>; #size-cells = <0>; - gpio-sck = <&gpy3 1 GPIO_ACTIVE_HIGH>; - gpio-mosi = <&gpy3 3 GPIO_ACTIVE_HIGH>; + sck-gpios = <&gpy3 1 GPIO_ACTIVE_HIGH>; + mosi-gpios = <&gpy3 3 GPIO_ACTIVE_HIGH>; num-chipselects = <1>; cs-gpios = <&gpy4 3 GPIO_ACTIVE_LOW>;
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [RFT 14/33] ARM: dts: exynos: Replace deprecated GPIO spi-gpio properties in Universal C210
Quoted 7 lines · Krzysztof Kozlowski
"gpio-sck" and "gpio-mosi" are deprecated so update the DTS to fix
dtbs_checkswarnings like:
arch/arm/boot/dts/exynos4210-universal_c210.dt.yaml: spi-lcd:
gpio-sck: False schema does not allow [[85, 1, 0]]Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 9 lines
--- arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/exynos4210-universal_c210.dts +0
-0
arch/arm/boot/dts/exynos4210-universal_c210.dts line 131
Quoted 10 lines
arch/arm/boot/dts/exynos4210-universal_c210.dts +2
-2@@ -124,8 +124,8 @@ #address-cells = <1>; #size-cells = <0>; - gpio-sck = <&gpy3 1 GPIO_ACTIVE_HIGH>; - gpio-mosi = <&gpy3 3 GPIO_ACTIVE_HIGH>; + sck-gpios = <&gpy3 1 GPIO_ACTIVE_HIGH>; + mosi-gpios = <&gpy3 3 GPIO_ACTIVE_HIGH>; num-chipselects = <1>; cs-gpios = <&gpy4 3 GPIO_ACTIVE_LOW>;
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Krzysztof Kozlowski
maintainerPATCH 15/33 ARM: dts: exynos: Align SPI GPIO node name with dtschema in Galaxy I9100
In reply to Krzysztof KozlowskiThe device tree schema expects SPI controller to be named "spi", otherwise dtbs_check complain with a warning like:
arch/arm/boot/dts/exynos4210-i9100.dt.yaml: spi-lcd:
$nodename:0: 'spi-lcd' does not match '^spi(@.*|-[0-9a-f])*$'
--- arch/arm/boot/dts/exynos4210-i9100.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4210-i9100.dts +1 -1
@@ -147,7 +147,7 @@ }; }; - spi-lcd { + spi-3 { compatible = "spi-gpio"; #address-cells = <1>; #size-cells = <0>;
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 16/33 ARM: dts: exynos: Override thermal by label in Exynos4210
In reply to Krzysztof KozlowskiUsing full paths to extend or override a device tree node is error prone since if there was a typo error, a new node will be created instead of extending the node as it was desired. This will lead to run-time errors that could be hard to detect.
A mistyped label on the other hand, will cause a dtc compile error (during build time).
--- arch/arm/boot/dts/exynos4210.dtsi | 36 +++++++++++++++---------------- 1 file changed, 17 insertions(+), 19 deletions(-)
arch/arm/boot/dts/exynos4210.dtsi +17 -19
@@ -365,26 +365,24 @@ }; }; }; +}; - thermal-zones { - cpu_thermal: cpu-thermal { - polling-delay-passive = <0>; - polling-delay = <0>; - thermal-sensors = <&tmu 0>; - - trips { - cpu_alert0: cpu-alert-0 { - temperature = <85000>; /* millicelsius */ - }; - cpu_alert1: cpu-alert-1 { - temperature = <100000>; /* millicelsius */ - }; - cpu_alert2: cpu-alert-2 { - temperature = <110000>; /* millicelsius */ - }; - }; - }; - }; +&cpu_alert0 { + temperature = <85000>; /* millicelsius */ +}; + +&cpu_alert1 { + temperature = <100000>; /* millicelsius */ +}; + +&cpu_alert2 { + temperature = <110000>; /* millicelsius */ +}; + +&cpu_thermal { + polling-delay-passive = <0>; + polling-delay = <0>; + thermal-sensors = <&tmu 0>; }; &gic {
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 17/33 ARM: dts: exynos: Override thermal by label in Galaxy I9000
In reply to Krzysztof KozlowskiUsing full paths to extend or override a device tree node is error prone since if there was a typo error, a new node will be created instead of extending the node as it was desired. This will lead to run-time errors that could be hard to detect.
A mistyped label on the other hand, will cause a dtc compile error (during build time).
--- arch/arm/boot/dts/exynos4210-i9100.dts | 28 ++++++++++++-------------- 1 file changed, 13 insertions(+), 15 deletions(-)
arch/arm/boot/dts/exynos4210-i9100.dts +13 -15
@@ -217,21 +217,6 @@ clock-frequency = <32768>; }; }; - - thermal-zones { - cpu_thermal: cpu-thermal { - cooling-maps { - map0 { - /* Corresponds to 800MHz */ - cooling-device = <&cpu0 2 2>; - }; - map1 { - /* Corresponds to 200MHz */ - cooling-device = <&cpu0 4 4>; - }; - }; - }; - }; }; &camera {
@@ -242,6 +227,19 @@ cpu0-supply = <&varm_breg>; }; +&cpu_thermal { + cooling-maps { + map0 { + /* Corresponds to 800MHz */ + cooling-device = <&cpu0 2 2>; + }; + map1 { + /* Corresponds to 200MHz */ + cooling-device = <&cpu0 4 4>; + }; + }; +}; + &ehci { status = "okay";
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 18/33 ARM: dts: exynos: Override thermal by label in Trats
In reply to Krzysztof KozlowskiUsing full paths to extend or override a device tree node is error prone since if there was a typo error, a new node will be created instead of extending the node as it was desired. This will lead to run-time errors that could be hard to detect.
A mistyped label on the other hand, will cause a dtc compile error (during build time).
--- arch/arm/boot/dts/exynos4210-trats.dts | 29 ++++++++++++-------------- 1 file changed, 13 insertions(+), 16 deletions(-)
arch/arm/boot/dts/exynos4210-trats.dts +13 -16
@@ -140,22 +140,6 @@ clock-frequency = <32768>; }; }; - - thermal-zones { - cpu_thermal: cpu-thermal { - cooling-maps { - map0 { - /* Corresponds to 800MHz at freq_table */ - cooling-device = <&cpu0 2 2>, <&cpu1 2 2>; - }; - map1 { - /* Corresponds to 200MHz at freq_table */ - cooling-device = <&cpu0 4 4>, <&cpu1 4 4>; - }; - }; - }; - }; - }; &camera {
@@ -166,6 +150,19 @@ cpu0-supply = <&varm_breg>; }; +&cpu_thermal { + cooling-maps { + map0 { + /* Corresponds to 800MHz at freq_table */ + cooling-device = <&cpu0 2 2>, <&cpu1 2 2>; + }; + map1 { + /* Corresponds to 200MHz at freq_table */ + cooling-device = <&cpu0 4 4>, <&cpu1 4 4>; + }; + }; +}; + &dsi_0 { vddcore-supply = <&vusb_reg>; vddio-supply = <&vmipi_reg>;
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 19/33 ARM: dts: exynos: Add CPU cooling in Origen
In reply to Krzysztof KozlowskiAdd missing cooling devices for CPU thermal zones in Exynos4210 Origen board. This allows to scale down CPU frequency (and voltage) in case of thermal pressure.
---
Not tested on HW.
--- arch/arm/boot/dts/exynos4210-origen.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm/boot/dts/exynos4210-origen.dts +13 -0
@@ -129,6 +129,19 @@ cpu0-supply = <&buck1_reg>; }; +&cpu_thermal { + cooling-maps { + map0 { + /* Corresponds to 800MHz */ + cooling-device = <&cpu0 2 2>; + }; + map1 { + /* Corresponds to 200MHz */ + cooling-device = <&cpu0 4 4>; + }; + }; +}; + &exynos_usbphy { status = "okay"; };
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 20/33 ARM: dts: exynos: Add CPU cooling in SMDKv310
In reply to Krzysztof KozlowskiAdd missing cooling devices for CPU thermal zones in Exynos4210 SMDKv310 board. This allows to scale down CPU frequency (and voltage) in case of thermal pressure.
--- arch/arm/boot/dts/exynos4210-smdkv310.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm/boot/dts/exynos4210-smdkv310.dts +13 -0
@@ -50,6 +50,19 @@ }; }; +&cpu_thermal { + cooling-maps { + map0 { + /* Corresponds to 800MHz */ + cooling-device = <&cpu0 2 2>; + }; + map1 { + /* Corresponds to 200MHz */ + cooling-device = <&cpu0 4 4>; + }; + }; +}; + &i2c_0 { #address-cells = <1>; #size-cells = <0>;
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 21/33 ARM: dts: exynos: Add CPU cooling in Universal C210
In reply to Krzysztof KozlowskiAdd missing cooling devices for CPU thermal zones in Exynos4210 Universal C310 board. This allows to scale down CPU frequency (and voltage) in case of thermal pressure.
--- arch/arm/boot/dts/exynos4210-universal_c210.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
arch/arm/boot/dts/exynos4210-universal_c210.dts +13 -0
@@ -196,6 +196,19 @@ cpu0-supply = <&vdd_arm_reg>; }; +&cpu_thermal { + cooling-maps { + map0 { + /* Corresponds to 800MHz */ + cooling-device = <&cpu0 2 2>; + }; + map1 { + /* Corresponds to 200MHz */ + cooling-device = <&cpu0 4 4>; + }; + }; +}; + &ehci { status = "okay"; phys = <&exynos_usbphy 1>;
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 22/33 ARM: dts: exynos: Align MHL GPIO pin configuration with dtschema on Galaxy I9100
In reply to Krzysztof KozlowskiAlign the name of mag-mhl-gpio node to avoid dtschema confusion and dtbs_check warning:
arch/arm/boot/dts/exynos4210-i9100.dt.yaml: pinctrl@11000000: mag-mhl-gpio:
{'samsung,pins': ['gpd0-2'], 'samsung,pin-function': [[3]], 'samsung,pin-pud': [[0]]} is not of type 'array' From schema: dtschema/schemas/gpio/gpio-consumer.yaml
--- arch/arm/boot/dts/exynos4210-i9100.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4210-i9100.dts +1 -1
@@ -681,7 +681,7 @@ samsung,pin-val = <0>; }; - mag_mhl_gpio: mag-mhl-gpio { + mag_mhl_gpio: mag-mhl { samsung,pins = "gpd0-2"; samsung,pin-function = <EXYNOS_PIN_FUNC_3>; samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerRe: [PATCH 22/33] ARM: dts: exynos: Align MHL GPIO pin configuration with dtschema on Galaxy I9100
Quoted 11 lines · Krzysztof Kozlowski
Align the name of mag-mhl-gpio node to avoid dtschema confusion and
dtbs_checkwarning:
arch/arm/boot/dts/exynos4210-i9100.dt.yaml: pinctrl@11000000: mag-mhl-gpio:
{'samsung,pins': ['gpd0-2'], 'samsung,pin-function': [[3]], 'samsung,pin-pud': [[0]]} is not of type 'array' From schema:dtschema/schemas/gpio/gpio-consumer.yamlSigned-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/boot/dts/exynos4210-i9100.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied 13-22.
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerPATCH 23/33 ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
In reply to Krzysztof KozlowskiThe camera's pinctrl configuration is simply empty and not effective. Remove it to fix dtbs_check warning:
arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'
--- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 -- 1 file changed, 2 deletions(-)
arch/arm/boot/dts/exynos4412-odroid-common.dtsi +0 -2
@@ -136,8 +136,6 @@ &camera { status = "okay"; - pinctrl-names = "default"; - pinctrl-0 = <>; }; &clock {
Signature · 1 line
2.17.1
Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
Hi Krzysztof,
Quoted 6 lines · Krzysztof Kozlowski
The camera's pinctrl configuration is simply empty and not effective. Remove it to fix
dtbs_checkwarning:
arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'Signed-off-by Krzysztof Kozlowski <[email protected]>
I think that this was intentional to properly enable support for mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the default values if no pinctrl properties are provided. Sylwester, could you comment?
Quoted 9 lines
--- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 -- 1 file changed, 2 deletions(-)arch/arm/boot/dts/exynos4412-odroid-common.dtsi +0
-0
arch/arm/boot/dts/exynos4412-odroid-common.dtsi line 141
Quoted 8 lines
arch/arm/boot/dts/exynos4412-odroid-common.dtsi +0
-2@@ -136,8 +136,6 @@ &camera { status = "okay"; - pinctrl-names = "default"; - pinctrl-0 = <>; }; &clock {
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Krzysztof Kozlowski
maintainerRe: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
Quoted 7 lines · Marek Szyprowski
Hi Krzysztof,
Quoted 3 lines · Krzysztof Kozlowski
The camera's pinctrl configuration is simply empty and not effective. Remove it to fix
dtbs_checkwarning:
Quoted 8 lines
Quoted 3 lines
arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'Signed-off-by Krzysztof Kozlowski <[email protected]>I think that this was intentional to properly enable support for mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the default values if no pinctrl properties are provided. Sylwester, could you comment?
Indeed it could be intentional... I see now errors:
[ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19
I wonder why getting an empty pinctrl is needed... maybe the driver should accept missing pinctrl?
Best regards,
Krzysztof
Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
Hi Krzysztof,
Quoted 12 lines · Krzysztof Kozlowski
Quoted 11 lines · Marek Szyprowski
Quoted 6 lines · Krzysztof Kozlowski
The camera's pinctrl configuration is simply empty and not effective. Remove it to fix
dtbs_checkwarning:
arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'Signed-off-by Krzysztof Kozlowski <[email protected]>I think that this was intentional to properly enable support for mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the default values if no pinctrl properties are provided. Sylwester, could you comment?
Quoted 5 lines
Indeed it could be intentional... I see now errors:
[ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19I wonder why getting an empty pinctrl is needed... maybe the driver should accept missing pinctrl?
Please ensure that you have those patches applied:
https://patchwork.kernel.org/patch/11707579/
https://patchwork.kernel.org/patch/11707577/
https://patchwork.kernel.org/patch/11705409/
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
In reply to Krzysztof KozlowskiHi,
Quoted 14 lines · Krzysztof Kozlowski
Quoted 4 lines · Marek Szyprowski
Quoted 3 lines · Krzysztof Kozlowski
The camera's pinctrl configuration is simply empty and not effective. Remove it to fix
dtbs_checkwarning:Quoted 8 lines
Quoted 3 lines
arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'Signed-off-by Krzysztof Kozlowski <[email protected]>I think that this was intentional to properly enable support for mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the default values if no pinctrl properties are provided. Sylwester, could you comment?
Quoted 5 lines
Indeed it could be intentional... I see now errors:
[ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19I wonder why getting an empty pinctrl is needed... maybe the driver should accept missing pinctrl?
It might have been better to have the pinctrl properties optional, as there might be boards without the image sensor attached and FIMC could still be used in memory-to-memory mode, as Marek pointed out. But it seems too late now to change that. The binding defines the pinctrl properties as required (Documentation/devicetree/bindings/media/samsung-fimc.txt) and we need to keep them in dtses.
--
Regards,
Sylwester
Krzysztof Kozlowski
maintainerRe: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
Quoted 24 lines · Sylwester Nawrocki
Hi,
Quoted 14 lines · Krzysztof Kozlowski
Quoted 4 lines · Marek Szyprowski
Quoted 3 lines · Krzysztof Kozlowski
The camera's pinctrl configuration is simply empty and not effective. Remove it to fix
dtbs_checkwarning:Quoted 8 lines
Quoted 3 lines
arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'Signed-off-by Krzysztof Kozlowski <[email protected]>I think that this was intentional to properly enable support for mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the default values if no pinctrl properties are provided. Sylwester, could you comment?
Quoted 5 lines
Indeed it could be intentional... I see now errors:
[ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19I wonder why getting an empty pinctrl is needed... maybe the driver should accept missing pinctrl?
Quoted 6 lines
It might have been better to have the pinctrl properties optional, as there might be boards without the image sensor attached and FIMC could still be used in memory-to-memory mode, as Marek pointed out. But it seems too late now to change that. The binding defines the pinctrl properties as required (
Documentation/devicetree/bindings/media/samsung-fimc.txt) and we need to keep them in dtses.
You can always make a required property optional and it is not a break of ABI. The other way around would be a break. Why then not changing the driver to accept optional pinctrl?
Best regards,
Krzysztof
Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
Quoted 29 lines · Krzysztof Kozlowski
Quoted 21 lines · Sylwester Nawrocki
Quoted 14 lines · Krzysztof Kozlowski
Quoted 4 lines · Marek Szyprowski
Quoted 3 lines · Krzysztof Kozlowski
The camera's pinctrl configuration is simply empty and not effective. Remove it to fix
dtbs_checkwarning:Quoted 8 lines
Quoted 3 lines
arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'Signed-off-by Krzysztof Kozlowski <[email protected]>I think that this was intentional to properly enable support for mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the default values if no pinctrl properties are provided. Sylwester, could you comment?
Quoted 5 lines
Indeed it could be intentional... I see now errors:
[ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19I wonder why getting an empty pinctrl is needed... maybe the driver should accept missing pinctrl?
Quoted 6 lines
It might have been better to have the pinctrl properties optional, as there might be boards without the image sensor attached and FIMC could still be used in memory-to-memory mode, as Marek pointed out. But it seems too late now to change that. The binding defines the pinctrl properties as required (
Documentation/devicetree/bindings/media/samsung-fimc.txt) and we need to keep them in dtses.
Quoted 3 lines
You can always make a required property optional and it is not a break of ABI. The other way around would be a break. Why then not changing the driver to accept optional pinctrl?
Feel free to send the patch, I would prefer to leave that as is though. Is it really suddenly a problem to use an empty property? The pinctrl bindings allows it.
Signature · 2 lines
Regards, Sylwester
Krzysztof Kozlowski
maintainerRe: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
Quoted 31 lines · Sylwester Nawrocki
Quoted 29 lines · Krzysztof Kozlowski
Quoted 27 lines · Sylwester Nawrocki
Quoted 14 lines · Krzysztof Kozlowski
Quoted 4 lines · Marek Szyprowski
Quoted 3 lines · Krzysztof Kozlowski
The camera's pinctrl configuration is simply empty and not effective. Remove it to fix
dtbs_checkwarning:Quoted 8 lines
Quoted 3 lines
arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'Signed-off-by Krzysztof Kozlowski <[email protected]>I think that this was intentional to properly enable support for mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the default values if no pinctrl properties are provided. Sylwester, could you comment?
Quoted 5 lines
Indeed it could be intentional... I see now errors:
[ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19I wonder why getting an empty pinctrl is needed... maybe the driver should accept missing pinctrl?
It might have been better to have the pinctrl properties optional, as there might be boards without the image sensor attached and FIMC could still be used in memory-to-memory mode, as Marek pointed out. But it seems too late now to change that. The binding defines the pinctrl properties as required (
Documentation/devicetree/bindings/media/samsung-fimc.txt) and we need to keep them in dtses.
Quoted 7 lines
Quoted 3 lines
You can always make a required property optional and it is not a break of ABI. The other way around would be a break. Why then not changing the driver to accept optional pinctrl?
Feel free to send the patch, I would prefer to leave that as is though. Is it really suddenly a problem to use an empty property? The pinctrl bindings allows it.
The bindings scream:arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'
so either we should model it differently (not as empty array), update the driver to make it optional or change the bindings/dtschema. I'll see how to fix it properly.
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerPATCH 24/33 ARM: dts: exynos: Correct compatible of fixed clocks in Midas boards
In reply to Krzysztof KozlowskiThe fixed clocks implemented by Samsung clock drivers use only one compatible so drop the additional "fixed-clock" to fix dtbs_check warnings like:
arch/arm/boot/dts/exynos4412-i9300.dt.yaml: xxti: compatible:0: 'fixed-clock' was expected
From schema: Documentation/devicetree/bindings/clock/fixed-clock.yaml
arch/arm/boot/dts/exynos4412-i9300.dt.yaml: xxti: compatible: ['samsung,clock-xxti', 'fixed-clock'] is too long arch/arm/boot/dts/exynos4412-i9300.dt.yaml: xxti: compatible: Additional items are not allowed ('fixed-clock' was unexpected) arch/arm/boot/dts/exynos4412-i9300.dt.yaml: xxti: '#clock-cells' is a required property
--- arch/arm/boot/dts/exynos4412-midas.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/exynos4412-midas.dtsi +2 -2
@@ -37,12 +37,12 @@ fixed-rate-clocks { xxti { - compatible = "samsung,clock-xxti", "fixed-clock"; + compatible = "samsung,clock-xxti"; clock-frequency = <0>; }; xusbxti { - compatible = "samsung,clock-xusbxti", "fixed-clock"; + compatible = "samsung,clock-xusbxti"; clock-frequency = <24000000>; }; };
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerRe: [PATCH 24/33] ARM: dts: exynos: Correct compatible of fixed clocks in Midas boards
Quoted 10 lines · Krzysztof Kozlowski
The fixed clocks implemented by Samsung clock drivers use only one compatible so drop the additional "fixed-clock" to fix
dtbs_checkwarnings like:
arch/arm/boot/dts/exynos4412-i9300.dt.yaml: xxti: compatible:0: 'fixed-clock' was expected
From schema:Documentation/devicetree/bindings/clock/fixed-clock.yaml
arch/arm/boot/dts/exynos4412-i9300.dt.yaml: xxti: compatible: ['samsung,clock-xxti', 'fixed-clock'] is too longarch/arm/boot/dts/exynos4412-i9300.dt.yaml: xxti: compatible: Additional items are not allowed ('fixed-clock' was unexpected)arch/arm/boot/dts/exynos4412-i9300.dt.yaml: xxti: '#clock-cells' is a required property
Quoted 4 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/boot/dts/exynos4412-midas.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied 24-33.
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerPATCH 25/33 ARM: dts: exynos: Add S5M8767 clocks for RTC in Exynos4412 Origen
In reply to Krzysztof KozlowskiAdd node for clock controller of Samsung S5M8767 PMIC. This provides the 32768 Hz clock required by S3C RTC. Except making the S3C RTC working, this also fixes dtbs_check warnings:
arch/arm/boot/dts/exynos4412-origen.dt.yaml: rtc@10070000: clocks: [[7, 346]] is too short arch/arm/boot/dts/exynos4412-origen.dt.yaml: rtc@10070000: clock-names: ['rtc'] is too short
--- arch/arm/boot/dts/exynos4412-origen.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm/boot/dts/exynos4412-origen.dts +10 -0
@@ -11,6 +11,7 @@ /dts-v1/; #include "exynos4412.dtsi" +#include <dt-bindings/clock/samsung,s2mps11.h> #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> #include "exynos-mfc-reserved-memory.dtsi"
@@ -129,6 +130,13 @@ <1200000>, <1200000>, <1200000>, <1200000>; + s5m8767_osc: clocks { + compatible = "samsung,s5m8767-clk"; + #clock-cells = <1>; + clock-output-names = "s5m8767_ap", "s5m8767_cp", + "s5m8767_bt"; + }; + regulators { ldo1_reg: LDO1 { regulator-name = "VDD_ALIVE";
@@ -499,6 +507,8 @@ &rtc { status = "okay"; + clocks = <&clock CLK_RTC>, <&s5m8767_osc S2MPS11_CLK_AP>; + clock-names = "rtc", "rtc_src"; }; &sdhci_2 {
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 26/33 ARM: dts: exynos: Override thermal by label in Midas
In reply to Krzysztof KozlowskiUsing full paths to extend or override a device tree node is error prone since if there was a typo error, a new node will be created instead of extending the node as it was desired. This will lead to run-time errors that could be hard to detect.
A mistyped label on the other hand, will cause a dtc compile error (during build time).
--- arch/arm/boot/dts/exynos4412-midas.dtsi | 34 +++++++++++-------------- 1 file changed, 15 insertions(+), 19 deletions(-)
arch/arm/boot/dts/exynos4412-midas.dtsi +15 -19
@@ -319,25 +319,6 @@ pulldown-ohm = <100000>; /* 100K */ io-channels = <&adc 2>; /* Battery temperature */ }; - - thermal-zones { - cpu_thermal: cpu-thermal { - cooling-maps { - map0 { - /* Corresponds to 800MHz at freq_table */ - cooling-device = <&cpu0 7 7>, <&cpu1 7 7>, - <&cpu2 7 7>, <&cpu3 7 7>; - }; - map1 { - /* Corresponds to 200MHz at freq_table */ - cooling-device = <&cpu0 13 13>, - <&cpu1 13 13>, - <&cpu2 13 13>, - <&cpu3 13 13>; - }; - }; - }; - }; }; &adc {
@@ -406,6 +387,21 @@ cpu0-supply = <&buck2_reg>; }; +&cpu_thermal { + cooling-maps { + map0 { + /* Corresponds to 800MHz at freq_table */ + cooling-device = <&cpu0 7 7>, <&cpu1 7 7>, + <&cpu2 7 7>, <&cpu3 7 7>; + }; + map1 { + /* Corresponds to 200MHz at freq_table */ + cooling-device = <&cpu0 13 13>, <&cpu1 13 13>, + <&cpu2 13 13>, <&cpu3 13 13>; + }; + }; +}; + &csis_0 { status = "okay"; vddcore-supply = <&ldo8_reg>;
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 27/33 ARM: dts: exynos: Override thermal by label in Exynos4412 Odroids
In reply to Krzysztof KozlowskiUsing full paths to extend or override a device tree node is error prone since if there was a typo error, a new node will be created instead of extending the node as it was desired. This will lead to run-time errors that could be hard to detect.
A mistyped label on the other hand, will cause a dtc compile error (during build time).
--- .../boot/dts/exynos4412-odroid-common.dtsi | 34 ++++++-------- arch/arm/boot/dts/exynos4412-odroidu3.dts | 46 +++++++++---------- 2 files changed, 36 insertions(+), 44 deletions(-)
arch/arm/boot/dts/exynos4412-odroid-common.dtsi +15 -19
@@ -66,25 +66,6 @@ clock-frequency = <24000000>; }; }; - - thermal-zones { - cpu_thermal: cpu-thermal { - cooling-maps { - cooling_map0: map0 { - /* Corresponds to 800MHz at freq_table */ - cooling-device = <&cpu0 7 7>, <&cpu1 7 7>, - <&cpu2 7 7>, <&cpu3 7 7>; - }; - cooling_map1: map1 { - /* Corresponds to 200MHz at freq_table */ - cooling-device = <&cpu0 13 13>, - <&cpu1 13 13>, - <&cpu2 13 13>, - <&cpu3 13 13>; - }; - }; - }; - }; }; &bus_dmc {
@@ -172,6 +153,21 @@ }; }; +&cpu_thermal { + cooling-maps { + cooling_map0: map0 { + /* Corresponds to 800MHz at freq_table */ + cooling-device = <&cpu0 7 7>, <&cpu1 7 7>, + <&cpu2 7 7>, <&cpu3 7 7>; + }; + cooling_map1: map1 { + /* Corresponds to 200MHz at freq_table */ + cooling-device = <&cpu0 13 13>, <&cpu1 13 13>, + <&cpu2 13 13>, <&cpu3 13 13>; + }; + }; +}; + &pinctrl_1 { gpio_power_key: power_key { samsung,pins = "gpx1-3";
arch/arm/boot/dts/exynos4412-odroidu3.dts +21 -25
58 lines not on this page · raw message
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 28/33 ARM: dts: exynos: Add CPU cooling in Exynos4412 Origen
In reply to Krzysztof KozlowskiAdd missing cooling devices for CPU thermal zones in Exynos4412 Origen board. This allows to scale down CPU frequency (and voltage) in case of thermal pressure.
--- arch/arm/boot/dts/exynos4412-origen.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
arch/arm/boot/dts/exynos4412-origen.dts +15 -0
@@ -75,6 +75,21 @@ cpu0-supply = <&buck2_reg>; }; +&cpu_thermal { + cooling-maps { + cooling_map0: map0 { + /* Corresponds to 800MHz at freq_table */ + cooling-device = <&cpu0 7 7>, <&cpu1 7 7>, + <&cpu2 7 7>, <&cpu3 7 7>; + }; + cooling_map1: map1 { + /* Corresponds to 200MHz at freq_table */ + cooling-device = <&cpu0 13 13>, <&cpu1 13 13>, + <&cpu2 13 13>, <&cpu3 13 13>; + }; + }; +}; + &exynos_usbphy { status = "okay"; };
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 29/33 ARM: dts: exynos: Add CPU cooling in SMDK4412
In reply to Krzysztof KozlowskiAdd missing cooling devices for CPU thermal zones in Exynos4412 SMDK4412 board. This allows to scale down CPU frequency (and voltage) in case of thermal pressure.
--- arch/arm/boot/dts/exynos4412-smdk4412.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
arch/arm/boot/dts/exynos4412-smdk4412.dts +15 -0
@@ -40,6 +40,21 @@ }; }; +&cpu_thermal { + cooling-maps { + cooling_map0: map0 { + /* Corresponds to 800MHz at freq_table */ + cooling-device = <&cpu0 7 7>, <&cpu1 7 7>, + <&cpu2 7 7>, <&cpu3 7 7>; + }; + cooling_map1: map1 { + /* Corresponds to 200MHz at freq_table */ + cooling-device = <&cpu0 13 13>, <&cpu1 13 13>, + <&cpu2 13 13>, <&cpu3 13 13>; + }; + }; +}; + &keypad { samsung,keypad-num-rows = <3>; samsung,keypad-num-columns = <8>;
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 30/33 ARM: dts: exynos: Add CPU cooling in Tiny4412
In reply to Krzysztof KozlowskiAdd missing cooling devices for CPU thermal zones in Exynos4412 Tiny4412 board. This allows to scale down CPU frequency (and voltage) in case of thermal pressure.
--- arch/arm/boot/dts/exynos4412-tiny4412.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
arch/arm/boot/dts/exynos4412-tiny4412.dts +15 -0
@@ -78,6 +78,21 @@ }; }; +&cpu_thermal { + cooling-maps { + cooling_map0: map0 { + /* Corresponds to 800MHz at freq_table */ + cooling-device = <&cpu0 7 7>, <&cpu1 7 7>, + <&cpu2 7 7>, <&cpu3 7 7>; + }; + cooling_map1: map1 { + /* Corresponds to 200MHz at freq_table */ + cooling-device = <&cpu0 13 13>, <&cpu1 13 13>, + <&cpu2 13 13>, <&cpu3 13 13>; + }; + }; +}; + &fimd { pinctrl-0 = <&lcd_clk>, <&lcd_data24>; pinctrl-names = "default";
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 31/33 ARM: dts: exynos: Correct S3C RTC bindings in SMDK4412
In reply to Krzysztof KozlowskiThe S3C RTC requires 32768 Hz clock as input which is provided by PMIC. However the PMIC is not described in DTS at all so at least add a workaround to model its clock with fixed-clock and silence dtbs_check warnings like:
arch/arm/boot/dts/exynos4412-smdk4412.dt.yaml: rtc@10070000: clocks: [[7, 346]] is too short arch/arm/boot/dts/exynos4412-smdk4412.dt.yaml: rtc@10070000: clock-names: ['rtc'] is too short
--- arch/arm/boot/dts/exynos4412-smdk4412.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/arm/boot/dts/exynos4412-smdk4412.dts +12 -0
@@ -37,6 +37,13 @@ compatible = "samsung,clock-xusbxti"; clock-frequency = <24000000>; }; + + pmic_ap_clk: pmic-ap-clk { + /* Workaround for missing clock on PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; }; };
@@ -142,6 +149,11 @@ }; }; +&rtc { + clocks = <&clock CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; +}; + &sdhci_2 { bus-width = <4>; pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sd2_cd>;
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 32/33 ARM: dts: exynos: Correct S3C RTC bindings in Tiny4412
In reply to Krzysztof KozlowskiThe S3C RTC requires 32768 Hz clock as input which is provided by PMIC. However the PMIC is not described in DTS at all so at least add a workaround to model its clock with fixed-clock. This fixes S3C RTC and silences dtbs_check warnings like:
arch/arm/boot/dts/exynos4412-tiny4412.dt.yaml: rtc@10070000: clocks: [[7, 346]] is too short arch/arm/boot/dts/exynos4412-tiny4412.dt.yaml: rtc@10070000: clock-names: ['rtc'] is too short
--- arch/arm/boot/dts/exynos4412-tiny4412.dts | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/arm/boot/dts/exynos4412-tiny4412.dts +9 -0
@@ -65,6 +65,13 @@ compatible = "samsung,clock-xusbxti"; clock-frequency = <24000000>; }; + + pmic_ap_clk: pmic-ap-clk { + /* Workaround for missing clock on PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; }; panel {
@@ -110,6 +117,8 @@ &rtc { status = "okay"; + clocks = <&clock CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; }; &sdhci_2 {
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 33/33 ARM: dts: exynos: Correct whitespace and indentation issues
In reply to Krzysztof KozlowskiRemove double space after '=' and fix indentation in Exynos3250, Exynos4210 and Exynos4412 boards.
--- arch/arm/boot/dts/exynos3250-monk.dts | 2 +- arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- arch/arm/boot/dts/exynos4210-trats.dts | 138 +++++++++--------- .../boot/dts/exynos4210-universal_c210.dts | 4 +- arch/arm/boot/dts/exynos4412-i9300.dts | 2 +- arch/arm/boot/dts/exynos4412-i9305.dts | 2 +- arch/arm/boot/dts/exynos4412-n710x.dts | 2 +- arch/arm/boot/dts/exynos4412-trats2.dts | 2 +- 8 files changed, 77 insertions(+), 77 deletions(-)
arch/arm/boot/dts/exynos3250-monk.dts +1 -1
@@ -26,7 +26,7 @@ memory@40000000 { device_type = "memory"; - reg = <0x40000000 0x1ff00000>; + reg = <0x40000000 0x1ff00000>; }; firmware@205f000 {
arch/arm/boot/dts/exynos3250-rinato.dts +1 -1
@@ -30,7 +30,7 @@ memory@40000000 { device_type = "memory"; - reg = <0x40000000 0x1ff00000>; + reg = <0x40000000 0x1ff00000>; }; firmware@205f000 {
arch/arm/boot/dts/exynos4210-trats.dts +69 -69
204 lines not on this page · raw message
arch/arm/boot/dts/exynos4210-universal_c210.dts +2 -2
@@ -49,7 +49,7 @@ }; vemmc_reg: voltage-regulator { - compatible = "regulator-fixed"; + compatible = "regulator-fixed"; regulator-name = "VMEM_VDD_2_8V"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>;
@@ -111,7 +111,7 @@ }; tsp_reg: voltage-regulator { - compatible = "regulator-fixed"; + compatible = "regulator-fixed"; regulator-name = "TSP_2_8V"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>;
arch/arm/boot/dts/exynos4412-i9300.dts +1 -1
@@ -17,7 +17,7 @@ memory@40000000 { device_type = "memory"; - reg = <0x40000000 0x40000000>; + reg = <0x40000000 0x40000000>; }; };
arch/arm/boot/dts/exynos4412-i9305.dts +1 -1
@@ -10,7 +10,7 @@ memory@40000000 { device_type = "memory"; - reg = <0x40000000 0x80000000>; + reg = <0x40000000 0x80000000>; }; };
arch/arm/boot/dts/exynos4412-n710x.dts +1 -1
@@ -8,7 +8,7 @@ memory@40000000 { device_type = "memory"; - reg = <0x40000000 0x80000000>; + reg = <0x40000000 0x80000000>; }; /* bootargs are passed in by bootloader */
arch/arm/boot/dts/exynos4412-trats2.dts +1 -1
@@ -18,7 +18,7 @@ memory@40000000 { device_type = "memory"; - reg = <0x40000000 0x40000000>; + reg = <0x40000000 0x40000000>; }; chosen {
Signature · 1 line
2.17.1
Quoted 7 lines · Krzysztof Kozlowski
The name of I2C controller over GPIO lines node ends with '-gpio' which confuses dtschema:
/arch/arm/boot/dts/exynos4210-i9100.dt.yaml: /: i2c-gpio:
{'compatible': ['i2c-gpio'], ... 'maxim,over-volt': [[4500]]}} is not of type 'array' From schema:lib/python3.6/site-packages/dtschema/schemas/gpio/gpio-consumer.yaml
Quoted 7 lines
Add a '-0' suffix to silence it. This pattern on naming i2c-gpio is already present in many other dts. No functional change.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/boot/dts/exynos4210-i9100.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied.
Best regards,
Krzysztof