Skip to contentSkip to conversation

ARM: dts: alpine: Align GIC nodename with dtschema

PATCH RESEND In review Krzysztof Kozlowski 1 participant 4 messages Aug 19, 2020 – Aug 30, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/3 ARM: dts: alpine: Align GIC nodename with dtschema

Fix dtschema validator warnings like:

    gic@fb001000: $nodename:0:
        'gic@fb001000' does not match '^interrupt-controller(@[0-9a-f,]+)*$'
---
 arch/arm/boot/dts/alpine.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/alpine.dtsi +1 -1
index d3036ea823d1..3b0675a1c460 100644
@@ -91,7 +91,7 @@
 		};
 
 		/* Interrupt Controller */
-		gic: gic@fb001000 {
+		gic: interrupt-controller@fb001000 {
 			compatible = "arm,cortex-a15-gic";
 			#interrupt-cells = <3>;
 			#size-cells = <0>;
Signature · 1 line
2.17.1
#1 lore raw

PATCH RESEND 2/3 arm64: dts: alpine: Align GIC nodename with dtschema

Fix dtschema validator warnings like:

    gic@f0100000: $nodename:0:
        'gic@f0100000' does not match '^interrupt-controller(@[0-9a-f,]+)*$'
---
 arch/arm64/boot/dts/amazon/alpine-v2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/amazon/alpine-v2.dtsi +1 -1
index d5e7e2bb4e6c..de2eaf77b1ff 100644
@@ -113,7 +113,7 @@
 				     <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
-		gic: gic@f0100000 {
+		gic: interrupt-controller@f0100000 {
 			compatible = "arm,gic-v3";
 			reg = <0x0 0xf0200000 0x0 0x10000>,	/* GIC Dist */
 			      <0x0 0xf0280000 0x0 0x200000>,	/* GICR */
Signature · 1 line
2.17.1
#2 lore raw

PATCH RESEND 3/3 arm64: dts: alpine: Fix GIC unit address

In reply to Krzysztof Kozlowski

Node unit address should be the same as first address appearing in "reg" property. Fixes DTC warning:

arch/arm64/boot/dts/al/alpine-v2.dtsi:116.38-126.5:
Warning (simple_bus_reg): /soc/interrupt-controller@f0100000: simple-bus unit address format error, expected "f0200000"

---
 arch/arm64/boot/dts/amazon/alpine-v2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/amazon/alpine-v2.dtsi +1 -1
index de2eaf77b1ff..4eb2cd14e00b 100644
@@ -113,7 +113,7 @@
 				     <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
-		gic: interrupt-controller@f0100000 {
+		gic: interrupt-controller@f0200000 {
 			compatible = "arm,gic-v3";
 			reg = <0x0 0xf0200000 0x0 0x10000>,	/* GIC Dist */
 			      <0x0 0xf0280000 0x0 0x200000>,	/* GICR */
Signature · 1 line
2.17.1