bus: arm: Add of_node_put() before break statement
PATCH 1/1 bus: arm: Add of_node_put() before break statement
Every iteration of for_each_available_child_of_node() decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak.
Fix a potential memory leak in arm-cci.c by inserting of_node_put() before a break statement.
Issue found with Coccinelle.
Signed-off-by Sumera Priyadarsini <[email protected]>
--- drivers/bus/arm-cci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/bus/arm-cci.c +3 -1
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np) i = nb_ace + nb_ace_lite; -if (i >= nb_cci_ports) +if (i >= nb_cci_ports) { +of_node_put (cp);break ; + }if (of_property_read_string (cp,"interface-type" , &match_str)) {
Signature · 1 line
2.17.1