Skip to contentSkip to conversation

package/avahi: fix building against gobject-introspection

PATCH New aduskett at gmail.com 5 participants 8 messages Aug 13, 2020 – Aug 31, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/avahi: fix building against gobject-introspection

From: Adam Duskett <[email protected]>

Currently, if gobject-introspection is built before avahi, avahi will fail to build with several undefined reference errors due to several .libs directories not being in the PATH when linking the .gir file.

To resolve this issue, do the following if gobject-introspection is selected:
- Add gobject-introspection to AVAHI_DEPENDENCIES
- Add --enable-gobject to AVAHI_CONF_OPTS
- Add the appropriate directories to GIR_EXTRA_LIBS_PATH.

Fixes:
http://autobuild.buildroot.net/results/b9bf7cea8be9231552a10e8ea828bf24394402ba

---
 package/avahi/avahi.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/avahi/avahi.mk +7 -0
index 73db37545f..3e858083af 100644
@@ -94,6 +94,13 @@ else
 AVAHI_CONF_OPTS += --disable-glib --disable-gobject
 endif
 
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+AVAHI_DEPENDENCIES += gobject-introspection
+AVAHI_CONF_OPTS += --enable-gobject
+AVAHI_MAKE_ENV += \
+	GIR_EXTRA_LIBS_PATH="$(@D)/avahi-gobject/.libs:$(@D)/avahi-common/.libs:$(@D)/avahi-client/.libs:$(@D)/avahi-glib/.libs"
+endif
+
 ifeq ($(BR2_PACKAGE_PYTHON),y)
 AVAHI_CONF_ENV += \
 	am_cv_pathless_PYTHON=python \
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 package/avahi: fix building against gobject-introspection

Hi,

Quoted 5 lines · aduskett at gmail.com

From: Adam Duskett <[email protected]>

Currently, if gobject-introspection is built before avahi, avahi will fail to build with several undefined reference errors due to several .libs directories not being in the PATH when linking the .gir file.

Happened only if BR2_PACKAGE_DBUS=y.

Quoted 9 lines

To resolve this issue, do the following if gobject-introspection is selected:
- Add gobject-introspection to AVAHI_DEPENDENCIES
- Add --enable-gobject to AVAHI_CONF_OPTS
- Add the appropriate directories to GIR_EXTRA_LIBS_PATH.

Fixes:
http://autobuild.buildroot.net/results/b9bf7cea8be9231552a10e8ea828bf24394402ba

Compile tested on x64 for cortex-a15 with toolchain-external-arm-arm.

Regards,
Michael

Quoted 29 lines
---
 package/avahi/avahi.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/avahi/avahi.mk +7 -0
index 73db37545f..3e858083af 100644
@@ -94,6 +94,13 @@ else
 AVAHI_CONF_OPTS += --disable-glib --disable-gobject
 endif
 
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+AVAHI_DEPENDENCIES += gobject-introspection
+AVAHI_CONF_OPTS += --enable-gobject
+AVAHI_MAKE_ENV += \
+	GIR_EXTRA_LIBS_PATH="$(@D)/avahi-gobject/.libs:$(@D)/avahi-common/.libs:$(@D)/avahi-client/.libs:$(@D)/avahi-glib/.libs"
+endif
+
 ifeq ($(BR2_PACKAGE_PYTHON),y)
 AVAHI_CONF_ENV += \
 	am_cv_pathless_PYTHON=python \
Signature · 6 lines
2.26.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
#2 lore raw

PATCH 1/1 package/avahi: fix building against gobject-introspection

In reply to aduskett at gmail.com

package/avahi/avahi.mk else · line 101

Quoted 5 lines · On Thu, 13 Aug 2020 16:23:51 -0700 aduskett at gmail.com wrote:
package/avahi/avahi.mk +5 -0
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+AVAHI_DEPENDENCIES += gobject-introspection
+AVAHI_CONF_OPTS += --enable-gobject
+AVAHI_MAKE_ENV += \
+	GIR_EXTRA_LIBS_PATH="$(@D)/avahi-gobject/.libs:$(@D)/avahi-common/.libs:$(@D)/avahi-client/.libs:$(@D)/avahi-glib/.libs"

This really isn't very neat. Isn't there a better solution?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/avahi: fix building against gobject-introspection

Quoted 4 lines · Thomas Petazzoni

On Thu, 13 Aug 2020 16:23:51 -0700
aduskett at gmail.com wrote:

Quoted 8 lines

package/avahi/avahi.mk else · line 101

Quoted 5 lines
package/avahi/avahi.mk +5 -0
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+AVAHI_DEPENDENCIES += gobject-introspection
+AVAHI_CONF_OPTS += --enable-gobject
+AVAHI_MAKE_ENV += \
+     GIR_EXTRA_LIBS_PATH="$(@D)/avahi-gobject/.libs:$(@D)/avahi-common/.libs:$(@D)/avahi-client/.libs:$(@D)/avahi-glib/.libs"

This really isn't very neat. Isn't there a better solution?

Maybe? But that's why the GIR_EXTRA_LABS_PATH macro exists, is for situations just like this.

Adam

Quoted 5 lines

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#4 lore raw

PATCH 1/1 package/avahi: fix building against gobject-introspection

Quoted 4 lines · On Fri, 14 Aug 2020 12:27:46 -0700 Adam Duskett <[email protected]> wrote:
Quoted 2 lines

This really isn't very neat. Isn't there a better solution?

Maybe? But that's why the GIR_EXTRA_LABS_PATH macro exists, is for situations just like this.

It seems absolutely awful that within the build of a package this kind of variable is needed. If it was to point to libraries installed by other packages, why not. But here, the package build system itself is not capable of finding its own libraries?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/1 package/avahi: fix building against gobject-introspection

Thomas, All,

On 2020-08-14 21:37 +0200, Thomas Petazzoni spake thusly:

Quoted 5 lines
Quoted 2 lines · On Fri, 14 Aug 2020 12:27:46 -0700 Adam Duskett <[email protected]> wrote:
Quoted 2 lines

This really isn't very neat. Isn't there a better solution?

Quoted 7 lines
Quoted 2 lines

Maybe? But that's why the GIR_EXTRA_LABS_PATH macro exists, is for situations just like this.

It seems absolutely awful that within the build of a package this kind of variable is needed. If it was to point to libraries installed by other packages, why not. But here, the package build system itself is not capable of finding its own libraries?

Remember that this is GOI we are speaking of, here! ;-)

More seriously, though, remember that this is also going through the wrappers, backed by qemu because this is executing foreign code...

And again, GOI. Meh... ;-]

Regards,
Yann E. MORIN.

Quoted 9 lines

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#6 lore raw

PATCH 1/1 package/avahi: fix building against gobject-introspection

In reply to aduskett at gmail.com
Quoted 23 lines · On Thu, 13 Aug 2020 16:23:51 -0700 aduskett at gmail.com wrote:

From: Adam Duskett <[email protected]>

Currently, if gobject-introspection is built before avahi, avahi will fail to build with several undefined reference errors due to several .libs directories not being in the PATH when linking the .gir file.

To resolve this issue, do the following if gobject-introspection is selected:
- Add gobject-introspection to AVAHI_DEPENDENCIES
- Add --enable-gobject to AVAHI_CONF_OPTS
- Add the appropriate directories to GIR_EXTRA_LIBS_PATH.

Fixes:
http://autobuild.buildroot.net/results/b9bf7cea8be9231552a10e8ea828bf24394402ba

---
 package/avahi/avahi.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/avahi/avahi.mk +0 -0
index 73db37545f..3e858083af 100644

package/avahi/avahi.mk else · line 99

Quoted 6 lines
package/avahi/avahi.mk +3 -0
@@ -94,6 +94,13 @@ else
 AVAHI_CONF_OPTS += --disable-glib --disable-gobject
 endif
 
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+AVAHI_DEPENDENCIES += gobject-introspection
+AVAHI_CONF_OPTS += --enable-gobject

This is wrong. The gobject option is not about gobject-introspection. From the configure.ac:

AC_ARG_ENABLE(gobject,

        AS_HELP_STRING([--disable-gobject],[Disable use of GLib GObject]),
        [case "${enableval}" in
                yes) HAVE_GOBJECT=yes ;;
                no)  HAVE_GOBJECT=no ;;
                *) AC_MSG_ERROR(bad value ${enableval} for --enable-gobject) ;;
        esac],
        [HAVE_GOBJECT=yes])

if test "x$HAVE_GOBJECT" = "xyes" ; then

        PKG_CHECK_MODULES(GOBJECT, [ glib-2.0 >= 2.4.0 gobject-2.0 ])
        AC_SUBST(GOBJECT_CFLAGS)
        AC_SUBST(GOBJECT_LIBS)

fi
AM_CONDITIONAL(HAVE_GOBJECT, test "x$HAVE_GOBJECT" = "xyes")

The proper option is --enable-introspection / --disable-introspection.

package/avahi/avahi.mk else · line 101

Quoted 2 lines
package/avahi/avahi.mk +2 -0
+AVAHI_MAKE_ENV += \
+	GIR_EXTRA_LIBS_PATH="$(@D)/avahi-gobject/.libs:$(@D)/avahi-common/.libs:$(@D)/avahi-client/.libs:$(@D)/avahi-glib/.libs"

I see OpenEmbedded is doing the same thing:
http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-connectivity/avahi/avahi.inc?h=rocko#n73

Still, I find that atrocious :-/

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#7 lore raw

PATCH 1/1 package/avahi: fix building against gobject-introspection

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 25 lines

package/avahi/avahi.mk else · line 99

Quoted 3 lines
package/avahi/avahi.mk +3 -0
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+AVAHI_DEPENDENCIES += gobject-introspection
+AVAHI_CONF_OPTS += --enable-gobject

This is wrong. The gobject option is not about gobject-introspection. From the configure.ac:

AC_ARG_ENABLE(gobject,

        AS_HELP_STRING([--disable-gobject],[Disable use of GLib GObject]),
        [case "${enableval}" in
                yes) HAVE_GOBJECT=yes ;;
                no)  HAVE_GOBJECT=no ;;
                *) AC_MSG_ERROR(bad value ${enableval} for --enable-gobject) ;;
        esac],
        [HAVE_GOBJECT=yes])

if test "x$HAVE_GOBJECT" = "xyes" ; then

        PKG_CHECK_MODULES(GOBJECT, [ glib-2.0 >= 2.4.0 gobject-2.0 ])
        AC_SUBST(GOBJECT_CFLAGS)
        AC_SUBST(GOBJECT_LIBS)

fi
AM_CONDITIONAL(HAVE_GOBJECT, test "x$HAVE_GOBJECT" = "xyes")

The proper option is --enable-introspection / --disable-introspection.

Quoted 7 lines

package/avahi/avahi.mk else · line 101

Quoted 2 lines
package/avahi/avahi.mk +2 -0
+AVAHI_MAKE_ENV += \
+	GIR_EXTRA_LIBS_PATH="$(@D)/avahi-gobject/.libs:$(@D)/avahi-common/.libs:$(@D)/avahi-client/.libs:$(@D)/avahi-glib/.libs"

I see OpenEmbedded is doing the same thing:
http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-connectivity/avahi/avahi.inc?h=rocko#n73

Still, I find that atrocious :-/

Agreed. I haven't seen any updates on this, but we need to fix the build issues for 2020.08, so I've sent a patch to simply disable introspection support:

https://patchwork.ozlabs.org/project/buildroot/patch/20200831140035.5880-1-peter at korsgaard.com/

We can then refine it later to add introspection support once the issues have been fixed for next.

Signature · 1 line
Bye, Peter Korsgaard