Skip to contentSkip to conversation

ARM: dts: aspeed: rainier: Add I2C buses for NVMe use

PATCH In review Jet Li 4 participants 4 messages Sep 1, 2020 – Sep 4, 2020

Subsystems (2)
lore
Share & tools
lore

Jet Li

author
#0 lore raw

PATCH v2 1/1 ARM: dts: aspeed: rainier: Add I2C buses for NVMe use

From: Jet Li <[email protected]>

Adding pca9552 exposes the presence detect lines for the cards and tca9554 exposes the presence details for the cards.

---
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 105 +++++++++++++++++++++++++++
 1 file changed, 105 insertions(+)
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +105 -0
index d20cdf3c..e803133 100644
@@ -300,6 +300,21 @@
 		compatible = "atmel,24c64";
 		reg = <0x51>;
 	};
+
+	tca9554@40 {
+		compatible = "ti,tca9554";
+		reg = <0x40>;
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		smbus0 {
+			gpio-hog;
+			gpios = <4 GPIO_ACTIVE_HIGH>;
+			output-high;
+			line-name = "smbus0";
+		};
+	};
+
 };
 
 &i2c1 {
@@ -614,6 +629,96 @@
 		compatible = "atmel,24c64";
 		reg = <0x51>;
 	};
+
+	pca1: pca9552@61 {
+		compatible = "nxp,pca9552";
+		reg = <0x61>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		gpio@0 {
+			reg = <0>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@1 {
+			reg = <1>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@2 {
+			reg = <2>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@3 {
+			reg = <3>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@4 {
+			reg = <4>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@5 {
+			reg = <5>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@6 {
+			reg = <6>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@7 {
+			reg = <7>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@8 {
+			reg = <8>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@9 {
+			reg = <9>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@10 {
+			reg = <10>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@11 {
+			reg = <11>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@12 {
+			reg = <12>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@13 {
+			reg = <13>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@14 {
+			reg = <14>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+
+		gpio@15 {
+			reg = <15>;
+			type = <PCA955X_TYPE_GPIO>;
+		};
+	};
+
 };
 
 &i2c9 {
Signature · 1 line
2.7.4
maintainer
#1 lore raw

Hello,

Quoted 5 lines · Jet Li

From: Jet Li <[email protected]>

Adding pca9552 exposes the presence detect lines for the cards and tca9554 exposes the presence details for the cards.

This patch is already in dev-5.8 as a3ce4e380958571814bbf3e237e6496d5b35153b.

Cheers,

Joel

Quoted 133 lines
---
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 105 +++++++++++++++++++++++++++
 1 file changed, 105 insertions(+)
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +105 -1
index d20cdf3c..e803133 100644
@@ -300,6 +300,21 @@
                compatible = "atmel,24c64";
                reg = <0x51>;
        };
+
+       tca9554@40 {
+               compatible = "ti,tca9554";
+               reg = <0x40>;
+               gpio-controller;
+               #gpio-cells = <2>;
+
+               smbus0 {
+                       gpio-hog;
+                       gpios = <4 GPIO_ACTIVE_HIGH>;
+                       output-high;
+                       line-name = "smbus0";
+               };
+       };
+
 };
 
 &i2c1 {
@@ -614,6 +629,96 @@
                compatible = "atmel,24c64";
                reg = <0x51>;
        };
+
+       pca1: pca9552@61 {
+               compatible = "nxp,pca9552";
+               reg = <0x61>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+               gpio-controller;
+               #gpio-cells = <2>;
+
+               gpio@0 {
+                       reg = <0>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@1 {
+                       reg = <1>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@2 {
+                       reg = <2>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@3 {
+                       reg = <3>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@4 {
+                       reg = <4>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@5 {
+                       reg = <5>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@6 {
+                       reg = <6>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@7 {
+                       reg = <7>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@8 {
+                       reg = <8>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@9 {
+                       reg = <9>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@10 {
+                       reg = <10>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@11 {
+                       reg = <11>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@12 {
+                       reg = <12>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@13 {
+                       reg = <13>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@14 {
+                       reg = <14>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@15 {
+                       reg = <15>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+       };
+
 };
 
 &i2c9 {
--

2.7.4

#2 lore raw

Hi,

Quoted 7 lines · Joel Stanley

Hello,

Quoted 4 lines · Jet Li

From: Jet Li <[email protected]>

Adding pca9552 exposes the presence detect lines for the cards and tca9554 exposes the presence details for the cards.

This change looks incorrect. Per the Rainier workbook,

there is no TCA chip at 0x40 on i2c0. The chip is at 0x20

and only has presence GPIOs (inputs).

Why is this using a gpio-hog to set this as an output?

--

Santosh

Quoted 138 lines

This patch is already in dev-5.8 as a3ce4e380958571814bbf3e237e6496d5b35153b.

Cheers,

Joel

Quoted 132 lines
---
  arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 105 +++++++++++++++++++++++++++
  1 file changed, 105 insertions(+)
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +105 -1
index d20cdf3c..e803133 100644
@@ -300,6 +300,21 @@
                 compatible = "atmel,24c64";
                 reg = <0x51>;
         };
+
+       tca9554@40 {
+               compatible = "ti,tca9554";
+               reg = <0x40>;
+               gpio-controller;
+               #gpio-cells = <2>;
+
+               smbus0 {
+                       gpio-hog;
+                       gpios = <4 GPIO_ACTIVE_HIGH>;
+                       output-high;
+                       line-name = "smbus0";
+               };
+       };
+
  };
 
  &i2c1 {
@@ -614,6 +629,96 @@
                 compatible = "atmel,24c64";
                 reg = <0x51>;
         };
+
+       pca1: pca9552@61 {
+               compatible = "nxp,pca9552";
+               reg = <0x61>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+               gpio-controller;
+               #gpio-cells = <2>;
+
+               gpio@0 {
+                       reg = <0>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@1 {
+                       reg = <1>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@2 {
+                       reg = <2>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@3 {
+                       reg = <3>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@4 {
+                       reg = <4>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@5 {
+                       reg = <5>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@6 {
+                       reg = <6>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@7 {
+                       reg = <7>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@8 {
+                       reg = <8>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@9 {
+                       reg = <9>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@10 {
+                       reg = <10>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@11 {
+                       reg = <11>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@12 {
+                       reg = <12>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@13 {
+                       reg = <13>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@14 {
+                       reg = <14>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@15 {
+                       reg = <15>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+       };
+
  };
 
  &i2c9 {
--

2.7.4

#3 lore raw

Hi,  thanks for point that the right address and help sending upstream.   Jet   ----- Original message -----
From: Santosh Puranik <[email protected]>
To: Jet Li <[email protected]>
Cc: Joel Stanley <[email protected]>, Andrew Jeffery <[email protected]>, Jet Li <[email protected]>, OpenBMC Maillist <[email protected]>
Subject: [EXTERNAL] Re: [PATCH linux dev-5.8 v2] ARM: dts: aspeed: rainier: Add I2C buses for NVMe use
Date: Thu, Sep 3, 2020 1:16 AM
  Hi,

Quoted 7 lines · Joel Stanley

Hello,

Quoted 4 lines · Jet Li

From: Jet Li <[email protected]>

Adding pca9552 exposes the presence detect lines for the cards and tca9554 exposes the presence details for the cards.

This change looks incorrect. Per the Rainier workbook,

there is no TCA chip at 0x40 on i2c0. The chip is at 0x20

and only has presence GPIOs (inputs).

Why is this using a gpio-hog to set this as an output?

--

Santosh

Quoted 134 lines

This patch is already in dev-5.8 as a3ce4e380958571814bbf3e237e6496d5b35153b.

Cheers,

Joel

Quoted 128 lines

---
  arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 105 +++++++++++++++++++++++++++

  1 file changed, 105 insertions(+)
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +105 -0
index d20cdf3c..e803133 100644
@@ -300,6 +300,21 @@
                  compatible = "atmel,24c64";
                  reg = <0x51>;
          };
+
+       tca9554@40 {
+               compatible = "ti,tca9554";
+               reg = <0x40>;
+               gpio-controller;
+               #gpio-cells = <2>;
+
+               smbus0 {
+                       gpio-hog;
+                       gpios = <4 GPIO_ACTIVE_HIGH>;
+                       output-high;
+                       line-name = "smbus0";
+               };
+       };
+
   };
 
   &i2c1 {
@@ -614,6 +629,96 @@
                  compatible = "atmel,24c64";
                  reg = <0x51>;
          };
+
+       pca1: pca9552@61 {
+               compatible = "nxp,pca9552";
+               reg = <0x61>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+               gpio-controller;
+               #gpio-cells = <2>;
+
+               gpio@0 {
+                       reg = <0>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@1 {
+                       reg = <1>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@2 {
+                       reg = <2>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@3 {
+                       reg = <3>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@4 {
+                       reg = <4>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@5 {
+                       reg = <5>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@6 {
+                       reg = <6>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@7 {
+                       reg = <7>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@8 {
+                       reg = <8>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@9 {
+                       reg = <9>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@10 {
+                       reg = <10>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@11 {
+                       reg = <11>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@12 {
+                       reg = <12>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@13 {
+                       reg = <13>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@14 {
+                       reg = <14>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+
+               gpio@15 {
+                       reg = <15>;
+                       type = <PCA955X_TYPE_GPIO>;
+               };
+       };
+
   };
 
Quoted 4 lines
Quoted 4 lines
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +0 -1
   &i2c9 {
--

2.7.4